[I] Add Azure Trusted Signing Support [cordova-electron]

2025-02-19 Thread via GitHub
OPSnake opened a new issue, #281: URL: https://github.com/apache/cordova-electron/issues/281 # Feature Request ## Motivation Behind Feature To improve security and simplify the build workflow, it is essential to integrate support for Azure Trusted Signing into cordova-electron. Sin

Re: [PR] feat: add AndroidWindowOptOutEdgeToEdgeEnforcement preference & theme flag [cordova-android]

2025-02-19 Thread via GitHub
erisu commented on PR #1779: URL: https://github.com/apache/cordova-android/pull/1779#issuecomment-2670302754 Last call for reviews before merging in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: add AndroidWindowOptOutEdgeToEdgeEnforcement preference & theme flag [cordova-android]

2025-02-19 Thread via GitHub
dpogue commented on PR #1779: URL: https://github.com/apache/cordova-android/pull/1779#issuecomment-2670328302 I do sortof question if it's worth merging this knowing that it's going to be deprecated immediately in the next release. Unfortunately there aren't really any alternatives a

Re: [PR] fix: move gradle wrapper from tools to platform root dir [cordova-android]

2025-02-19 Thread via GitHub
breautek commented on PR #1781: URL: https://github.com/apache/cordova-android/pull/1781#issuecomment-2669876360 To solve https://github.com/apache/cordova-android/issues/1760 I think what we should do is copy the generated `gradle`, `gradlew`, and `gradlew.bat` files up a directory o

Re: [PR] fix: move gradle wrapper from tools to platform root dir [cordova-android]

2025-02-19 Thread via GitHub
breautek commented on PR #1781: URL: https://github.com/apache/cordova-android/pull/1781#issuecomment-2669846779 > removed tools/settings.gradle. Appears not needed. It will be needed if the installed gradle at the system level is less than what AGP requires. That was the whole point

Re: [PR] fix: move gradle wrapper from tools to platform root dir [cordova-android]

2025-02-19 Thread via GitHub
breautek commented on PR #1781: URL: https://github.com/apache/cordova-android/pull/1781#issuecomment-2669908003 This is kind of out of scope for https://github.com/apache/cordova-android/issues/1760 but I also notice that we don't install the wrapper on create. I think it may only occur on