Re: [PR] refactor: update and simplify some dependencies [cordova-js]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #281: URL: https://github.com/apache/cordova-js/pull/281#issuecomment-2436878255 ## [Codecov](https://app.codecov.io/gh/apache/cordova-js/pull/281?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[PR] refactor: update and simplify some dependencies [cordova-js]

2024-10-24 Thread via GitHub
dpogue opened a new pull request, #281: URL: https://github.com/apache/cordova-js/pull/281 ### Motivation and Context Since we can't adopt the latest versions of execa and globby due to ESM, and we use them for very specific purposes here, replace them with built-ins where possib

[PR] fix(android): Regression breaking resolved DOM-usable file:// paths [cordova-plugin-file]

2024-10-24 Thread via GitHub
breautek opened a new pull request, #640: URL: https://github.com/apache/cordova-plugin-file/pull/640 ### Platforms affected Android ### Motivation and Context Regression from https://github.com/apache/cordova-plugin-file/commit/99ca43990c0bcdf19645367a27

Re: [PR] chore(ci): Add Node 22 to CI and fix dependabot PRs [cordova-js]

2024-10-24 Thread via GitHub
github-advanced-security[bot] commented on PR #282: URL: https://github.com/apache/cordova-js/pull/282#issuecomment-2436901206 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull req

Re: [PR] chore(ci): Add Node 22 to CI and fix dependabot PRs [cordova-js]

2024-10-24 Thread via GitHub
codecov-commenter commented on PR #282: URL: https://github.com/apache/cordova-js/pull/282#issuecomment-2436901734 ## [Codecov](https://app.codecov.io/gh/apache/cordova-js/pull/282?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

Re: [PR] refactor: update and simplify some dependencies [cordova-js]

2024-10-24 Thread via GitHub
dpogue merged PR #281: URL: https://github.com/apache/cordova-js/pull/281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apa

Re: [PR] chore(ci): Add Node 22 to CI and fix dependabot PRs [cordova-js]

2024-10-24 Thread via GitHub
dpogue merged PR #282: URL: https://github.com/apache/cordova-js/pull/282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apa

Re: [PR] Remove es6-promise-plugin [cordova-plugin-screen-orientation]

2024-10-24 Thread via GitHub
breautek commented on PR #129: URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/129#issuecomment-2435869900 The android failures are due to the CI config being outdated and using too old of a JVM. As of right now it doesn't require any action in this PR. Once the

Re: [PR] fix(android): Removed read and write media permissions to allow to use Android photo picker #866 [cordova-plugin-camera]

2024-10-24 Thread via GitHub
breautek commented on PR #889: URL: https://github.com/apache/cordova-plugin-camera/pull/889#issuecomment-2435752508 @ravi-yk I think I'm going to fork your PR to extend what you've done even further. This way you're contributions are still credited in the form of a commit. The reas

Re: [PR] fix(android): Removed read and write media permissions to allow to use Android photo picker #866 [cordova-plugin-camera]

2024-10-24 Thread via GitHub
breautek merged PR #889: URL: https://github.com/apache/cordova-plugin-camera/pull/889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [I] Allow using Android photo picker instead of READ_MEDIA_IMAGES and READ_MEDIA_VIDEO [cordova-plugin-camera]

2024-10-24 Thread via GitHub
breautek closed issue #866: Allow using Android photo picker instead of READ_MEDIA_IMAGES and READ_MEDIA_VIDEO URL: https://github.com/apache/cordova-plugin-camera/issues/866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] App Stuck on Splash Screen in Xcode 16 only [cordova-ios]

2024-10-24 Thread via GitHub
breautek commented on issue #1500: URL: https://github.com/apache/cordova-ios/issues/1500#issuecomment-2435277348 > Its now freezing on launch screen without any errors in log. I faced this issue after updating xcode to v 16 XCode logs or safari JS console? "Stuck on splash scr

[PR] Fix/always return content uris [cordova-plugin-camera]

2024-10-24 Thread via GitHub
breautek opened a new pull request, #902: URL: https://github.com/apache/cordova-plugin-camera/pull/902 This PR contains https://github.com/apache/cordova-plugin-camera/pull/901, will rebase after it's merged. ### Platforms affected Android ### Motivation and Con

Re: [I] The app crashes when taking photos on Android 14 [cordova-plugin-camera]

2024-10-24 Thread via GitHub
lmarcelocc commented on issue #891: URL: https://github.com/apache/cordova-plugin-camera/issues/891#issuecomment-2434703393 > Has anyone managed to find a fix for this? When I click on my button that triggers `getPicture()`, nothing happens on Android 14. You need to check the log. I