Re: [PR] WIP docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498#issuecomment-2412070128 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1498?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

[PR] WIP docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
dpogue opened a new pull request, #1498: URL: https://github.com/apache/cordova-ios/pull/1498 ### Platforms affected Docs ### Motivation and Context ### Description ### Testing ### Checklist - [ ] I've r

Re: [PR] WIP docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
dpogue commented on code in PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498#discussion_r1799979744 ## CordovaLib/CordovaLib.docc/upgrading-8.md: ## @@ -0,0 +1,189 @@ +# Upgrading Plugins to Cordova iOS 8.x + + +A guide for plugin authors to understand the API chan

Re: [PR] WIP docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
dpogue commented on code in PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498#discussion_r1799982027 ## CordovaLib/CordovaLib.docc/upgrading-8.md: ## @@ -0,0 +1,189 @@ +# Upgrading Plugins to Cordova iOS 8.x + + +A guide for plugin authors to understand the API chan

Re: [PR] docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
dpogue commented on code in PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498#discussion_r1800527751 ## CordovaLib/CordovaLib.docc/upgrading-8.md: ## @@ -0,0 +1,189 @@ +# Upgrading Plugins to Cordova iOS 8.x + + +A guide for plugin authors to understand the API chan

Re: [PR] docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-14 Thread via GitHub
GitToTheHub commented on code in PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498#discussion_r1800506481 ## CordovaLib/CordovaLib.docc/upgrading-8.md: ## @@ -0,0 +1,189 @@ +# Upgrading Plugins to Cordova iOS 8.x + + +A guide for plugin authors to understand the API

Re: [I] Promises [cordova-plugin-file]

2024-10-14 Thread via GitHub
breautek commented on issue #637: URL: https://github.com/apache/cordova-plugin-file/issues/637#issuecomment-2411291544 > @breautek Nobody reacted on this except you, is this a lazy agreement? I would send out a "final call" email which can read something to the effect of: > F

[PR] fix: WKWebView leak in the platform centered approach [cordova-ios]

2024-10-14 Thread via GitHub
msmtamburro opened a new pull request, #1497: URL: https://github.com/apache/cordova-ios/pull/1497 ### Platforms affected iOS ### Motivation and Context Addresses #1486 ### Description Simply clears the _webViewEngine stored property in

Re: [I] Promises [cordova-plugin-file]

2024-10-14 Thread via GitHub
GitToTheHub commented on issue #637: URL: https://github.com/apache/cordova-plugin-file/issues/637#issuecomment-2411552605 Ok thanks, then I will do a final call. I'm registered in Slack, but the mailing list is ok for me. And as you wrote, the PR will be a discussion ground about th

Re: [PR] fix: WKWebView leak in the platform centered approach [cordova-ios]

2024-10-14 Thread via GitHub
codecov-commenter commented on PR #1497: URL: https://github.com/apache/cordova-ios/pull/1497#issuecomment-2411838363 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1497?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [PR] fix: WKWebView leak in the platform centered approach [cordova-ios]

2024-10-14 Thread via GitHub
dpogue merged PR #1497: URL: https://github.com/apache/cordova-ios/pull/1497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [I] Platform centered approach: let's add a way to destroy a WKWebView when done [cordova-ios]

2024-10-14 Thread via GitHub
dpogue closed issue #1486: Platform centered approach: let's add a way to destroy a WKWebView when done URL: https://github.com/apache/cordova-ios/issues/1486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above