Re: [PR] fix!: Deprecate(/Remove) scrollView category extension on UIView [cordova-ios]

2024-08-24 Thread via GitHub
dpogue commented on PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400#issuecomment-2308163766 The equivalent Objective C code would be (copied from the statusbar plugin): ```objc - (UIScrollView *)webViewScrollView { SEL scrollViewSelector = NSSelectorFromStri

Re: [PR] fix!: Deprecate(/Remove) scrollView category extension on UIView [cordova-ios]

2024-08-24 Thread via GitHub
dpogue merged PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [I] Please remove org_apache_cordova_UIView_Extension because it isn't necessary since iOS 8. [cordova-ios]

2024-08-24 Thread via GitHub
dpogue closed issue #1399: Please remove org_apache_cordova_UIView_Extension because it isn't necessary since iOS 8. URL: https://github.com/apache/cordova-ios/issues/1399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] Please remove org_apache_cordova_UIView_Extension because it isn't necessary since iOS 8. [cordova-ios]

2024-08-24 Thread via GitHub
dpogue closed issue #1399: Please remove org_apache_cordova_UIView_Extension because it isn't necessary since iOS 8. URL: https://github.com/apache/cordova-ios/issues/1399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] refactor: Reorder methods in CDVViewController [cordova-ios]

2024-08-24 Thread via GitHub
dpogue opened a new pull request, #1475: URL: https://github.com/apache/cordova-ios/pull/1475 ### Platforms affected iOS ### Motivation and Context Methods in CDVViewController are spread all over with no logical grouping to make them easier to find.

Re: [PR] refactor: Reorder methods in CDVViewController [cordova-ios]

2024-08-24 Thread via GitHub
codecov-commenter commented on PR #1475: URL: https://github.com/apache/cordova-ios/pull/1475#issuecomment-2308169375 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1475?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [PR] refactor: Reorder methods in CDVViewController [cordova-ios]

2024-08-24 Thread via GitHub
dpogue merged PR #1475: URL: https://github.com/apache/cordova-ios/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

[PR] docs(CordovaLib): Start filling out DocC comments [cordova-ios]

2024-08-24 Thread via GitHub
dpogue opened a new pull request, #1476: URL: https://github.com/apache/cordova-ios/pull/1476 ### Platforms affected iOS ### Motivation and Context The API available to people embedding CordovaLib as a framework in their existing apps is not well documented, nor is t

Re: [PR] refactor!: Major API cleanup (WIP) [cordova-ios]

2024-08-24 Thread via GitHub
dpogue closed pull request #1454: refactor!: Major API cleanup (WIP) URL: https://github.com/apache/cordova-ios/pull/1454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] docs(CordovaLib): Start filling out DocC comments [cordova-ios]

2024-08-24 Thread via GitHub
codecov-commenter commented on PR #1476: URL: https://github.com/apache/cordova-ios/pull/1476#issuecomment-2308221709 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1476?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

Re: [I] Release including Swift Package Manager support [cordova-ios]

2024-08-24 Thread via GitHub
dpogue closed issue #1267: Release including Swift Package Manager support URL: https://github.com/apache/cordova-ios/issues/1267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Release including Swift Package Manager support [cordova-ios]

2024-08-24 Thread via GitHub
dpogue commented on issue #1267: URL: https://github.com/apache/cordova-ios/issues/1267#issuecomment-2308258333 Going to close this issue. Support for consuming CordovaLib as a Swift package was added in version 7.0.0. Support for plugins using Swift packages is an open issue being tr

Re: [PR] docs(CordovaLib): Start filling out DocC comments [cordova-ios]

2024-08-24 Thread via GitHub
erisu commented on code in PR #1476: URL: https://github.com/apache/cordova-ios/pull/1476#discussion_r1729952844 ## CordovaLib/include/Cordova/CDVViewController.h: ## @@ -32,11 +32,39 @@ NS_ASSUME_NONNULL_BEGIN +/** + A view controller that specializes in displaying Cordova

[PR] refactor: Move CDVURLSchemeHandler to private API [cordova-ios]

2024-08-24 Thread via GitHub
dpogue opened a new pull request, #1477: URL: https://github.com/apache/cordova-ios/pull/1477 ### Platforms affected iOS ### Motivation and Context This is only used by the WKWebView plugin, and there's no way to do anything meaningful with it as public API, so it pr

Re: [PR] docs(CordovaLib): Start filling out DocC comments [cordova-ios]

2024-08-24 Thread via GitHub
dpogue commented on code in PR #1476: URL: https://github.com/apache/cordova-ios/pull/1476#discussion_r1730151076 ## CordovaLib/include/Cordova/CDVViewController.h: ## @@ -32,11 +32,39 @@ NS_ASSUME_NONNULL_BEGIN +/** + A view controller that specializes in displaying Cordov

Re: [PR] refactor: Move CDVURLSchemeHandler to private API [cordova-ios]

2024-08-24 Thread via GitHub
codecov-commenter commented on PR #1477: URL: https://github.com/apache/cordova-ios/pull/1477#issuecomment-2308551914 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1477?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c