Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-13 Thread via GitHub
breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107170202 > Also the .ratignore changes could be reverted, but if reverted, need to add at least gradle-wrapper.properties. This this file is detected if anyone runs locally a rat test aft

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-13 Thread via GitHub
breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107186674 > I consider it a 'hard requirement' for users to upgrade to Android Studio Jellyfish at a minimum for successful builds and seamless functionality from Android Studio, as the te

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-13 Thread via GitHub
breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107302119 I've reverted AGP down to 8.3 Jellyfish appears to bundle Gradle 8.4 by default and will fail on installing the wrapper due to AGP 8.4's requirement on Gradle 8.6. In order

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-13 Thread via GitHub
github-advanced-security[bot] commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2107466397 This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this p

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-13 Thread via GitHub
breautek merged PR #1678: URL: https://github.com/apache/cordova-android/pull/1678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [I] Support AGP 8.1+ by using JVM 17 [cordova-android]

2024-05-13 Thread via GitHub
breautek closed issue #1661: Support AGP 8.1+ by using JVM 17 URL: https://github.com/apache/cordova-android/issues/1661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat: bump kotlin 1.9.24 & drop kotlin-android-extensions when kotlin >= 1.8.0 [cordova-android]

2024-05-13 Thread via GitHub
erisu merged PR #1543: URL: https://github.com/apache/cordova-android/pull/1543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordo

Re: [I] Will Cordova Android 13 support Kotlin 1.9.x ? [cordova-android]

2024-05-13 Thread via GitHub
erisu closed issue #1692: Will Cordova Android 13 support Kotlin 1.9.x ? URL: https://github.com/apache/cordova-android/issues/1692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Configure the need of `kotlin-android-extensions` plugin to support Kotlin 1.9 [cordova-android]

2024-05-13 Thread via GitHub
erisu closed issue #1642: Configure the need of `kotlin-android-extensions` plugin to support Kotlin 1.9 URL: https://github.com/apache/cordova-android/issues/1642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] chore: bump version 3.0.0-dev [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu opened a new pull request, #197: URL: https://github.com/apache/cordova-plugin-device/pull/197 ### Platforms affected n/a ### Motivation and Context Bump for 3.0.0 release ### Description Bump package version ### Testing

[PR] ci: update gh-action's workflow [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu opened a new pull request, #198: URL: https://github.com/apache/cordova-plugin-device/pull/198 ### Platforms affected n/a ### Motivation and Context Update CI Workflow ### Description Updated: - Dependencies - Android test

Re: [I] Issue with `` and `cordora prepare ios` [cordova-ios]

2024-05-13 Thread via GitHub
Yura13 commented on issue #1418: URL: https://github.com/apache/cordova-ios/issues/1418#issuecomment-2108073172 @shajz I have the same problem. How do you resolve it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] ci: update gh-action's workflow [cordova-plugin-device]

2024-05-13 Thread via GitHub
breautek commented on code in PR #198: URL: https://github.com/apache/cordova-plugin-device/pull/198#discussion_r1598751290 ## .github/workflows/android.yml: ## @@ -67,27 +67,33 @@ jobs: - android: 11 android-api: 30 - - android: 12 -

Re: [PR] chore: bump version 3.0.0-dev [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu merged PR #197: URL: https://github.com/apache/cordova-plugin-device/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [I] Issue with `` and `cordora prepare ios` [cordova-ios]

2024-05-13 Thread via GitHub
shajz commented on issue #1418: URL: https://github.com/apache/cordova-ios/issues/1418#issuecomment-2108621678 @Yura13 I was using xml2js https://www.npmjs.com/package/xml2js which doesn't preserve XML elements order. I switched to https://www.npmjs.com/package/fast-xml-parser. Here'

Re: [I] window.open doesnt work inside the opened webview [cordova-plugin-inappbrowser]

2024-05-13 Thread via GitHub
jcesarmobile closed issue #1046: window.open doesnt work inside the opened webview URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/1046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] window.open doesnt work inside the opened webview [cordova-plugin-inappbrowser]

2024-05-13 Thread via GitHub
jcesarmobile commented on issue #1046: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/1046#issuecomment-2108747384 Closing since there was no response -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix!: remove deprecated platforms [cordova-plugin-device]

2024-05-13 Thread via GitHub
jcesarmobile merged PR #181: URL: https://github.com/apache/cordova-plugin-device/pull/181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [I] Drop cordova-osx support [cordova-plugin-device]

2024-05-13 Thread via GitHub
jcesarmobile closed issue #155: Drop cordova-osx support URL: https://github.com/apache/cordova-plugin-device/issues/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] refactor(android)!: Remove unused code [cordova-plugin-device]

2024-05-13 Thread via GitHub
jcesarmobile merged PR #183: URL: https://github.com/apache/cordova-plugin-device/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[PR] chore: bump version 3.0.0-dev - package-lock [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu opened a new pull request, #199: URL: https://github.com/apache/cordova-plugin-device/pull/199 ### Platforms affected n/a ### Motivation and Context add missing changes to package-lock ### Description used npm to update package-lock

Re: [PR] ci: update gh-action's workflow [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu commented on code in PR #198: URL: https://github.com/apache/cordova-plugin-device/pull/198#discussion_r1599306374 ## .github/workflows/android.yml: ## @@ -67,27 +67,33 @@ jobs: - android: 11 android-api: 30 - - android: 12 -

Re: [PR] fix(android)!: access Context through webView.getContext() (CB-12623) [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu commented on PR #62: URL: https://github.com/apache/cordova-plugin-device/pull/62#issuecomment-2109177018 I didn't see the engine requirement `cordova-android >= 7.0.0` being added as requested. Will we add it after this PR is merged? -- This is an automated message from the Apa

Re: [PR] chore: bump version 3.0.0-dev - package-lock [cordova-plugin-device]

2024-05-13 Thread via GitHub
erisu merged PR #199: URL: https://github.com/apache/cordova-plugin-device/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [I] iOS 14 will enable Intelligent Tracking Prevention in WKWebView by default [cordova-ios]

2024-05-13 Thread via GitHub
t-knapp commented on issue #922: URL: https://github.com/apache/cordova-ios/issues/922#issuecomment-2109405899 I face a similar problem with cookies on iOS (cordova-ios v7.1.0). Here is my config.xml ``` [...]