Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-10 Thread via GitHub
breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2104560822 FYI, was talking with Erisu last night and we came up with a plan to remove the JAR and thus avoid the security concerns about the integrity (e.g. xz backdoor style attacks) of t

Re: [I] Cordova is rejecting Java and gradle on windows [cordova-android]

2024-05-10 Thread via GitHub
gotohigher commented on issue #1554: URL: https://github.com/apache/cordova-android/issues/1554#issuecomment-2105051370 cordova -version 12.0.0 (cordova-lib@12.0.1) cordova platform add android@12.0.1 Using cordova-fetch for cordova-android@12.0.1 Adding android project...

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-10 Thread via GitHub
breautek commented on code in PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#discussion_r1597304675 ## lib/builders/ProjectBuilder.js: ## @@ -116,16 +114,17 @@ class ProjectBuilder { return args; } -/* -* This returns a promise -*/

Re: [PR] feat!: API 34 Support [cordova-android]

2024-05-10 Thread via GitHub
breautek commented on PR #1678: URL: https://github.com/apache/cordova-android/pull/1678#issuecomment-2105392642 Some last few changes which I think improves the PR significantly. Like in the original post I really don't like submitting generated content. Utilising an empty gradle pro