Re: [I] Android clicking input type=file brings up system file browser, not camera options [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on issue #816: URL: https://github.com/apache/cordova-android/issues/816#issuecomment-1905700250 It seems that while it works on a Samsung Galaxy A50 running Android 11, it neither works on any Android simulator SDK version (30-34), nor does it work on Pixel 8 running Andr

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1905702318 It seems that while it works on a Samsung Galaxy A50 running Android 11, it neither works on any Android simulator SDK version (30-34), nor does it work on Pixel 8 running Android

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1905923022 The intent passed into the `startActivityForResult` callback has null data, i.e., `intent.getData() == null`. Can't figure out what would cause that. -- This is an automated mess

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906047408 The `intent == null` if-condition should be removed. It should just be: ```java if (captureUri != null) { // camera LOG.v(LOG_TAG, "Adding camera capture: " + captureUri)

Re: [I] Playing video on iOS and shifting from landscape to portrait messes up status bar [cordova-plugin-statusbar]

2024-01-23 Thread via GitHub
Heshyo commented on issue #268: URL: https://github.com/apache/cordova-plugin-statusbar/issues/268#issuecomment-1906185497 I guess I have the same issue. My app is also portrait only, except when playing a video where the player allows both portrait and landscape. If I open a video i

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
KenCorbettJr commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906184281 @jacobg how do they need to be revised? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] camera.getPicture() with FILE_URI destination returns invalid/unexpected image URI [cordova-plugin-camera]

2024-01-23 Thread via GitHub
drogerie21 commented on issue #783: URL: https://github.com/apache/cordova-plugin-camera/issues/783#issuecomment-1906185547 same issue here. Need a content URI to get the proper filename. Is there a way 1) to get a content uri instead of file uri from the camera plugin 2) if not, is

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906213927 Hi @KenCorbettJr Thanks for your pull request. Do you see a "review" that was opened and displayed above your last message. I'll paste it again here: -- The in

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
KenCorbettJr commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906259454 I applied your code review feedback. Should I also add a request for camera permission? Or somehow check if the app already has that permission? -- This is an autom

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906284437 Thanks! I was able to get it working in my app but requesting permission in javascript code first before opening chooser: ```js getFileEl () { return docum

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
breautek commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906327025 > But I'm not sure why @breautek thinks intent doesn't need to grant permission? Maybe there's a different approach? I know there was behaviour which was handled in the cam

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
jacobg commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906380542 Ah, so that explains it. My app does declare CAMERA in the manifest because it has a separate use-case where it needs the camera. If the user has not granted CAMERA permission yet

Re: [PR] feat: add camera intent with file input capture [cordova-android]

2024-01-23 Thread via GitHub
breautek commented on PR #1609: URL: https://github.com/apache/cordova-android/pull/1609#issuecomment-1906404805 > Ah, so that explains it. My app does declare CAMERA in the manifest because it has a separate use-case where it needs the camera. If the user has not granted CAMERA permission

Re: [I] camera.getPicture() with FILE_URI destination returns invalid/unexpected image URI [cordova-plugin-camera]

2024-01-23 Thread via GitHub
mattocchi commented on issue #783: URL: https://github.com/apache/cordova-plugin-camera/issues/783#issuecomment-1907071885 I'm facing same issue with Android 13 using 1) workaround that seem to work for me: ```javascript function onPhotoURISuccess(imgUri) { conso

Re: [I] Playing video on iOS and shifting from landscape to portrait messes up status bar [cordova-plugin-statusbar]

2024-01-23 Thread via GitHub
Heshyo commented on issue #268: URL: https://github.com/apache/cordova-plugin-statusbar/issues/268#issuecomment-1907242819 Another way to make the problem appear: open a video in portrait, then close the player by swiping it down. The app is now on top of the status bar. The is