Re: [PR] refactor!: Remove scrollView category extension on UIView [cordova-ios]

2024-08-20 Thread via GitHub
jcesarmobile commented on PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400#issuecomment-2299812688 I don’t see what’s the problem with introducing a breaking change. Changing the template to swift is also breaking to some plugins and it’s merged. -- This is an automated m

Re: [PR] refactor!: Remove scrollView category extension on UIView [cordova-ios]

2024-08-20 Thread via GitHub
dpogue commented on PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400#issuecomment-2298210243 Status Bar plugin is fixed, but this API is used in a number of 3rd party plugins as well... I feel like our only option is going to be deprecation instead of removal (which doesn't ac

Re: [PR] refactor!: Remove scrollView category extension on UIView [cordova-ios]

2024-08-14 Thread via GitHub
dpogue commented on PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400#issuecomment-2288083327 This causes issues for the statusbar plugin which relies on this to access the scroll view without knowing the specific type of the web view implementation. So putting this on h

Re: [PR] refactor!: Remove scrollView category extension on UIView [cordova-ios]

2024-02-21 Thread via GitHub
codecov-commenter commented on PR #1400: URL: https://github.com/apache/cordova-ios/pull/1400#issuecomment-1957779484 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1400?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=a

[PR] refactor!: Remove scrollView category extension on UIView [cordova-ios]

2024-02-21 Thread via GitHub
dpogue opened a new pull request, #1400: URL: https://github.com/apache/cordova-ios/pull/1400 🚨 **BREAKING API CHANGE!** This should be tested with all the core plugins, just in case any of them are relying on this API existing. ### Platforms affected iOS ### Moti