GitToTheHub commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764629881
Hi,
### `JAVA_HOME` not applied in `config.properties`
I did set `JAVA_HOME`:
`/Library/Java/JavaVirtualMachines/jdk-17.jdk/Contents/Home`
(macOS)
erisu merged PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@cordo
erisu commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764649223
Can you provide the exact step you used to get that result?
I don't get Android Studio's `jbr` with this PR.
```
% echo $JAVA_HOME
/Users/cordova/.sdkman/candidate
GitToTheHub commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764699304
Hi,
thanks for the explanation. I unterstand that this is not in scope of this
pr. I only mentioned it because I noticed it.
But it sounds like you already have some
erisu commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764678803
This PR only focuses on resolving the issue with cordova build. Running
cordova build should properly detect JAVA_HOME and update the gradle config.
However, this PR does not
erisu commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764654678
> I opend it with Android Studio and get the result I described. I didn't
build anything in Android Studio, just opened it.
If you opened with Android Studio and you did not r
GitToTheHub commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764657937
> If you opened with Android Studio and you did not run `cordova build`
first, then yes you will get Android Studio's JBR and is expected behavior.
So I have to always f
GitToTheHub commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764653094
> > ### Build without JAVA_HOME or CORDOVA_JAVA_HOME
> > You wrote:
> > > When running cordova build, if JAVA_HOME is missing, its expected to
not continue as its apart o
erisu commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764651287
> ### Build without JAVA_HOME or CORDOVA_JAVA_HOME
>
> You wrote:
>
> > When running cordova build, if JAVA_HOME is missing, its expected to not
continue as its apart o
GitToTheHub commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764651301
Hi,
after adding the platform via
`cordova platform add
github:erisu/cordova-android\#feat/set-gradle-java-home`
I opend it with Android Studio and get the
codecov-commenter commented on PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2763324129
##
[Codecov](https://app.codecov.io/gh/apache/cordova-android/pull/1795?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campa
github-advanced-security[bot] commented on code in PR #1795:
URL: https://github.com/apache/cordova-android/pull/1795#discussion_r2019783316
##
lib/builders/ProjectBuilder.js:
##
@@ -286,14 +286,44 @@
prepEnv (opts) {
const self = this;
const config = this
erisu opened a new pull request, #1795:
URL: https://github.com/apache/cordova-android/pull/1795
### Motivation, Context & Description
Fix an issue mentioned in a [discussion
thread](https://github.com/apache/cordova/discussions/530#discussioncomment-12605698).
13 matches
Mail list logo
