Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-17 Thread via GitHub
breautek merged PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-16 Thread via GitHub
breautek commented on PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629#issuecomment-2416711762 > If an application is built with the AndroidInsecureFileModeEnabled option set to true in config.xml, the toURL method returns the content:// URL which is not accessible dire

Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-16 Thread via GitHub
lorenzodallavecchia commented on PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629#issuecomment-2416216825 I have been doing some manual tests on these changes. All looks good except for one thing that we may have overlooked. If an application is built with the `

Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-15 Thread via GitHub
breautek commented on PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629#issuecomment-2415372259 Last call for review. iOS test is failing but it has been failing for some time now, including on our [8.1.0 release](https://github.com/apache/cordova-plugin-file/acti

Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-09 Thread via GitHub
lorenzodallavecchia commented on PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629#issuecomment-2401514839 Is there still something preventing the merge, apart from failing tests? This PR is needed to comply with the new media permission guidelines (see apache/cordova-

[PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-07-18 Thread via GitHub
breautek opened a new pull request, #629: URL: https://github.com/apache/cordova-plugin-file/pull/629 ### Platforms affected Android ### Motivation and Context Improves support for the webview asset loader Path handling for easier DOM access, especiall