Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
erisu commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764649223 Can you provide the exact step you used to get that result? I don't get Android Studio's `jbr` with this PR. ``` % echo $JAVA_HOME /Users/cordova/.sdkman/candidate

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
GitToTheHub commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764699304 Hi, thanks for the explanation. I unterstand that this is not in scope of this pr. I only mentioned it because I noticed it. But it sounds like you already have some

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
erisu commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764678803 This PR only focuses on resolving the issue with cordova build. Running cordova build should properly detect JAVA_HOME and update the gradle config. However, this PR does not

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
erisu commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764654678 > I opend it with Android Studio and get the result I described. I didn't build anything in Android Studio, just opened it. If you opened with Android Studio and you did not r

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
GitToTheHub commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764657937 > If you opened with Android Studio and you did not run `cordova build` first, then yes you will get Android Studio's JBR and is expected behavior. So I have to always f

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
GitToTheHub commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764653094 > > ### Build without JAVA_HOME or CORDOVA_JAVA_HOME > > You wrote: > > > When running cordova build, if JAVA_HOME is missing, its expected to not continue as its apart o

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
erisu commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764651287 > ### Build without JAVA_HOME or CORDOVA_JAVA_HOME > > You wrote: > > > When running cordova build, if JAVA_HOME is missing, its expected to not continue as its apart o

Re: [PR] fix: configure gradle java.home [cordova-android]

2025-03-30 Thread via GitHub
GitToTheHub commented on PR #1795: URL: https://github.com/apache/cordova-android/pull/1795#issuecomment-2764651301 Hi, after adding the platform via `cordova platform add github:erisu/cordova-android\#feat/set-gradle-java-home` I opend it with Android Studio and get the

Re: [D] cordova-android 14: Some warnings in Android Studio [cordova]

2025-03-30 Thread via GitHub
GitHub user erisu added a comment to the discussion: cordova-android 14: Some warnings in Android Studio Fixed here; https://github.com/apache/cordova-android/pull/1795 GitHub link: https://github.com/apache/cordova/discussions/530#discussioncomment-12667391 This is an automatically sen

Re: [D] Linking to a plugin will be lost when re-adding a platform [cordova]

2025-03-30 Thread via GitHub
GitHub user GitToTheHub edited a discussion: Linking to a plugin will be lost when re-adding a platform Hi, I noticed during the plugin development that symbolic links to a plugin by `--link` will be lost if I re-add a platform, example: ```bash cordova platform add android cordova plugin ad

Re: [D] android target not installed with a gibberish message [cordova]

2025-03-30 Thread via GitHub
GitHub user RECALLPROLOGUE added a comment to the discussion: android target not installed with a gibberish message wiped everything from path's but system's variables, punched in mine's instead of that pre-defined by installers, now to check if it actually works ![image](https://github.com/us