Re: [PR] fix(ios): Prevent mix build phases [cordova-lib]

2024-10-17 Thread via GitHub
dpogue commented on PR #933: URL: https://github.com/apache/cordova-lib/pull/933#issuecomment-2421216777 You might need to add a mock for something in the tests, they seem to be unhappy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] chore(readme): Update Xcode/node versions in README [cordova-ios]

2024-10-17 Thread via GitHub
dpogue merged PR #1499: URL: https://github.com/apache/cordova-ios/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [I] Can't play mp3 - No such file / Failed to connect to localhost [cordova-plugin-media]

2024-10-17 Thread via GitHub
breautek commented on issue #401: URL: https://github.com/apache/cordova-plugin-media/issues/401#issuecomment-2421176459 > Where are you getting your information about applicationStorageDirectory being read only? My apologies, I got confused between `applicationStorageDirectory` and

Re: [PR] chore(readme): Update Xcode/node versions in README [cordova-ios]

2024-10-17 Thread via GitHub
codecov-commenter commented on PR #1499: URL: https://github.com/apache/cordova-ios/pull/1499#issuecomment-2421164734 ## [Codecov](https://app.codecov.io/gh/apache/cordova-ios/pull/1499?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+c

[PR] chore(readme): Update Xcode/node versions in README [cordova-ios]

2024-10-17 Thread via GitHub
dpogue opened a new pull request, #1499: URL: https://github.com/apache/cordova-ios/pull/1499 ### Platforms affected iOS ### Motivation and Context README listed the incorrect Xcode version and incorrect `xcworkspace` file path for 8.x ### Descript

Re: [PR] docs: Add upgrade guide for plugin authors for 8.x [cordova-ios]

2024-10-17 Thread via GitHub
dpogue merged PR #1498: URL: https://github.com/apache/cordova-ios/pull/1498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.

Re: [PR] Update specs in readme [cordova-plugin-file]

2024-10-17 Thread via GitHub
breautek merged PR #638: URL: https://github.com/apache/cordova-plugin-file/pull/638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [I] Can't play mp3 - No such file / Failed to connect to localhost [cordova-plugin-media]

2024-10-17 Thread via GitHub
nbruley commented on issue #401: URL: https://github.com/apache/cordova-plugin-media/issues/401#issuecomment-2421040708 I must say, much of this doesn't make sense to me either. That's why I'm posting here. One thing I will say is my app was created quite a long time ago, and at tha

Re: [PR] fix(android): Content FS support in PathHandler [cordova-plugin-file]

2024-10-17 Thread via GitHub
breautek merged PR #629: URL: https://github.com/apache/cordova-plugin-file/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] feat(android): check location service before permission [cordova-plugin-geolocation]

2024-10-17 Thread via GitHub
breautek commented on PR #280: URL: https://github.com/apache/cordova-plugin-geolocation/pull/280#issuecomment-2420523808 ![image](https://github.com/user-attachments/assets/abdcab07-6316-450f-94d1-c67425a0b529) I do agree that if the OS level has GPS disabled, then returning a `PER

Re: [I] Please updated the documentation on iOS's local storage is a little unclear. [cordova]

2024-10-17 Thread via GitHub
breautek commented on issue #501: URL: https://github.com/apache/cordova/issues/501#issuecomment-2420333860 I had a look at a plugin that I used to migrate local storage and the paths for the `UIWebView` the local storage was potentially stored in the caches folder, which was something that

Re: [PR] Update specs in readme [cordova-plugin-file]

2024-10-17 Thread via GitHub
GitToTheHub commented on PR #638: URL: https://github.com/apache/cordova-plugin-file/pull/638#issuecomment-2419834723 I changed everything as suggested and squashed the commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Update specs in readme [cordova-plugin-file]

2024-10-17 Thread via GitHub
GitToTheHub commented on code in PR #638: URL: https://github.com/apache/cordova-plugin-file/pull/638#discussion_r1804830919 ## README.md: ## @@ -27,18 +27,18 @@ description: Read/write files on the device. This plugin implements a File API allowing read/write access to file

Re: [PR] Update specs in readme [cordova-plugin-file]

2024-10-17 Thread via GitHub
breautek commented on code in PR #638: URL: https://github.com/apache/cordova-plugin-file/pull/638#discussion_r1804707402 ## README.md: ## @@ -27,18 +27,18 @@ description: Read/write files on the device. This plugin implements a File API allowing read/write access to files r

Re: [I] GradlePluginGoogleServicesEnabled duplicated [cordova-docs]

2024-10-17 Thread via GitHub
breautek commented on issue #1362: URL: https://github.com/apache/cordova-docs/issues/1362#issuecomment-2419410526 ye that second one I think should be `GradlePluginGoogleServicesVersion` but I'd have to go look up the key to confirm. -- This is an automated message from the Apache Git Se

Re: [PR] (iOS) Avoid repetitive permission prompts [cordova-ios]

2024-10-17 Thread via GitHub
erikramalho commented on PR #1245: URL: https://github.com/apache/cordova-ios/pull/1245#issuecomment-2419377214 please merge it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[I] Add Loading Indicator (Progress Bar) in InAppBrowser for Android [cordova-plugin-inappbrowser]

2024-10-17 Thread via GitHub
Akash-Tapadia-DFT opened a new issue, #1076: URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/1076 # Feature Request ## Motivation Behind Feature Currently, there is no visual feedback indicating that content inside the InAppBrowser is loading. Users experience

Re: [I] GradlePluginGoogleServicesEnabled duplicated [cordova-docs]

2024-10-17 Thread via GitHub
zhictory commented on issue #1362: URL: https://github.com/apache/cordova-docs/issues/1362#issuecomment-2418881360 ![image](https://github.com/user-attachments/assets/caa45fde-9bd8-4e67-bf97-a4c72a95aef1) -- This is an automated message from the Apache Git Service. To respond to the m

[I] GradlePluginGoogleServicesEnabled duplicated [cordova-docs]

2024-10-17 Thread via GitHub
zhictory opened a new issue, #1362: URL: https://github.com/apache/cordova-docs/issues/1362 # Bug Report ## Problem ### What is expected to happen? ### What does actually happen? ## Information ### Command or Code