[GitHub] [commons-bcel] codecov-commenter commented on pull request #203: Bump jna.version from 5.12.1 to 5.13.0

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #203: URL: https://github.com/apache/commons-bcel/pull/203#issuecomment-1398814549 # [Codecov](https://codecov.io/gh/apache/commons-bcel/pull/203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [commons-bcel] garydgregory merged pull request #203: Bump jna.version from 5.12.1 to 5.13.0

2023-01-20 Thread via GitHub
garydgregory merged PR #203: URL: https://github.com/apache/commons-bcel/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

[GitHub] [commons-text] codecov-commenter commented on pull request #410: Bump assertj-core from 3.24.1 to 3.24.2

2023-01-20 Thread via GitHub
codecov-commenter commented on PR #410: URL: https://github.com/apache/commons-text/pull/410#issuecomment-1398871149 # [Codecov](https://codecov.io/gh/apache/commons-text/pull/410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [commons-text] garydgregory merged pull request #410: Bump assertj-core from 3.24.1 to 3.24.2

2023-01-20 Thread via GitHub
garydgregory merged PR #410: URL: https://github.com/apache/commons-text/pull/410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

[GitHub] [commons-csv] garydgregory commented on pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-20 Thread via GitHub
garydgregory commented on PR #295: URL: https://github.com/apache/commons-csv/pull/295#issuecomment-1398884753 I will find time to review over the weekend. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-functor] sebbASF merged pull request #35: Bump maven-checkstyle-plugin from 3.2.0 to 3.2.1

2023-01-21 Thread via GitHub
sebbASF merged PR #35: URL: https://github.com/apache/commons-functor/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons

[GitHub] [commons-imaging] kpouer commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-21 Thread via GitHub
kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399251826 Hey, I was able to do the same test without changing public api so I reverted the change (even if I think those functions might be useful, it could be done in another PR if necessary

[GitHub] [commons-imaging] kinow commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-21 Thread via GitHub
kinow commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399282188 Thanks @kpouer can you squash your commits? And would you be able to create a JIRA for this? Even though it's a change in the tests I'd like to review (will try to compare number of I

[GitHub] [commons-csv] kinow commented on a diff in pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-21 Thread via GitHub
kinow commented on code in PR #295: URL: https://github.com/apache/commons-csv/pull/295#discussion_r1083307259 ## src/main/java/org/apache/commons/csv/CSVFormat.java: ## @@ -846,6 +881,8 @@ public CSVFormat getFormat() { public static final CSVFormat EXCEL = DEFAULT.builder

[GitHub] [commons-csv] garydgregory merged pull request #295: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-21 Thread via GitHub
garydgregory merged PR #295: URL: https://github.com/apache/commons-csv/pull/295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

[GitHub] [commons-csv] garydgregory commented on pull request #295: [CSV-141] Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-21 Thread via GitHub
garydgregory commented on PR #295: URL: https://github.com/apache/commons-csv/pull/295#issuecomment-1399319422 I applied and then reverted this PR because it does not work. Notice the comment I made 2 weeks ago "A test is missing that an actual CSV file can be parsed and not parsed." This w

[GitHub] [commons-email] reda-alaoui commented on pull request #80: [EMAIL-203] Jakarta 2

2023-01-21 Thread via GitHub
reda-alaoui commented on PR #80: URL: https://github.com/apache/commons-email/pull/80#issuecomment-1399333534 > -1 as it stands because this kind of work can only be done in the context of a major version change which means: > > * The package name changes from `org.apache.commons.mail

[GitHub] [commons-imaging] kpouer opened a new pull request, #272: perform tests in memory instead of disk making them faster

2023-01-21 Thread via GitHub
kpouer opened a new pull request, #272: URL: https://github.com/apache/commons-imaging/pull/272 Same pull request as https://github.com/apache/commons-imaging/pull/271 but with squashed commits -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [commons-imaging] codecov-commenter commented on pull request #272: perform tests in memory instead of disk making them faster

2023-01-21 Thread via GitHub
codecov-commenter commented on PR #272: URL: https://github.com/apache/commons-imaging/pull/272#issuecomment-1399335624 # [Codecov](https://codecov.io/gh/apache/commons-imaging/pull/272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [commons-imaging] kpouer commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-21 Thread via GitHub
kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399335740 Hey, I was not sure how I could squash commits without deleting my branch and pushing it again so I created a new branch and a new pull request (same code but squashed into one commi

[GitHub] [commons-email] reda-alaoui opened a new pull request, #133: Migrate to jakarta package namespace ( and commons-email2 )

2023-01-21 Thread via GitHub
reda-alaoui opened a new pull request, #133: URL: https://github.com/apache/commons-email/pull/133 This PR fully migrates the project to jakarta package namespace . It also introduces `commons-email2` as asked by https://github.com/apache/commons-email/pull/80#issuecomment-1151018762 --

[GitHub] [commons-email] codecov-commenter commented on pull request #133: Migrate to jakarta package namespace ( and commons-email2 )

2023-01-21 Thread via GitHub
codecov-commenter commented on PR #133: URL: https://github.com/apache/commons-email/pull/133#issuecomment-1399338518 # [Codecov](https://codecov.io/gh/apache/commons-email/pull/133?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [commons-imaging] kpouer opened a new pull request, #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-21 Thread via GitHub
kpouer opened a new pull request, #273: URL: https://github.com/apache/commons-imaging/pull/273 PCX & DCX have 256 color palette, so they cannot perform full color round trip on image of 300x300. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [commons-imaging] codecov-commenter commented on pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-21 Thread via GitHub
codecov-commenter commented on PR #273: URL: https://github.com/apache/commons-imaging/pull/273#issuecomment-1399343938 # [Codecov](https://codecov.io/gh/apache/commons-imaging/pull/273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [commons-email] reda-alaoui commented on pull request #37: upgrade jakarta.mail to 2.0.0 (rename javax.mail -> jakarta.mail)

2023-01-21 Thread via GitHub
reda-alaoui commented on PR #37: URL: https://github.com/apache/commons-email/pull/37#issuecomment-1399348422 To anybody interested, I created #133 as a replacement for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-imaging] kinow commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-22 Thread via GitHub
kinow commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399431498 Hi @kpouer > Hey, I was not sure how I could squash commits without deleting my branch and pushing it again so I created a new branch and a new pull request (same code but squ

[GitHub] [commons-imaging] kinow commented on pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-22 Thread via GitHub
kinow commented on PR #273: URL: https://github.com/apache/commons-imaging/pull/273#issuecomment-1399442351 >But that's a separate issue (I will create one in JIRA for this). https://issues.apache.org/jira/browse/IMAGING-344 -- This is an automated message from the Apache Git Servic

[GitHub] [commons-imaging] kpouer closed pull request #272: perform tests in memory instead of disk making them faster

2023-01-22 Thread via GitHub
kpouer closed pull request #272: perform tests in memory instead of disk making them faster URL: https://github.com/apache/commons-imaging/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [commons-imaging] kinow commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-22 Thread via GitHub
kinow commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399450488 > kpouer force-pushed the unit_test_tmp_file_optimization branch from eddd5bf to 1947c86 :clap: great job! Much easier to review, and thanks for closing the other PR. Bravo @

[GitHub] [commons-imaging] kpouer commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-22 Thread via GitHub
kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1399457847 Yes I was able to squash but was missing the "force" option for the push -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [commons-imaging] kpouer commented on pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-22 Thread via GitHub
kpouer commented on PR #273: URL: https://github.com/apache/commons-imaging/pull/273#issuecomment-1399492773 I think you are right @kinow in fact I supposed the PCX code was good and was not aware that 24 bit PCX existed. So I close the PR, sorry for the disturbance -- This is an automat

[GitHub] [commons-imaging] kpouer closed pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-22 Thread via GitHub
kpouer closed pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX URL: https://github.com/apache/commons-imaging/pull/273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [commons-imaging] kinow commented on pull request #273: Unit test : Fix FullColorRoundtrip test for PCX & DCX

2023-01-22 Thread via GitHub
kinow commented on PR #273: URL: https://github.com/apache/commons-imaging/pull/273#issuecomment-1399498587 >So I close the PR, sorry for the disturbance Thank you, and not a problem at all. In the end we found a bug in the `PcxWriter` thanks to you for looking at that code :+1: keep

[GitHub] [commons-configuration] garydgregory commented on pull request #261: Bump slf4j.version from 2.0.5 to 2.0.6

2023-01-22 Thread via GitHub
garydgregory commented on PR #261: URL: https://github.com/apache/commons-configuration/pull/261#issuecomment-1399528048 Free up a slot for check -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [commons-configuration] garydgregory closed pull request #261: Bump slf4j.version from 2.0.5 to 2.0.6

2023-01-22 Thread via GitHub
garydgregory closed pull request #261: Bump slf4j.version from 2.0.5 to 2.0.6 URL: https://github.com/apache/commons-configuration/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [commons-lang] codecov-commenter commented on pull request #1022: Use Objects.requireNonNull() directly.

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #1022: URL: https://github.com/apache/commons-lang/pull/1022#issuecomment-1399598146 # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [commons-lang] codecov-commenter commented on pull request #1023: Use qualifiers removing unnecessary object allocation.

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #1023: URL: https://github.com/apache/commons-lang/pull/1023#issuecomment-1399600396 # [Codecov](https://codecov.io/gh/apache/commons-lang/pull/1023?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [commons-csv] DamjanJovanovic opened a new pull request, #303: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility. Fix a uni

2023-01-22 Thread via GitHub
DamjanJovanovic opened a new pull request, #303: URL: https://github.com/apache/commons-csv/pull/303 Continued from PR 295. The test was failing because the test was wrong, not because my patches were wrong. The test should match Excel's interpretation of the CSV file. Excel fu

[GitHub] [commons-csv] codecov-commenter commented on pull request #303: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility. Fix a un

2023-01-22 Thread via GitHub
codecov-commenter commented on PR #303: URL: https://github.com/apache/commons-csv/pull/303#issuecomment-1399689107 # [Codecov](https://codecov.io/gh/apache/commons-csv/pull/303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apach

[GitHub] [commons-csv] DamjanJovanovic commented on pull request #295: [CSV-141] Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility

2023-01-22 Thread via GitHub
DamjanJovanovic commented on PR #295: URL: https://github.com/apache/commons-csv/pull/295#issuecomment-1399690869 > I applied and then reverted this PR because it does not work. Notice the comment I made 2 weeks ago "A test is missing that an actual CSV file can be parsed and not parsed." T

[GitHub] [commons-jelly] garydgregory commented on a diff in pull request #19: Fixed bad URLs

2023-01-23 Thread via GitHub
garydgregory commented on code in PR #19: URL: https://github.com/apache/commons-jelly/pull/19#discussion_r1083924782 ## xdocs/jellyunit.xml: ## @@ -54,14 +54,14 @@ An example demonstrating the use of the Betwixt library is -http://svn.apache.or

[GitHub] [commons-csv] garydgregory commented on pull request #303: Add support for trailing text after the closing quote, and EOF without a final closing quote, for Excel compatibility. Fix a unit te

2023-01-23 Thread via GitHub
garydgregory commented on PR #303: URL: https://github.com/apache/commons-csv/pull/303#issuecomment-1400187927 "The test was failing because the test was wrong" This is why I kept asking (twice) for file-based tests... please add file-based tests that cover use cases for these two new

[GitHub] [commons-jelly] asfgit closed pull request #19: Fixed bad URLs

2023-01-23 Thread via GitHub
asfgit closed pull request #19: Fixed bad URLs URL: https://github.com/apache/commons-jelly/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [commons-jelly] sebbASF commented on pull request #20: Fixed bad URL

2023-01-23 Thread via GitHub
sebbASF commented on PR #20: URL: https://github.com/apache/commons-jelly/pull/20#issuecomment-1400512404 Fixed in 359de7bd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-jelly] sebbASF closed pull request #20: Fixed bad URL

2023-01-23 Thread via GitHub
sebbASF closed pull request #20: Fixed bad URL URL: https://github.com/apache/commons-jelly/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [commons-imaging] kpouer commented on pull request #271: Unit test : make tests in memory instead of writing hundred of tmp files

2023-01-23 Thread via GitHub
kpouer commented on PR #271: URL: https://github.com/apache/commons-imaging/pull/271#issuecomment-1400903230 Hi, I just created a JIRA ticket for this patch and updated the commit description https://issues.apache.org/jira/browse/IMAGING-345 -- This is an automated message from the Ap

[GitHub] [commons-lang] mjiderhamn commented on pull request #398: Add ComparableUtils

2023-01-26 Thread via GitHub
mjiderhamn commented on PR #398: URL: https://github.com/apache/commons-lang/pull/398#issuecomment-1404703298 I was surprised to stumble upon my old [mjiderhamn/compare-to](https://github.com/mjiderhamn/compare-to), [announced back in 2013](https://java.jiderhamn.se/2013/10/15/better-compar

[GitHub] [commons-lang] Sam-Kruglov commented on pull request #398: Add ComparableUtils

2023-01-26 Thread via GitHub
Sam-Kruglov commented on PR #398: URL: https://github.com/apache/commons-lang/pull/398#issuecomment-1405067304 @mjiderhamn I came up with it on my own, haven’t seen yours. But my utility here differs from whats currently in main, someone changed it without PR I think, you can follow commits

[GitHub] [commons-validator] rossmills3 opened a new pull request, #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 opened a new pull request, #116: URL: https://github.com/apache/commons-validator/pull/116 based on specs found here : https://bank.codes/iban/structure/mayotte/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [commons-validator] garydgregory commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
garydgregory commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1405569109 -1: I do not think we wan to add non-registered codes, see https://www.swift.com/standards/data-standards/iban -- This is an automated message from the Apache Git Service.

[GitHub] [commons-validator] rossmills3 commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1405721749 @garydgregory - YT is a french territory listed as "Country code includes other countries/territories" under "2.26 FR – France". I created this PR because one of the clients

[GitHub] [commons-validator] garydgregory commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
garydgregory commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1405731289 > @garydgregory - YT is a french territory listed as "Country code includes other countries/territories" under "2.26 FR – France". I created this PR because one of the clien

[GitHub] [commons-validator] sebbASF commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
sebbASF commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1405817906 If we were to add YT, there are several other "included" codes, e.g. IM, JY, GG for GB, which should also be included. Note that users can add their own overrides if a coun

[GitHub] [commons-validator] rossmills3 commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1405818640 While I was at it, I went ahead and added all the french territories using example account numbers found at https://bank.codes/iban/structure/ -- This is an automated messa

[GitHub] [commons-validator] sebbASF commented on a diff in pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
sebbASF commented on code in PR #116: URL: https://github.com/apache/commons-validator/pull/116#discussion_r1088446205 ## src/main/java/org/apache/commons/validator/routines/IBANValidator.java: ## @@ -141,6 +141,7 @@ public RegexValidator getRegexValidator() { new V

[GitHub] [commons-validator] rossmills3 commented on a diff in pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 commented on code in PR #116: URL: https://github.com/apache/commons-validator/pull/116#discussion_r1088475704 ## src/main/java/org/apache/commons/validator/routines/IBANValidator.java: ## @@ -141,6 +141,7 @@ public RegexValidator getRegexValidator() { ne

[GitHub] [commons-validator] rossmills3 commented on a diff in pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 commented on code in PR #116: URL: https://github.com/apache/commons-validator/pull/116#discussion_r1088482238 ## src/main/java/org/apache/commons/validator/routines/IBANValidator.java: ## @@ -206,13 +215,16 @@ public RegexValidator getRegexValidator() {

[GitHub] [commons-validator] rossmills3 commented on a diff in pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 commented on code in PR #116: URL: https://github.com/apache/commons-validator/pull/116#discussion_r1088482238 ## src/main/java/org/apache/commons/validator/routines/IBANValidator.java: ## @@ -206,13 +215,16 @@ public RegexValidator getRegexValidator() {

[GitHub] [commons-validator] rossmills3 closed pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-26 Thread via GitHub
rossmills3 closed pull request #116: Adding validation support for Mayotte (YT) IBANs URL: https://github.com/apache/commons-validator/pull/116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [commons-build-plugin] garydgregory merged pull request #128: Bump github/codeql-action from 2.1.39 to 2.2.0

2023-01-27 Thread via GitHub
garydgregory merged PR #128: URL: https://github.com/apache/commons-build-plugin/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [commons-parent] garydgregory merged pull request #209: Bump github/codeql-action from 2.1.39 to 2.2.1

2023-01-27 Thread via GitHub
garydgregory merged PR #209: URL: https://github.com/apache/commons-parent/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

[GitHub] [commons-skin] garydgregory merged pull request #38: Bump github/codeql-action from 2.1.39 to 2.2.1

2023-01-27 Thread via GitHub
garydgregory merged PR #38: URL: https://github.com/apache/commons-skin/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

[GitHub] [commons-validator] sebbASF commented on a diff in pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-27 Thread via GitHub
sebbASF commented on code in PR #116: URL: https://github.com/apache/commons-validator/pull/116#discussion_r1089218243 ## src/main/java/org/apache/commons/validator/routines/IBANValidator.java: ## @@ -206,13 +215,16 @@ public RegexValidator getRegexValidator() { new

[GitHub] [commons-geometry] agoss94 opened a new pull request, #207: Geometry 110

2023-01-29 Thread via GitHub
agoss94 opened a new pull request, #207: URL: https://github.com/apache/commons-geometry/pull/207 GEOMETRY-110 Quickhull implementation in three dimensions. The implementation is based on the paper by Barber, Dobkin and Huhdanpaa. Since all points are in effect joggled with an error

[GitHub] [commons-validator] garydgregory commented on pull request #116: Adding validation support for Mayotte (YT) IBANs

2023-01-29 Thread via GitHub
garydgregory commented on PR #116: URL: https://github.com/apache/commons-validator/pull/116#issuecomment-1407761210 @rossmills3 Please see git master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [commons-dbutils] thecarlhall commented on pull request #176: Bump mockito-core from 4.11.0 to 5.0.0

2023-01-29 Thread via GitHub
thecarlhall commented on PR #176: URL: https://github.com/apache/commons-dbutils/pull/176#issuecomment-1407783713 @dependabot ignore this dependency >[Mockito 5](https://github.com/mockito/mockito/releases/tag/v5.0.0) switches the default mockmaker to mockito-inline, and now requires

[GitHub] [commons-vfs] destroydestiny commented on pull request #300: VFS-824 HttpFileSystem free Unused Resources lead to HttpClient Conn…

2023-01-29 Thread via GitHub
destroydestiny commented on PR #300: URL: https://github.com/apache/commons-vfs/pull/300#issuecomment-1407968556 > I need to look at this more closely over the weekend: I don't know why the HTTP providers have to be unique and different compared to all the others. Is the use of concepts in

[GitHub] [commons-io] Schmidor commented on pull request #377: IO-769: FileUtils copyDirectory() should not use COPY_ATTRIBUTES

2023-01-30 Thread via GitHub
Schmidor commented on PR #377: URL: https://github.com/apache/commons-io/pull/377#issuecomment-1408889665 `FileUtils.moveFile(File srcFile, File destFile) ` was also changed and got COPY_ATTRIBUTES in 2.9 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [commons-configuration] asomov opened a new pull request, #269: Migrate to SnakeYAML Engine

2023-01-30 Thread via GitHub
asomov opened a new pull request, #269: URL: https://github.com/apache/commons-configuration/pull/269 Migrate to SnakeYAML Engine - to support YAML 1.2 - to get rid of false positives for potential vulnerabilities in SnakeYAML -- This is an automated message from the Apache Git

[GitHub] [commons-configuration] asomov closed pull request #269: Migrate to SnakeYAML Engine

2023-01-30 Thread via GitHub
asomov closed pull request #269: Migrate to SnakeYAML Engine URL: https://github.com/apache/commons-configuration/pull/269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [commons-configuration] asomov commented on pull request #269: Migrate to SnakeYAML Engine

2023-01-30 Thread via GitHub
asomov commented on PR #269: URL: https://github.com/apache/commons-configuration/pull/269#issuecomment-1409905196 minor fix will come -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [commons-configuration] asomov opened a new pull request, #270: Migrate to SnakeYAML Engine

2023-01-30 Thread via GitHub
asomov opened a new pull request, #270: URL: https://github.com/apache/commons-configuration/pull/270 Migrate to SnakeYAML Engine: - to support YAML 1.2 - to get rid of false positives for potential vulnerabilities in SnakeYAML -- This is an automated message from the Apache Git

[GitHub] [commons-configuration] asomov commented on pull request #270: Migrate to SnakeYAML Engine

2023-01-30 Thread via GitHub
asomov commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1409912191 I applied this, because I could not build it otherwise (it was `false`): `true` -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [commons-configuration] codecov-commenter commented on pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
codecov-commenter commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1410065092 # [Codecov](https://codecov.io/gh/apache/commons-configuration/pull/270?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
garydgregory commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1091769147 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional,

[GitHub] [commons-configuration] asomov commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
asomov commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1091845360 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional, com.fa

[GitHub] [commons-configuration] asomov commented on pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
asomov commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1410251151 @kinow I did my best to create a JIRA, but unfortunately there is no way to create an account there. I am stuck -- This is an automated message from the Apache Git Service.

[GitHub] [commons-configuration] asomov commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
asomov commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1091847445 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional, com.fa

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
garydgregory commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1092049982 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional,

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
garydgregory commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1092049982 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional,

[GitHub] [commons-configuration] asomov commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
asomov commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1092282495 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional, com.fa

[GitHub] [commons-io] tbw777 opened a new pull request, #427: Simplified res closing and prevented creating/closing process OutputS…

2023-01-31 Thread via GitHub
tbw777 opened a new pull request, #427: URL: https://github.com/apache/commons-io/pull/427 …tream and ErrorStream. There is no needed to make local variables as null and opening unused streams to close them later. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [commons-configuration] garydgregory commented on pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1411212430 You don't indicate anything, and you don't turn off JApiCmd as JApiCmd will fail the build if the PR breaks BC. -- This is an automated message from the Apache Git Ser

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
garydgregory commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1092592063 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional,

[GitHub] [commons-bsf] spyhunter99 opened a new pull request, #79: BSF-47 mvn site fixes

2023-01-31 Thread via GitHub
spyhunter99 opened a new pull request, #79: URL: https://github.com/apache/commons-bsf/pull/79 fixes site generation with jdk8 and the doclinter and fixes a number of dead links -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [commons-configuration] asomov commented on a diff in pull request #270: Migrate to SnakeYAML Engine

2023-01-31 Thread via GitHub
asomov commented on code in PR #270: URL: https://github.com/apache/commons-configuration/pull/270#discussion_r1092784354 ## pom.xml: ## @@ -551,15 +551,15 @@ org.apache.commons.vfs2.*;resolution:=optional, org.springframework.*;resolution:=optional, com.fa

[GitHub] [commons-jcs] tbw777 opened a new pull request, #134: Added missing @Deprecated annotations

2023-01-31 Thread via GitHub
tbw777 opened a new pull request, #134: URL: https://github.com/apache/commons-jcs/pull/134 These annotations helpfully to prevent usage of deprecated API. For example: developer can see crossed out method/field name if this item is deprecated. -- This is an automated message from the Apa

[GitHub] [commons-fileupload] Radar27149 commented on pull request #185: Add a new limit for the number of files uploaded per request

2023-01-31 Thread via GitHub
Radar27149 commented on PR #185: URL: https://github.com/apache/commons-fileupload/pull/185#issuecomment-1411556730 > > > > What question exactly? ![image](https://user-images.githubusercontent.com/102725494/215973188-9437936d-9b9a-40b0-81bd-7cdcae922915.png) commo

[GitHub] [commons-jcs] tbw777 opened a new pull request, #135: Removed double null check with instance operator

2023-02-01 Thread via GitHub
tbw777 opened a new pull request, #135: URL: https://github.com/apache/commons-jcs/pull/135 Sometimes found usage of instance operator with variable superflous check for null. But also there is not only variables. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [commons-jcs] tbw777 opened a new pull request, #136: Replaced replaceAll() calls to replace()

2023-02-01 Thread via GitHub
tbw777 opened a new pull request, #136: URL: https://github.com/apache/commons-jcs/pull/136 replace() method is more fast then replaceAll() for non regex cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [commons-configuration] garydgregory commented on pull request #270: Migrate to SnakeYAML Engine

2023-02-01 Thread via GitHub
garydgregory commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1411971570 Since this PR breaks BC according to your earlier comment, it is -1. This PR hides this fact by disabling BC checking. BC can only be broken in a major release. There ar

[GitHub] [commons-configuration] asomov commented on pull request #270: Migrate to SnakeYAML Engine

2023-02-01 Thread via GitHub
asomov commented on PR #270: URL: https://github.com/apache/commons-configuration/pull/270#issuecomment-1412038286 @garydgregory I think the simplest for me is keep this PR until a major version comes. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [commons-net] sebbASF commented on a diff in pull request #125: Net 717 encapsulate complete pending command

2023-02-01 Thread via GitHub
sebbASF commented on code in PR #125: URL: https://github.com/apache/commons-net/pull/125#discussion_r1093318537 ## src/main/java/org/apache/commons/net/ftp/FTPInputStream.java: ## @@ -0,0 +1,20 @@ +package org.apache.commons.net.ftp; Review Comment: Needs AL header #

[GitHub] [commons-io] garydgregory commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

2023-02-01 Thread via GitHub
garydgregory commented on PR #427: URL: https://github.com/apache/commons-io/pull/427#issuecomment-1412210060 My only concern here is that the method will now fail if _anything_ goes wrong closing streams. This is a change in behavior that we do not test apparently. This could be considered

[GitHub] [commons-io] tbw777 commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

2023-02-01 Thread via GitHub
tbw777 commented on PR #427: URL: https://github.com/apache/commons-io/pull/427#issuecomment-1412484450 @garydgregory The exception will also be thrown to the top because there is no corresponding catch as in the original version. Or do you mean something else? -- This is an automated

[GitHub] [commons-io] jvz closed pull request #72: [IO-596] Add DeleteFiles utility class

2023-02-01 Thread via GitHub
jvz closed pull request #72: [IO-596] Add DeleteFiles utility class URL: https://github.com/apache/commons-io/pull/72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [commons-configuration] garydgregory commented on pull request #272: Remove unused declarations.

2023-02-01 Thread via GitHub
garydgregory commented on PR #272: URL: https://github.com/apache/commons-configuration/pull/272#issuecomment-1412976729 -1: Look at the whole method and comments. If anything, the lines you deleted should be either commented out or left alone. -- This is an automated message from the Ap

[GitHub] [commons-io] garydgregory commented on pull request #427: Simplified res closing and prevented creating/closing process OutputS…

2023-02-01 Thread via GitHub
garydgregory commented on PR #427: URL: https://github.com/apache/commons-io/pull/427#issuecomment-1413025670 Hm, two behavior might be the same indeed. I'll look again in the AM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [commons-vfs] wangerry opened a new pull request, #370: VFS-832: Sftp channel not put back in doGetInputUpstream

2023-02-02 Thread via GitHub
wangerry opened a new pull request, #370: URL: https://github.com/apache/commons-vfs/pull/370 https://issues.apache.org/jira/browse/VFS-832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [commons-vfs] garydgregory commented on pull request #370: VFS-832: Sftp channel not put back in doGetInputUpstream

2023-02-02 Thread via GitHub
garydgregory commented on PR #370: URL: https://github.com/apache/commons-vfs/pull/370#issuecomment-1413584607 @wangerry Thank you for the PR. Would you add a unit test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [commons-vfs] wangerry commented on pull request #370: VFS-832: Sftp channel not put back in doGetInputUpstream

2023-02-02 Thread via GitHub
wangerry commented on PR #370: URL: https://github.com/apache/commons-vfs/pull/370#issuecomment-1413738864 ok, working on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-configuration] arturobernalg closed pull request #272: Remove unused declarations.

2023-02-02 Thread via GitHub
arturobernalg closed pull request #272: Remove unused declarations. URL: https://github.com/apache/commons-configuration/pull/272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [commons-configuration] arturobernalg commented on pull request #272: Remove unused declarations.

2023-02-02 Thread via GitHub
arturobernalg commented on PR #272: URL: https://github.com/apache/commons-configuration/pull/272#issuecomment-1413906695 agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [commons-io] codecov-commenter commented on pull request #429: Bump actions/cache from 3.2.3 to 3.2.4

2023-02-02 Thread via GitHub
codecov-commenter commented on PR #429: URL: https://github.com/apache/commons-io/pull/429#issuecomment-1414532679 # [Codecov](https://codecov.io/gh/apache/commons-io/pull/429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [commons-io] codecov-commenter commented on pull request #431: Bump maven-enforcer-plugin from 3.1.0 to 3.2.1

2023-02-02 Thread via GitHub
codecov-commenter commented on PR #431: URL: https://github.com/apache/commons-io/pull/431#issuecomment-1414534092 # [Codecov](https://codecov.io/gh/apache/commons-io/pull/431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

  1   2   3   4   5   6   7   8   9   10   >