[GitHub] [commons-io] garydgregory commented on pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-13 Thread GitBox
garydgregory commented on pull request #215: URL: https://github.com/apache/commons-io/pull/215#issuecomment-918373577 @shollander May you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [commons-io] garydgregory edited a comment on pull request #9: Added a true iterator for traversing the file trees

2021-09-13 Thread GitBox
garydgregory edited a comment on pull request #9: URL: https://github.com/apache/commons-io/pull/9#issuecomment-685827587 `FileTreeWalker` is package private, `java.nio.file.Files.walk*` is what matters here IMO. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [commons-io] garydgregory closed pull request #27: [IO-510] Adding ReadAHeadInputStream

2021-09-13 Thread GitBox
garydgregory closed pull request #27: URL: https://github.com/apache/commons-io/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [commons-io] garydgregory commented on pull request #27: [IO-510] Adding ReadAHeadInputStream

2021-09-13 Thread GitBox
garydgregory commented on pull request #27: URL: https://github.com/apache/commons-io/pull/27#issuecomment-918376398 Closing since `ReadAheadInputStream` is in Commons IO as of 2.9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [commons-collections] coveralls commented on pull request #252: Bump commons.junit.version from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
coveralls commented on pull request #252: URL: https://github.com/apache/commons-collections/pull/252#issuecomment-918386498 [![Coverage Status](https://coveralls.io/builds/42834044/badge)](https://coveralls.io/builds/42834044) Coverage remained the same at 90.143% when pulling

[GitHub] [commons-collections] coveralls commented on pull request #253: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-13 Thread GitBox
coveralls commented on pull request #253: URL: https://github.com/apache/commons-collections/pull/253#issuecomment-918388548 [![Coverage Status](https://coveralls.io/builds/42834122/badge)](https://coveralls.io/builds/42834122) Coverage decreased (-0.03%) to 90.114% when pulling

[GitHub] [commons-fileupload] dependabot[bot] opened a new pull request #113: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #113: URL: https://github.com/apache/commons-fileupload/pull/113 Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.7.2 to 5.8.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>junit-jupiter's r

[GitHub] [commons-io] garydgregory commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-13 Thread GitBox
garydgregory commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-918461002 Why does this patch not follow the recommeded pattern from https://maven.apache.org/plugins/maven-compiler-plugin/examples/module-info.html ? -- This is an automated me

[GitHub] [commons-bcel] dependabot[bot] opened a new pull request #104: Bump junit-jupiter from 5.8.0-RC1 to 5.8.0

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #104: URL: https://github.com/apache/commons-bcel/pull/104 Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.8.0-RC1 to 5.8.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>junit-jupiter's rel

[GitHub] [commons-ognl] dependabot[bot] opened a new pull request #50: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #50: URL: https://github.com/apache/commons-ognl/pull/50 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.14.0 to 3.15.0. Commits https://github.com/apache/maven-pmd-plugin/commit/7a738884d38c3f7baee4d493940b

[GitHub] [commons-rdf] dependabot[bot] commented on pull request #57: Bump maven-pmd-plugin from 3.12.0 to 3.14.0

2021-09-13 Thread GitBox
dependabot[bot] commented on pull request #57: URL: https://github.com/apache/commons-rdf/pull/57#issuecomment-918524387 Superseded by #69. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [commons-rdf] dependabot[bot] closed pull request #57: Bump maven-pmd-plugin from 3.12.0 to 3.14.0

2021-09-13 Thread GitBox
dependabot[bot] closed pull request #57: URL: https://github.com/apache/commons-rdf/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-rdf] dependabot[bot] opened a new pull request #69: Bump maven-pmd-plugin from 3.12.0 to 3.15.0

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #69: URL: https://github.com/apache/commons-rdf/pull/69 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.12.0 to 3.15.0. Commits https://github.com/apache/maven-pmd-plugin/commit/7a738884d38c3f7baee4d493940bd

[GitHub] [commons-text] dependabot[bot] opened a new pull request #264: Bump spotbugs from 4.4.0 to 4.4.1

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #264: URL: https://github.com/apache/commons-text/pull/264 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.0 to 4.4.1. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases";>spotbugs's releases. S

[GitHub] [commons-email] dependabot[bot] closed pull request #54: Bump spotbugs from 4.2.2 to 4.4.0

2021-09-13 Thread GitBox
dependabot[bot] closed pull request #54: URL: https://github.com/apache/commons-email/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issu

[GitHub] [commons-email] dependabot[bot] commented on pull request #54: Bump spotbugs from 4.2.2 to 4.4.0

2021-09-13 Thread GitBox
dependabot[bot] commented on pull request #54: URL: https://github.com/apache/commons-email/pull/54#issuecomment-918530286 Superseded by #55. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [commons-email] dependabot[bot] opened a new pull request #55: Bump spotbugs from 4.2.2 to 4.4.1

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #55: URL: https://github.com/apache/commons-email/pull/55 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.2 to 4.4.1. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases";>spotbugs's releases. Sp

[GitHub] [commons-text] dependabot[bot] opened a new pull request #266: Bump commons-rng-simple from 1.3 to 1.4

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #266: URL: https://github.com/apache/commons-text/pull/266 Bumps commons-rng-simple from 1.3 to 1.4. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commons:

[GitHub] [commons-fileupload] coveralls commented on pull request #113: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
coveralls commented on pull request #113: URL: https://github.com/apache/commons-fileupload/pull/113#issuecomment-918553935 [![Coverage Status](https://coveralls.io/builds/42839790/badge)](https://coveralls.io/builds/42839790) Coverage remained the same at 77.566% when pulling

[GitHub] [commons-text] kinow merged pull request #266: Bump commons-rng-simple from 1.3 to 1.4

2021-09-13 Thread GitBox
kinow merged pull request #266: URL: https://github.com/apache/commons-text/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [commons-text] kinow commented on pull request #264: Bump spotbugs from 4.4.0 to 4.4.1

2021-09-13 Thread GitBox
kinow commented on pull request #264: URL: https://github.com/apache/commons-text/pull/264#issuecomment-918557465 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-io] shollander commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-13 Thread GitBox
shollander commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r707665058 ## File path: src/test/java/org/apache/commons/io/input/MemoryMappedFileInputStreamTest.java ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apache Soft

[GitHub] [commons-io] shollander commented on pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-13 Thread GitBox
shollander commented on pull request #215: URL: https://github.com/apache/commons-io/pull/215#issuecomment-918558686 > > > @shollander > May you please rebase on master? Done. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [commons-text] kinow merged pull request #264: Bump spotbugs from 4.4.0 to 4.4.1

2021-09-13 Thread GitBox
kinow merged pull request #264: URL: https://github.com/apache/commons-text/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
gwlucastrig commented on a change in pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#discussion_r707768881 ## File path: src/main/java/org/apache/commons/imaging/common/RationalNumber.java ## @@ -20,6 +20,14 @@ /** * Rational number, as used by t

[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
gwlucastrig commented on a change in pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#discussion_r707773546 ## File path: src/main/java/org/apache/commons/imaging/common/RationalNumber.java ## @@ -73,8 +124,41 @@ private static long gcd(final long a, f

[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
gwlucastrig commented on a change in pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#discussion_r707773701 ## File path: src/main/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeRational.java ## @@ -31,11 +31,19 @@ public FieldTypeRa

[GitHub] [commons-text] coveralls commented on pull request #265: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
coveralls commented on pull request #265: URL: https://github.com/apache/commons-text/pull/265#issuecomment-918647332 [![Coverage Status](https://coveralls.io/builds/42843340/badge)](https://coveralls.io/builds/42843340) Coverage remained the same at 97.865% when pulling **7107c

[GitHub] [commons-imaging] gwlucastrig commented on pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
gwlucastrig commented on pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#issuecomment-918655691 Well, predictably, somethings gone wrong with my branch and pull request... I made the changes, did the squash, and then a push... But they did not seem to make it

[GitHub] [commons-imaging] gwlucastrig edited a comment on pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
gwlucastrig edited a comment on pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#issuecomment-918655691 Well, predictably, somethings gone wrong with my branch and pull request... I made the changes, did the squash, and then a push... But they did not seem to m

[GitHub] [commons-imaging] kinow commented on pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
kinow commented on pull request #164: URL: https://github.com/apache/commons-imaging/pull/164#issuecomment-918663016 @gwlucastrig I think we both learned that GitHub must keep some sort of internal unique ID per fork. Your previous fork has disappeared, hence the new PR. Let's create a new

[GitHub] [commons-text] coveralls edited a comment on pull request #265: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
coveralls edited a comment on pull request #265: URL: https://github.com/apache/commons-text/pull/265#issuecomment-918647332 [![Coverage Status](https://coveralls.io/builds/42844492/badge)](https://coveralls.io/builds/42844492) Coverage remained the same at 97.865% when pulling

[GitHub] [commons-imaging] gwlucastrig opened a new pull request #169: IMAGING-285 Correction for rational number computations

2021-09-13 Thread GitBox
gwlucastrig opened a new pull request #169: URL: https://github.com/apache/commons-imaging/pull/169 This pull request addresses JIRA issue IMAGING-285. It provides corrections to the RationalNumber and its associated classes in the TIFF format branch. It also updates the supporting unit t

[GitHub] [commons-imaging] coveralls commented on pull request #169: IMAGING-285 Correction for rational number computations

2021-09-13 Thread GitBox
coveralls commented on pull request #169: URL: https://github.com/apache/commons-imaging/pull/169#issuecomment-918685573 [![Coverage Status](https://coveralls.io/builds/42844677/badge)](https://coveralls.io/builds/42844677) Coverage increased (+0.2%) to 77.003% when pulling **17

[GitHub] [commons-text] kinow merged pull request #265: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
kinow merged pull request #265: URL: https://github.com/apache/commons-text/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [commons-imaging] kinow closed pull request #164: IMAGING-285 RationalNumber to support unsigned int format

2021-09-13 Thread GitBox
kinow closed pull request #164: URL: https://github.com/apache/commons-imaging/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [commons-imaging] kinow commented on pull request #169: IMAGING-285 Correction for rational number computations

2021-09-13 Thread GitBox
kinow commented on pull request #169: URL: https://github.com/apache/commons-imaging/pull/169#issuecomment-918696481 Supersedes #164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [commons-imaging] coveralls edited a comment on pull request #169: IMAGING-285 Correction for rational number computations

2021-09-13 Thread GitBox
coveralls edited a comment on pull request #169: URL: https://github.com/apache/commons-imaging/pull/169#issuecomment-918685573 [![Coverage Status](https://coveralls.io/builds/42845484/badge)](https://coveralls.io/builds/42845484) Coverage increased (+0.2%) to 77.003% when pullin

[GitHub] [commons-imaging] kinow merged pull request #169: IMAGING-285 Correction for rational number computations

2021-09-13 Thread GitBox
kinow merged pull request #169: URL: https://github.com/apache/commons-imaging/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [commons-imaging] gwlucastrig commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

2021-09-13 Thread GitBox
gwlucastrig commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-918761710 I saw the note you posted on the Commons mailing list about the design of this. I'm wondering if just a simple brute-force approach might do the trick. So I will thr

[GitHub] [commons-imaging] gwlucastrig edited a comment on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

2021-09-13 Thread GitBox
gwlucastrig edited a comment on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-918761710 I saw the note you posted on the Commons mailing list about the design of this. If you're still looking for ideas for alternate approaches, maybe this will hel

[GitHub] [commons-imaging] kinow commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

2021-09-13 Thread GitBox
kinow commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-918771649 Hi @gwlucastrig Thanks for the detailed example. The only part of the implementation that bothers me is the static method. >Finally, each parameters class woul

[GitHub] [commons-collections] kinow commented on pull request #252: Bump commons.junit.version from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
kinow commented on pull request #252: URL: https://github.com/apache/commons-collections/pull/252#issuecomment-918787267 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [commons-collections] kinow merged pull request #253: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-13 Thread GitBox
kinow merged pull request #253: URL: https://github.com/apache/commons-collections/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #132: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-13 Thread GitBox
dependabot[bot] opened a new pull request #132: URL: https://github.com/apache/commons-dbcp/pull/132 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.14.0 to 3.15.0. Commits https://github.com/apache/maven-pmd-plugin/commit/7a738884d38c3f7baee4d49394

[GitHub] [commons-collections] kinow merged pull request #252: Bump commons.junit.version from 5.7.2 to 5.8.0

2021-09-13 Thread GitBox
kinow merged pull request #252: URL: https://github.com/apache/commons-collections/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues

[GitHub] [commons-ognl] lukaszlenart merged pull request #50: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-13 Thread GitBox
lukaszlenart merged pull request #50: URL: https://github.com/apache/commons-ognl/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-ognl] lukaszlenart merged pull request #37: Bump ognl from 3.2.18 to 3.2.21

2021-09-13 Thread GitBox
lukaszlenart merged pull request #37: URL: https://github.com/apache/commons-ognl/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-ognl] lukaszlenart merged pull request #30: Bump junit from 4.13.1 to 4.13.2

2021-09-13 Thread GitBox
lukaszlenart merged pull request #30: URL: https://github.com/apache/commons-ognl/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-ognl] lukaszlenart merged pull request #35: Bump easymock from 4.2 to 4.3

2021-09-13 Thread GitBox
lukaszlenart merged pull request #35: URL: https://github.com/apache/commons-ognl/pull/35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-ognl] lukaszlenart merged pull request #36: Bump javassist from 3.27.0-GA to 3.28.0-GA

2021-09-13 Thread GitBox
lukaszlenart merged pull request #36: URL: https://github.com/apache/commons-ognl/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-u

[GitHub] [commons-io] martin-g commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-13 Thread GitBox
martin-g commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-918858192 I used Moditect because it generates the module-info.java. With maven-compiler-plugin module-info.java must be in `src/main/java`, i.e. require JDK 9+ for development. Also

[GitHub] [commons-codec] DittoTool removed a comment on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
DittoTool removed a comment on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-912930932 Besides, we also found several TreeMap objects, which are only used for key-value pair retrieval. It would be better to replace it with HashMap. -- This is an auto

[GitHub] [commons-codec] jochenw commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
jochenw commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-918996199 Are there any sources, that you can quote with regards to the complexity of ArrayList vs. LinkedList? Thanks, Jochen -- This is an automated message from the Apache Git

[GitHub] [commons-codec] jochenw commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
jochenw commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-918998259 Besides: What is the tool Ditto, that you ae referring to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [commons-codec] jochenw edited a comment on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
jochenw edited a comment on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-918998259 Besides: What is the tool Ditto, that you are referring to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [commons-imaging] gwlucastrig commented on pull request #116: [IMAGING-159] Add ImagingParameters interface and BaseParameters (POJO)

2021-09-14 Thread GitBox
gwlucastrig commented on pull request #116: URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-919020286 I wonder whether we might be able to use Reflection and move the static resolveParameters() method into the base class so that it only appears once. resolveParameters

[GitHub] [commons-io] jochenw commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-14 Thread GitBox
jochenw commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919023495 One minor nitpick: As I understand it, there is now a hardcoded version 8 for the Java compiler. IIRC, there is a property in commons-parent for that. Please, change that to us

[GitHub] [commons-io] martin-g commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-14 Thread GitBox
martin-g commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919039303 @jochenw I guess you mean https://github.com/apache/commons-parent/blob/dd3e4bc64628c0e1ae15cf16a48a04bdfd8dbcc9/pom.xml#L109-L110 Those are overwritten here - https:

[GitHub] [commons-codec] garydgregory commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
garydgregory commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-919118081 I do not think we should change internals until we have an example that demonstrates whatever problem this tool thinks it found. This feels backward to me because accessi

[GitHub] [commons-codec] garydgregory commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
garydgregory commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-919119582 Tree maps are also handy for reproducing the same result over and over, also needs a demonstration of what the problem is in pragmatic terms. -- This is an automated me

[GitHub] [commons-codec] jochenw commented on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
jochenw commented on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-919145623 > I do not think we should change internals until we have an example that demonstrates whatever problem this tool thinks it found. This feels backward to me because accessing

[GitHub] [commons-io] garydgregory commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-14 Thread GitBox
garydgregory commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r708257169 ## File path: src/main/java/org/apache/commons/io/input/ByteBufferCleaner.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [commons-io] jochenw commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-14 Thread GitBox
jochenw commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919171643 > But there is no such for `maven.compiler.release` which uses `8` as a value vs. `1.8` used by `source` and `target`. If so, you can override the property maven.compiler

[GitHub] [commons-io] garydgregory commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-14 Thread GitBox
garydgregory commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919181667 FYI: This is how we use toolchains over at Log4j, see the `master` and `release-2.x` branches: https://github.com/apache/logging-log4j2/tree/release-2.x/.github/workflows

[GitHub] [commons-io] garydgregory commented on pull request #82: Flush the OutputStream before calling toByteArray on underlying ByteArrayOutputStream

2021-09-14 Thread GitBox
garydgregory commented on pull request #82: URL: https://github.com/apache/commons-io/pull/82#issuecomment-919207340 @emopers Thank you for your PR; may you please rebase on master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [commons-io] garydgregory commented on pull request #9: Added a true iterator for traversing the file trees

2021-09-14 Thread GitBox
garydgregory commented on pull request #9: URL: https://github.com/apache/commons-io/pull/9#issuecomment-919210903 I still don't think we want to double up a feature that already exists within the JDK and our code base. Have you tried using `FileUtils.streamFiles(File, boolean, String...)`

[GitHub] [commons-io] garydgregory edited a comment on pull request #9: Added a true iterator for traversing the file trees

2021-09-14 Thread GitBox
garydgregory edited a comment on pull request #9: URL: https://github.com/apache/commons-io/pull/9#issuecomment-919210903 I still don't think we want to double up a feature that already exists within the JDK and our code base. Have you tried using - `FileUtils.streamFiles(File, boolean,

[GitHub] [commons-imaging] jephillips34 commented on a change in pull request #163: IMAGING-310 JpegImageParser.getImageInfo() Refactor colorType logic to first look at numberOfComponents

2021-09-14 Thread GitBox
jephillips34 commented on a change in pull request #163: URL: https://github.com/apache/commons-imaging/pull/163#discussion_r708447620 ## File path: src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java ## @@ -824,44 +824,44 @@ public ImageInfo getImageInf

[GitHub] [commons-imaging] jephillips34 commented on a change in pull request #163: IMAGING-310 JpegImageParser.getImageInfo() Refactor colorType logic to first look at numberOfComponents

2021-09-14 Thread GitBox
jephillips34 commented on a change in pull request #163: URL: https://github.com/apache/commons-imaging/pull/163#discussion_r708448681 ## File path: src/main/java/org/apache/commons/imaging/formats/jpeg/JpegImageParser.java ## @@ -824,44 +824,44 @@ public ImageInfo getImageInf

[GitHub] [commons-codec] coveralls edited a comment on pull request #92: Avoid inefficient usage of arraylist

2021-09-14 Thread GitBox
coveralls edited a comment on pull request #92: URL: https://github.com/apache/commons-codec/pull/92#issuecomment-912931083 [![Coverage Status](https://coveralls.io/builds/42867060/badge)](https://coveralls.io/builds/42867060) Coverage remained the same at 94.682% when pulling *

[GitHub] [commons-csv] coveralls commented on pull request #181: Bump commons.pmd-impl.version from 6.37.0 to 6.38.0

2021-09-14 Thread GitBox
coveralls commented on pull request #181: URL: https://github.com/apache/commons-csv/pull/181#issuecomment-919379661 [![Coverage Status](https://coveralls.io/builds/42868298/badge)](https://coveralls.io/builds/42868298) Coverage remained the same at 98.323% when pulling **717ccd

[GitHub] [commons-imaging] coveralls commented on pull request #170: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-14 Thread GitBox
coveralls commented on pull request #170: URL: https://github.com/apache/commons-imaging/pull/170#issuecomment-919600795 [![Coverage Status](https://coveralls.io/builds/42877285/badge)](https://coveralls.io/builds/42877285) Coverage remained the same at 77.003% when pulling **98

[GitHub] [commons-imaging] kinow merged pull request #170: Bump junit-jupiter from 5.7.2 to 5.8.0

2021-09-14 Thread GitBox
kinow merged pull request #170: URL: https://github.com/apache/commons-imaging/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[GitHub] [commons-lang] ali-ghanbari opened a new pull request #804: floor and ceiling for Sorted Arrays

2021-09-14 Thread GitBox
ali-ghanbari opened a new pull request #804: URL: https://github.com/apache/commons-lang/pull/804 If I am not mistaking, JDK standard library and the current implementation of Apache Commons Lang do not have functions for binary searching for `floor` and `ceiling` in sorted arrays.

[GitHub] [commons-io] martin-g commented on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-15 Thread GitBox
martin-g commented on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919971381 > If so, you can override the property maven.compiler.release with the value "8". Should work fine, as far as I know. @jochenw I don't follow you! There is no mention of

[GitHub] [commons-io] martin-g edited a comment on pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-15 Thread GitBox
martin-g edited a comment on pull request #268: URL: https://github.com/apache/commons-io/pull/268#issuecomment-919971381 > If so, you can override the property maven.compiler.release with the value "8". Should work fine, as far as I know. @jochenw I don't follow you! There is no men

[GitHub] [commons-csv] dependabot[bot] opened a new pull request #184: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-15 Thread GitBox
dependabot[bot] opened a new pull request #184: URL: https://github.com/apache/commons-csv/pull/184 Bumps [maven-pmd-plugin](https://github.com/apache/maven-pmd-plugin) from 3.14.0 to 3.15.0. Commits https://github.com/apache/maven-pmd-plugin/commit/7a738884d38c3f7baee4d493940

[GitHub] [commons-io] shollander commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-15 Thread GitBox
shollander commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r709177797 ## File path: src/main/java/org/apache/commons/io/input/ByteBufferCleaner.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [commons-io] shollander commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-15 Thread GitBox
shollander commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r709178065 ## File path: src/main/java/org/apache/commons/io/input/ByteBufferCleaner.java ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [commons-io] shollander commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-15 Thread GitBox
shollander commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r709178300 ## File path: src/main/java/org/apache/commons/io/input/MemoryMappedFileInputStream.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-io] shollander commented on a change in pull request #215: IO-726 Add MemoryMappedInputStream.

2021-09-15 Thread GitBox
shollander commented on a change in pull request #215: URL: https://github.com/apache/commons-io/pull/215#discussion_r709178629 ## File path: src/main/java/org/apache/commons/io/input/MemoryMappedFileInputStream.java ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apache Software

[GitHub] [commons-lang] dependabot[bot] opened a new pull request #805: Bump junit-bom from 5.7.2 to 5.8.0

2021-09-15 Thread GitBox
dependabot[bot] opened a new pull request #805: URL: https://github.com/apache/commons-lang/pull/805 Bumps [junit-bom](https://github.com/junit-team/junit5) from 5.7.2 to 5.8.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>junit-bom's releases.

[GitHub] [commons-lang] garydgregory commented on pull request #804: floor and ceiling for Sorted Arrays

2021-09-15 Thread GitBox
garydgregory commented on pull request #804: URL: https://github.com/apache/commons-lang/pull/804#issuecomment-920118221 I have no idea what this new code does as there are ZERO Javadocs, so there is nothing to review from my POV. There is also a lot of code duplication but I am not sure i

[GitHub] [commons-lang] ali-ghanbari commented on pull request #804: floor and ceiling for Sorted Arrays

2021-09-15 Thread GitBox
ali-ghanbari commented on pull request #804: URL: https://github.com/apache/commons-lang/pull/804#issuecomment-920126109 > I have no idea what this new code does as there are ZERO Javadocs, so there is nothing to review from my POV. Thank you for your feedback @garydgregory :)

[GitHub] [commons-io] thammegowda closed pull request #9: Added a true iterator for traversing the file trees

2021-09-15 Thread GitBox
thammegowda closed pull request #9: URL: https://github.com/apache/commons-io/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [commons-lang] garydgregory commented on pull request #804: floor and ceiling for Sorted Arrays

2021-09-15 Thread GitBox
garydgregory commented on pull request #804: URL: https://github.com/apache/commons-lang/pull/804#issuecomment-920260321 What happens if the array is not sorted? Is it possible for the code to cause an infinite loop? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [commons-csv] coveralls commented on pull request #184: Bump maven-pmd-plugin from 3.14.0 to 3.15.0

2021-09-15 Thread GitBox
coveralls commented on pull request #184: URL: https://github.com/apache/commons-csv/pull/184#issuecomment-920306640 [![Coverage Status](https://coveralls.io/builds/42903180/badge)](https://coveralls.io/builds/42903180) Coverage remained the same at 98.323% when pulling **03ac07

[GitHub] [commons-lang] coveralls commented on pull request #805: Bump junit-bom from 5.7.2 to 5.8.0

2021-09-15 Thread GitBox
coveralls commented on pull request #805: URL: https://github.com/apache/commons-lang/pull/805#issuecomment-920411307 [![Coverage Status](https://coveralls.io/builds/42906744/badge)](https://coveralls.io/builds/42906744) Coverage remained the same at 94.951% when pulling **d1d19

[GitHub] [commons-vfs] wx930910 commented on pull request #213: refactor CountingListener to improve test design

2021-09-15 Thread GitBox
wx930910 commented on pull request #213: URL: https://github.com/apache/commons-vfs/pull/213#issuecomment-920482311 @garydgregory Thanks for your feedback and I changed code logic, do you think the updated code is less complex compared to the existing code? (Given the fact that we no longe

[GitHub] [commons-lang] coveralls commented on pull request #804: floor and ceiling for Sorted Arrays

2021-09-15 Thread GitBox
coveralls commented on pull request #804: URL: https://github.com/apache/commons-lang/pull/804#issuecomment-920508133 [![Coverage Status](https://coveralls.io/builds/42910252/badge)](https://coveralls.io/builds/42910252) Coverage decreased (-1.8%) to 93.14% when pulling **3f8003

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #133: Bump spotbugs from 4.4.0 to 4.4.1

2021-09-15 Thread GitBox
dependabot[bot] opened a new pull request #133: URL: https://github.com/apache/commons-dbcp/pull/133 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.0 to 4.4.1. Release notes Sourced from https://github.com/spotbugs/spotbugs/releases";>spotbugs's releases. S

[GitHub] [commons-dbcp] dependabot[bot] opened a new pull request #134: Bump narayana-jta from 5.12.0.Final to 5.12.1.Final

2021-09-15 Thread GitBox
dependabot[bot] opened a new pull request #134: URL: https://github.com/apache/commons-dbcp/pull/134 Bumps narayana-jta from 5.12.0.Final to 5.12.1.Final. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.jbo

[GitHub] [commons-rng] wx930910 opened a new pull request #102: replace test child class with mocking object

2021-09-15 Thread GitBox
wx930910 opened a new pull request #102: URL: https://github.com/apache/commons-rng/pull/102 Fix [RNG-164](https://issues.apache.org/jira/browse/RNG-164) ### Description Replace test class [SimpleSampler](https://github.com/apache/commons-rng/blob/42a5151f9e2433ce84a6a772

[GitHub] [commons-rng] wx930910 commented on pull request #102: replace test child class with mocking object

2021-09-15 Thread GitBox
wx930910 commented on pull request #102: URL: https://github.com/apache/commons-rng/pull/102#issuecomment-920628912 Actually we can further improve the code logic by spying parent production class SamplerBase since all the overridden methods only call super methods defined in the parent cl

[GitHub] [commons-rng] coveralls commented on pull request #102: replace test child class with mocking object

2021-09-16 Thread GitBox
coveralls commented on pull request #102: URL: https://github.com/apache/commons-rng/pull/102#issuecomment-920638791 [![Coverage Status](https://coveralls.io/builds/42914221/badge)](https://coveralls.io/builds/42914221) Coverage remained the same at 99.758% when pulling **6a111b

[GitHub] [commons-csv] dependabot[bot] opened a new pull request #185: Bump junit-jupiter from 5.8.0-RC1 to 5.8.0

2021-09-16 Thread GitBox
dependabot[bot] opened a new pull request #185: URL: https://github.com/apache/commons-csv/pull/185 Bumps [junit-jupiter](https://github.com/junit-team/junit5) from 5.8.0-RC1 to 5.8.0. Release notes Sourced from https://github.com/junit-team/junit5/releases";>junit-jupiter's rele

[GitHub] [commons-csv] coveralls commented on pull request #185: Bump junit-jupiter from 5.8.0-RC1 to 5.8.0

2021-09-16 Thread GitBox
coveralls commented on pull request #185: URL: https://github.com/apache/commons-csv/pull/185#issuecomment-920960235 [![Coverage Status](https://coveralls.io/builds/42924754/badge)](https://coveralls.io/builds/42924754) Coverage remained the same at 98.323% when pulling **eb637f

[GitHub] [commons-io] jochenw merged pull request #268: IO-747 Make commons-io a proper JPMS module

2021-09-17 Thread GitBox
jochenw merged pull request #268: URL: https://github.com/apache/commons-io/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[GitHub] [commons-io] coveralls edited a comment on pull request #32: Introduce Tailable interface to allow tailing of files accessed using alternative libraries such as jCIFS or commons-vfs

2021-09-17 Thread GitBox
coveralls edited a comment on pull request #32: URL: https://github.com/apache/commons-io/pull/32#issuecomment-282368291 [![Coverage Status](https://coveralls.io/builds/42961752/badge)](https://coveralls.io/builds/42961752) Coverage decreased (-0.03%) to 88.89% when pulling **39

  1   2   3   4   5   6   7   8   9   10   >