Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-27 Thread via GitHub
garydgregory commented on PR #1364: URL: https://github.com/apache/commons-lang/pull/1364#issuecomment-2758703205 Closing: See comments, no feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-27 Thread via GitHub
garydgregory closed pull request #1364: extracting duplicate logic to improve modularization URL: https://github.com/apache/commons-lang/pull/1364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1364: URL: https://github.com/apache/commons-lang/pull/1364#issuecomment-2747919297 Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix -

Re: [PR] extracting duplicate logic to improve modularization [commons-lang]

2025-03-24 Thread via GitHub
ppkarwasz commented on PR #1364: URL: https://github.com/apache/commons-lang/pull/1364#issuecomment-2747863705 @shraymoza, Can you explain, what problem does this PR solve and what goals are you trying to achieve? -- This is an automated message from the Apache Git Service. To resp