Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
garydgregory closed pull request #1363: encapsulating to avoid Deficient Encapsulation URL: https://github.com/apache/commons-lang/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
garydgregory commented on PR #1363: URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747920571 Hello @shraymoza -1: This looks to me like change for the sake of change. If you would like to help the project: - Look at Jira tickets for bugs to fix -

Re: [PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
aherbert commented on PR #1363: URL: https://github.com/apache/commons-lang/pull/1363#issuecomment-2747213572 Removing a public field will break binary compatibility. Note that the field is **final** and encapsulation is not required. -- This is an automated message from the Apache Git Se

[PR] encapsulating to avoid Deficient Encapsulation [commons-lang]

2025-03-24 Thread via GitHub
shraymoza opened a new pull request, #1363: URL: https://github.com/apache/commons-lang/pull/1363 encapsulating to avoid Deficient Encapsulation Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull r