Re: [PR] Update ClassParser.java [commons-bcel]

2025-02-03 Thread via GitHub
jjestrada2 commented on PR #406: URL: https://github.com/apache/commons-bcel/pull/406#issuecomment-2631052665 Thanks I will look into it, sorry for the delay response. I will start working on it this week On Mon, Feb 3, 2025 at 8:33 AM Gary Gregory ***@***.***> wrote: > If

Re: [PR] Update ClassParser.java [commons-bcel]

2025-02-03 Thread via GitHub
garydgregory commented on PR #406: URL: https://github.com/apache/commons-bcel/pull/406#issuecomment-2631020843 If you're looking for something to do here, you could see why `ConstantPoolModuleAccessTestCase` fails on Java 23. -- This is an automated message from the Apache Git Servic

Re: [PR] Update ClassParser.java [commons-bcel]

2025-01-31 Thread via GitHub
garydgregory commented on PR #406: URL: https://github.com/apache/commons-bcel/pull/406#issuecomment-2628002101 The breaking change is what would happen if a class happens to be using that package but is not one of the two specific classes the PR now requires. The behavior is differe

[PR] Update ClassParser.java [commons-bcel]

2025-01-31 Thread via GitHub
jjestrada2 opened a new pull request, #406: URL: https://github.com/apache/commons-bcel/pull/406 ### Refactored `ClassParser` to Use instanceof for ZIP/JAR Detection Problem: The previous implementation used `getClass().getName()` to detect if an `InputStream` was from a ZIP/J