Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-20 Thread via GitHub
garydgregory merged PR #728: URL: https://github.com/apache/commons-io/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commo

Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-20 Thread via GitHub
dsmiley commented on PR #728: URL: https://github.com/apache/commons-io/pull/728#issuecomment-2740476566 At first I thought "test" phase might be enough (I pushed) -- it wasn't. Then "verify" (I pushed) -- but apparently not! The project should hookup "spotbugs" to verify. It ran when I

Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-20 Thread via GitHub
garydgregory commented on PR #728: URL: https://github.com/apache/commons-io/pull/728#issuecomment-2740224949 Hello @dsmiley The builds are still red. Run `mvn`; that's `mvn` on the command line, by itself. There is no sense in pushing broken commits if your build fails locally. --

Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-19 Thread via GitHub
dsmiley commented on PR #728: URL: https://github.com/apache/commons-io/pull/728#issuecomment-2739106962 I didn't run "mvn" but otherwise I believe I'm compliant with this projects many rules. If there's still a problem after the tests pass but I haven't done something specifically, just l

Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-19 Thread via GitHub
garydgregory commented on PR #728: URL: https://github.com/apache/commons-io/pull/728#issuecomment-2738952197 @dsmiley You did not follow the PR template: Before you push a pull request, review this list: - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this

Re: [PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-19 Thread via GitHub
dsmiley commented on PR #728: URL: https://github.com/apache/commons-io/pull/728#issuecomment-2738826361 I might actually be able to test this using Zip FileSystem from a JAR to copy to a temp dir (standard/default FileSystem). Could just use a dependency's JAR. Hmmm. -- This is an aut

[PR] IO-870: PathUtils.copyFileToDirectory [commons-io]

2025-03-19 Thread via GitHub
dsmiley opened a new pull request, #728: URL: https://github.com/apache/commons-io/pull/728 span FileSystem. https://issues.apache.org/jira/browse/IO-870 > PathUtils.copyFileToDirectory is a simple method calling Files.copy, the latter of which supports cross-FileSystem copy.