Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-07-25 Thread via GitHub
garydgregory commented on code in PR #354: URL: https://github.com/apache/commons-email/pull/354#discussion_r2230874110 ## commons-email2-jakarta/src/test/java/org/apache/commons/mail2/jakarta/EmailTest.java: ## @@ -571,6 +572,17 @@ public void testGetSetAuthentication() {

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-07-24 Thread via GitHub
sgoeschl commented on PR #354: URL: https://github.com/apache/commons-email/pull/354#issuecomment-3113813118 @garydgregory Are you happy with the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-07-03 Thread via GitHub
mkomko commented on PR #354: URL: https://github.com/apache/commons-email/pull/354#issuecomment-3034739823 @garydgregory Reminder, thank you 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-29 Thread via GitHub
sgoeschl commented on PR #354: URL: https://github.com/apache/commons-email/pull/354#issuecomment-2918692085 @garydgregory Merged your changes and resolved all issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-29 Thread via GitHub
sgoeschl commented on code in PR #354: URL: https://github.com/apache/commons-email/pull/354#discussion_r2113406223 ## commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/Email.java: ## @@ -822,6 +827,10 @@ public Session getMailSession() throws EmailException {

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-28 Thread via GitHub
mkomko commented on code in PR #354: URL: https://github.com/apache/commons-email/pull/354#discussion_r2111321800 ## commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java: ## @@ -1640,6 +1659,20 @@ public Email setStartTLSRequired(final boolean startT

[PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-27 Thread via GitHub
sgoeschl opened a new pull request, #354: URL: https://github.com/apache/commons-email/pull/354 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [X] Read the [con