Re: [PR] Consolidating duplicated add logic [commons-lang]

garydgregory commented on PR #1362: URL: https://github.com/apache/commons-lang/pull/1362#issuecomment-2747923982 Hello @shraymoza -1 here and I agree with the other comments. If you would like to help the project: - Look at Jira tickets for bugs to fix - Fix the fail

Re: [PR] Consolidating duplicated add logic [commons-lang]

garydgregory closed pull request #1362: Consolidating duplicated add logic URL: https://github.com/apache/commons-lang/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Consolidating duplicated add logic [commons-lang]

sgflt commented on PR #1362: URL: https://github.com/apache/commons-lang/pull/1362#issuecomment-2746956040 Java != C++. This change introduces memory allocations caused by boxing of primitives and I think it is the cause, why code is not intentionally DRY. -- This is an automated m

[PR] Consolidating duplicated add logic [commons-lang]

shraymoza opened a new pull request, #1362: URL: https://github.com/apache/commons-lang/pull/1362 By consolidating the duplicated logic into a generic method, the code becomes more DRY (Don’t Repeat Yourself) and easier to maintain. It also minimizes the risk of errors when similar changes