Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
jfclere commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095926869 OK I am on it ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
markt-asf commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095919403 OK. I'm less concerned then. That said, that suggests the CI build isn't building the binary correctly. I'd suggest fixing that rather than adding the dll so potential issues are n

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
jfclere commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095783555 It is a from a CI output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
markt-asf commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095753452 Sorry. Let me step back a bit. Is this binary from a release (if so which one) or a CI output? -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
jfclere commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095734338 From the artifact. Note https://github.com/apache/commons-daemon/pull/271 that makes a static binary. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
markt-asf commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095723633 Where did you get the binary from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-21 Thread via GitHub
jfclere commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3095647489 I tested on a clean 2025 server install, copy the executable and noted that it needs vcruntime140.dll. Having the executable available makes testing on different OS version more

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-18 Thread via GitHub
markt-asf commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3090022303 -1 (almost veto). This absolutely should not be necessary. If it is, the binary hasn't been built properly. Which binary were you testing with? I thought I'd tested the most recent

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-07-18 Thread via GitHub
jfclere commented on PR #265: URL: https://github.com/apache/commons-daemon/pull/265#issuecomment-3089863140 the artifact needs vcruntime140.dll -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add artifact with prunsrv.exe [commons-daemon]

2025-06-06 Thread via GitHub
jfclere merged PR #265: URL: https://github.com/apache/commons-daemon/pull/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

[PR] Add artifact with prunsrv.exe [commons-daemon]

2025-05-28 Thread via GitHub
jfclere opened a new pull request, #265: URL: https://github.com/apache/commons-daemon/pull/265 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [con