Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-06-01 Thread via GitHub
ppkarwasz commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2926766400 > What I care about is the ability to build independent 'archiver' libraries, for instance, for ZIP, TAR, and other formats, and similarly for 'compressor' libraries. This is cur

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-31 Thread via GitHub
bdw-g commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2926619146 I'm not sure I understand why binary compatiblity would still be broken, can you elaborate? > Because of this inlining behavior, introducing a separate ArchiveStreamConstants

Re: [PR] Simplify exception handling in `FileItem` API [commons-fileupload]

2025-05-31 Thread via GitHub
ppkarwasz commented on PR #309: URL: https://github.com/apache/commons-fileupload/pull/309#issuecomment-2926603700 @basil, Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Simplify exception handling in `FileItem` API [commons-fileupload]

2025-05-31 Thread via GitHub
ppkarwasz merged PR #309: URL: https://github.com/apache/commons-fileupload/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Simplify exception handling in `FileItem` API [commons-fileupload]

2025-05-31 Thread via GitHub
basil commented on PR #309: URL: https://github.com/apache/commons-fileupload/pull/309#issuecomment-2926419694 Thanks @ppkarwasz! I added an entry to the changelog in commit f8141db22ddd19b3758d4be5d426c2c0d18e5986. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-31 Thread via GitHub
ppkarwasz commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2925179806 I agree with Gary that this pull request doesn't add any value, but feel free to provide concrete examples of problems that it solves. -- This is an automated message from the

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-31 Thread via GitHub
ppkarwasz closed pull request #673: Separate ArchiveStreamConstants from ArchiveStreamFactory URL: https://github.com/apache/commons-compress/pull/673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.revapi:revapi-java from 0.28.3 to 0.28.4 [commons-rng]

2025-05-31 Thread via GitHub
ppkarwasz commented on PR #143: URL: https://github.com/apache/commons-rng/pull/143#issuecomment-2925175380 If we are planning a release, it is certainly worth switching to `japicmp`, for a couple of reasons: - To lighten our workload, since Dependabot updates from `japicmp` are in `

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-31 Thread via GitHub
garydgregory commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2925170687 Still -1, not worth doing AND binary compatibility is STILL broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-31 Thread via GitHub
ppkarwasz commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2925166305 > Many archivers rely on the constants defined in ArchiveStreamFactory, and ArchiveStreamFactory relies on the individual archiver classes. This is currently a build cycle.

Re: [PR] Bump org.revapi:revapi-java from 0.28.3 to 0.28.4 [commons-rng]

2025-05-31 Thread via GitHub
garydgregory commented on PR #143: URL: https://github.com/apache/commons-rng/pull/143#issuecomment-2925160944 Yes indeed, but this component seems to like revapi. Is it worth changing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Bump org.revapi:revapi-java from 0.28.3 to 0.28.4 [commons-rng]

2025-05-31 Thread via GitHub
ppkarwasz commented on PR #143: URL: https://github.com/apache/commons-rng/pull/143#issuecomment-2925143430 @garydgregory, doesn't Commons use `japicmp` instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-beanutils]

2025-05-30 Thread via GitHub
garydgregory merged PR #352: URL: https://github.com/apache/commons-beanutils/pull/352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-validator]

2025-05-30 Thread via GitHub
garydgregory merged PR #340: URL: https://github.com/apache/commons-validator/pull/340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-weaver]

2025-05-30 Thread via GitHub
garydgregory merged PR #45: URL: https://github.com/apache/commons-weaver/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-email]

2025-05-30 Thread via GitHub
garydgregory merged PR #355: URL: https://github.com/apache/commons-email/pull/355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-text]

2025-05-30 Thread via GitHub
garydgregory merged PR #674: URL: https://github.com/apache/commons-text/pull/674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump github/codeql-action from 3.28.17 to 3.28.18 [commons-bcel]

2025-05-30 Thread via GitHub
garydgregory merged PR #433: URL: https://github.com/apache/commons-bcel/pull/433 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-bcel]

2025-05-30 Thread via GitHub
garydgregory merged PR #436: URL: https://github.com/apache/commons-bcel/pull/436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-30 Thread via GitHub
bdw-g commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2923402745 Better this way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-30 Thread via GitHub
bdw-g commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2923311972 Got it, will fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-rdf]

2025-05-30 Thread via GitHub
garydgregory merged PR #336: URL: https://github.com/apache/commons-rdf/pull/336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-fileupload]

2025-05-30 Thread via GitHub
garydgregory merged PR #418: URL: https://github.com/apache/commons-fileupload/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-jxpath]

2025-05-30 Thread via GitHub
garydgregory merged PR #244: URL: https://github.com/apache/commons-jxpath/pull/244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-imaging]

2025-05-30 Thread via GitHub
garydgregory merged PR #510: URL: https://github.com/apache/commons-imaging/pull/510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-exec]

2025-05-30 Thread via GitHub
garydgregory merged PR #277: URL: https://github.com/apache/commons-exec/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump ossf/scorecard-action from 2.4.1 to 2.4.2 [commons-configuration]

2025-05-30 Thread via GitHub
garydgregory merged PR #575: URL: https://github.com/apache/commons-configuration/pull/575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

Re: [PR] Bump docker/setup-qemu-action from 3.5.0 to 3.6.0 [commons-crypto]

2025-05-30 Thread via GitHub
garydgregory commented on PR #446: URL: https://github.com/apache/commons-crypto/pull/446#issuecomment-2922472703 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Bump docker/build-push-action from 6.17.0 to 6.18.0 [commons-crypto]

2025-05-30 Thread via GitHub
garydgregory merged PR #467: URL: https://github.com/apache/commons-crypto/pull/467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.revapi:revapi-java from 0.28.3 to 0.28.4 [commons-rng]

2025-05-30 Thread via GitHub
garydgregory merged PR #143: URL: https://github.com/apache/commons-rng/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-30 Thread via GitHub
garydgregory commented on PR #673: URL: https://github.com/apache/commons-compress/pull/673#issuecomment-2922102985 -1: Bad design AND breaks binary compatibility. To learn why this is an anti-pattern, please see _Effective Java_ by Joshua Block, _Item 22: Use Intercaes only to define

Re: [PR] Bump org.junit:junit-bom from 5.12.2 to 5.13.0 [commons-parent]

2025-05-30 Thread via GitHub
garydgregory merged PR #626: URL: https://github.com/apache/commons-parent/pull/626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.codehaus.groovy:groovy-all from 3.0.24 to 3.0.25 [commons-jci]

2025-05-30 Thread via GitHub
garydgregory merged PR #199: URL: https://github.com/apache/commons-jci/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

[PR] Separate ArchiveStreamConstants from ArchiveStreamFactory [commons-compress]

2025-05-30 Thread via GitHub
bdw-g opened a new pull request, #673: URL: https://github.com/apache/commons-compress/pull/673 Many archivers rely on the constants defined in ArchiveStreamFactory, and ArchiveStreamFactory relies on the individual archiver classes. This is currently a build cycle. By extracting the consta

Re: [PR] Bump commons-beanutils:commons-beanutils from 1.10.1 to 1.11.0 in /jelly-tags/util [commons-jelly]

2025-05-29 Thread via GitHub
garydgregory merged PR #48: URL: https://github.com/apache/commons-jelly/pull/48 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump javax.servlet:servlet-api from 2.3 to 2.5 [commons-jelly]

2025-05-29 Thread via GitHub
garydgregory merged PR #49: URL: https://github.com/apache/commons-jelly/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump org.apache.groovy:groovy from 4.0.26 to 4.0.27 [commons-scxml]

2025-05-29 Thread via GitHub
garydgregory merged PR #329: URL: https://github.com/apache/commons-scxml/pull/329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump org.apache.tomcat:tomcat-catalina from 9.0.104 to 9.0.105 in /commons-jcs3-jcache-extras [commons-jcs]

2025-05-29 Thread via GitHub
garydgregory merged PR #358: URL: https://github.com/apache/commons-jcs/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] GraphLike with addAll [commons-rdf]

2025-05-29 Thread via GitHub
naturzukunft commented on PR #325: URL: https://github.com/apache/commons-rdf/pull/325#issuecomment-2919747510 @garydgregory do you find time to review this PR? How is the release plan for commons-rdf 0.6.0 ? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] deprecated ObjectUtils `defaultIfNull` in favor or `getIfNull` overload `getFirstNonNull` with `collection` support [commons-lang]

2025-05-29 Thread via GitHub
Pankraz76 commented on PR #1355: URL: https://github.com/apache/commons-lang/pull/1355#issuecomment-2918862801 thx. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-29 Thread via GitHub
sgoeschl commented on PR #354: URL: https://github.com/apache/commons-email/pull/354#issuecomment-2918692085 @garydgregory Merged your changes and resolved all issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-29 Thread via GitHub
sgoeschl commented on code in PR #354: URL: https://github.com/apache/commons-email/pull/354#discussion_r2113406223 ## commons-email2-javax/src/main/java/org/apache/commons/mail2/javax/Email.java: ## @@ -822,6 +827,10 @@ public Session getMailSession() throws EmailException {

Re: [PR] [LANG-1771] Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-28 Thread via GitHub
abhisripathi commented on PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#issuecomment-2917898256 Hi @garydgregory Thanks for the clarification, Gary — that makes sense. Given the updated direction, would you prefer that I modify the implementation to throw an Ille

Re: [PR] [LANG-1771] Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#issuecomment-2917738306 Hello @abhisripathi I don't think we should return bad output for bad input; bad input should throw an IAE. Unfortunately, the current implementation is inconsistent, so

Re: [PR] Javadoc typo in Base16.java [commons-codec]

2025-05-28 Thread via GitHub
garydgregory merged PR #380: URL: https://github.com/apache/commons-codec/pull/380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] [LANG-1771] Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-28 Thread via GitHub
abhisripathi commented on PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#issuecomment-2917689728 Hi Gary, Just to clarify — the malformed input test case ("[String" → "String[]") was taken directly from the JIRA ticket (LANG-1771), which I was fixing. I included it to

Re: [PR] deprecated ObjectUtils `defaultIfNull` in favor or `getIfNull` overload `getFirstNonNull` with `collection` support [commons-lang]

2025-05-28 Thread via GitHub
garydgregory closed pull request #1355: deprecated ObjectUtils `defaultIfNull` in favor or `getIfNull` overload `getFirstNonNull` with `collection` support URL: https://github.com/apache/commons-lang/pull/1355 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] deprecated ObjectUtils `defaultIfNull` in favor or `getIfNull` overload `getFirstNonNull` with `collection` support [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1355: URL: https://github.com/apache/commons-lang/pull/1355#issuecomment-2917512110 Hello @Pankraz76 There are conflicts in the PR so I brought this in slightly differently in git master. You are credited in the commit comment and `changes.xml` TY

Re: [PR] LANG-1743 - when ArrayUtils.removeAll meeting 'null' array (PROPOSED CHANGE) [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1312: URL: https://github.com/apache/commons-lang/pull/1312#issuecomment-2917404846 Closing: No more feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] LANG-1743 - when ArrayUtils.removeAll meeting 'null' array (PROPOSED CHANGE) [commons-lang]

2025-05-28 Thread via GitHub
garydgregory closed pull request #1312: LANG-1743 - when ArrayUtils.removeAll meeting 'null' array (PROPOSED CHANGE) URL: https://github.com/apache/commons-lang/pull/1312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1392: URL: https://github.com/apache/commons-lang/pull/1392#issuecomment-2917395620 I'm not requesting support for grapheme cluster in the runtime, but we should set expectations in unit tests, whether they are supported or not. This is a larger discussion, whi

Re: [PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-28 Thread via GitHub
kiddos commented on PR #1392: URL: https://github.com/apache/commons-lang/pull/1392#issuecomment-2917350646 Oh, right. it's just tricky to handle grapheme cluster. the codePoint solution you mention does seems to work. I'll add more tests using grapheme clusters. -- This is an aut

Re: [PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1392: URL: https://github.com/apache/commons-lang/pull/1392#issuecomment-2917189699 @kiddos Please see my previous comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[PR] Implement a LatchUtils helper class to wrap CountDownLatch instantiation along with countDown() and await() method invocations, decoupling business logic from concurrency control for safer and cl

2025-05-28 Thread via GitHub
wwwzzzggg333 opened a new pull request, #1394: URL: https://github.com/apache/commons-lang/pull/1394 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the

Re: [PR] Implement a LatchUtils helper class to wrap CountDownLatch instantiation along with countDown() and await() method invocations, decoupling business logic from concurrency control for safer an

2025-05-28 Thread via GitHub
wwwzzzggg333 commented on PR #1393: URL: https://github.com/apache/commons-lang/pull/1393#issuecomment-2917173135 I will re pr later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Implement a LatchUtils helper class to wrap CountDownLatch instantiation along with countDown() and await() method invocations, decoupling business logic from concurrency control for safer an

2025-05-28 Thread via GitHub
wwwzzzggg333 closed pull request #1393: Implement a LatchUtils helper class to wrap CountDownLatch instantiation along with countDown() and await() method invocations, decoupling business logic from concurrency control for safer and cleaner thread coordination. URL: https://github.com/apache/c

[PR] Implement a LatchUtils helper class to wrap CountDownLatch instantiation along with countDown() and await() method invocations, decoupling business logic from concurrency control for safer and cl

2025-05-28 Thread via GitHub
wwwzzzggg333 opened a new pull request, #1393: URL: https://github.com/apache/commons-lang/pull/1393 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the

Re: [PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-28 Thread via GitHub
kiddos commented on PR #1392: URL: https://github.com/apache/commons-lang/pull/1392#issuecomment-2917120806 I added some test cases for emoji characters 🚀✨🎉 I did some testing and found that current implementation the escape characters worked "\uD83D\uDE80\u2728\uD83C\uDF89", but "🚀✨🎉" do

Re: [PR] [LANG-1771] Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-28 Thread via GitHub
garydgregory commented on PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#issuecomment-2917119973 -1: Hm, now that I look at this PR again, this test doesn't make sense: ``` assertEquals("String[]", ClassUtils.getShortCanonicalName("[String")); ``` We would be inve

Re: [PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-28 Thread via GitHub
mkomko commented on code in PR #354: URL: https://github.com/apache/commons-email/pull/354#discussion_r2111321800 ## commons-email2-jakarta/src/main/java/org/apache/commons/mail2/jakarta/Email.java: ## @@ -1640,6 +1659,20 @@ public Email setStartTLSRequired(final boolean startT

[PR] Add artifact with prunsrv.exe [commons-daemon]

2025-05-28 Thread via GitHub
jfclere opened a new pull request, #265: URL: https://github.com/apache/commons-daemon/pull/265 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [con

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2110664497 ## src/test/java/org/apache/commons/lang3/StringUtilsTest.java: ## @@ -937,7 +937,7 @@ public void testIsAllUpperCase() { assertFalse(StringUtils.isA

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
garydgregory commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2110611775 ## src/test/java/org/apache/commons/lang3/StringUtilsTest.java: ## @@ -937,7 +937,7 @@ public void testIsAllUpperCase() { assertFalse(StringUtils.isA

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2110595399 ## src/main/java/org/apache/commons/lang3/ClassUtils.java: ## @@ -496,9 +496,14 @@ private static String getCanonicalName(final String name) { classN

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2110594640 ## src/test/java/org/apache/commons/lang3/StringUtilsTest.java: ## @@ -937,7 +937,7 @@ public void testIsAllUpperCase() { assertFalse(StringUtils.isA

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2110594127 ## src/main/java/org/apache/commons/lang3/ClassUtils.java: ## @@ -496,9 +496,14 @@ private static String getCanonicalName(final String name) { classN

Re: [PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-27 Thread via GitHub
ecki commented on PR #1392: URL: https://github.com/apache/commons-lang/pull/1392#issuecomment-2914481169 Agree, very useful when dealing with UTF8 databases. Wonder if it should also deal with other encodings. -- This is an automated message from the Apache Git Service. To respond to the

[PR] Javadoc typo in Base16.java [commons-codec]

2025-05-27 Thread via GitHub
Baunsgaard opened a new pull request, #380: URL: https://github.com/apache/commons-codec/pull/380 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] EMAIL-163 Support for OAuth2 authentication [commons-email]

2025-05-27 Thread via GitHub
sgoeschl opened a new pull request, #354: URL: https://github.com/apache/commons-email/pull/354 Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [X] Read the [con

[PR] Add StringUtils.truncateToByteLength [commons-lang]

2025-05-27 Thread via GitHub
kiddos opened a new pull request, #1392: URL: https://github.com/apache/commons-lang/pull/1392 We sometimes need to store Unicode text in a fixed space (e.g., in a database column of type `CHARACTER(32)`). It's acceptable for the text to be truncated, but because we're dealing with Unicode,

Re: [PR] Simplify API [commons-fileupload]

2025-05-27 Thread via GitHub
garydgregory commented on PR #309: URL: https://github.com/apache/commons-fileupload/pull/309#issuecomment-2912895990 I'll check in a couple of days when other higher priority tasks are done. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Simplify API [commons-fileupload]

2025-05-27 Thread via GitHub
basil commented on PR #309: URL: https://github.com/apache/commons-fileupload/pull/309#issuecomment-2912759195 @garydgregory Any update on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
garydgregory commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2108949495 ## src/main/java/org/apache/commons/lang3/ClassUtils.java: ## @@ -496,9 +496,14 @@ private static String getCanonicalName(final String name) { classN

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2108936359 ## src/main/java/org/apache/commons/lang3/ClassUtils.java: ## @@ -496,9 +496,14 @@ private static String getCanonicalName(final String name) { classN

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
garydgregory commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2108912452 ## src/main/java/org/apache/commons/lang3/ClassUtils.java: ## @@ -496,9 +496,14 @@ private static String getCanonicalName(final String name) { classN

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2108830909 ## src/test/java/org/apache/commons/lang3/ClassUtilsTest.java: ## @@ -237,6 +237,14 @@ public void test_getAllSuperclasses_Class() { assertNull(Class

Re: [PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
garydgregory commented on code in PR #1391: URL: https://github.com/apache/commons-lang/pull/1391#discussion_r2108794628 ## src/test/java/org/apache/commons/lang3/ClassUtilsTest.java: ## @@ -237,6 +237,14 @@ public void test_getAllSuperclasses_Class() { assertNull(Class

[PR] Fix LANG-1771: Handle malformed array input '[String' in getShortCanonicalName [commons-lang]

2025-05-27 Thread via GitHub
abhisripathi opened a new pull request, #1391: URL: https://github.com/apache/commons-lang/pull/1391 This PR fixes issue LANG-1771 where the input "[String" was incorrectly interpreted as "short[]" by the getShortCanonicalName method in ClassUtils. ✅ Root Cause: The internal descri

Re: [PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
abhisripathi closed pull request #1390: Add countUpperCaseLetters method to StringUtils with Javadoc and unit… URL: https://github.com/apache/commons-lang/pull/1390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
abhisripathi commented on PR #1390: URL: https://github.com/apache/commons-lang/pull/1390#issuecomment-2910688288 Thank you, Gary and Sebb, for the quick review and thoughtful feedback! I see your point — since countUpperCaseLetters is narrow in scope and similar functionality can be achi

Re: [PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
sebbASF commented on PR #1390: URL: https://github.com/apache/commons-lang/pull/1390#issuecomment-2909499664 Seems to me it would be more useful to classify all the letters in one pass, rather than counting upper case and then separately counting lower case, digits, punctuation etc.

Re: [PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
abhisripathi commented on PR #1390: URL: https://github.com/apache/commons-lang/pull/1390#issuecomment-2909401570 Thanks for the review! I submitted countUpperCaseLetters() as a complementary utility to isAllUpperCase(). While isAllUpperCase() checks for a boolean condition, countUpperCa

Re: [PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
garydgregory commented on PR #1390: URL: https://github.com/apache/commons-lang/pull/1390#issuecomment-2909370140 -1: I don't see how this is generally useful. Or am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Add countUpperCaseLetters method to StringUtils with Javadoc and unit… [commons-lang]

2025-05-26 Thread via GitHub
abhisripathi opened a new pull request, #1390: URL: https://github.com/apache/commons-lang/pull/1390 This pull request introduces a new utility method countUpperCaseLetters(CharSequence) in StringUtils. It returns the number of uppercase characters in the given input, or 0 if the input i

Re: [PR] [LANG-1772] Restrict size of cache to prevent overflow errors [commons-lang]

2025-05-24 Thread via GitHub
garydgregory merged PR #1379: URL: https://github.com/apache/commons-lang/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@c

Re: [PR] Bump org.apache.commons:commons-parent from 81 to 84 [commons-graph]

2025-05-23 Thread via GitHub
ppkarwasz merged PR #32: URL: https://github.com/apache/commons-graph/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons

Re: [PR] Bump org.apache.commons:commons-parent from 81 to 84 [commons-numbers]

2025-05-23 Thread via GitHub
ppkarwasz merged PR #169: URL: https://github.com/apache/commons-numbers/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@com

Re: [PR] Bump org.apache.commons:commons-parent from 81 to 84 [commons-geometry]

2025-05-23 Thread via GitHub
ppkarwasz merged PR #252: URL: https://github.com/apache/commons-geometry/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@co

Re: [PR] Bump org.apache.commons:commons-parent from 83 to 84 [commons-fileupload]

2025-05-23 Thread via GitHub
ppkarwasz merged PR #417: URL: https://github.com/apache/commons-fileupload/pull/417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] Fix for DAEMON-398 and corresponding tests. [commons-daemon]

2025-05-23 Thread via GitHub
jfclere merged PR #264: URL: https://github.com/apache/commons-daemon/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@common

Re: [PR] Bump org.apache.httpcomponents.client5:httpclient5 from 5.4.4 to 5.5 [commons-vfs]

2025-05-23 Thread via GitHub
garydgregory merged PR #690: URL: https://github.com/apache/commons-vfs/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@comm

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.24.0 [commons-parent]

2025-05-23 Thread via GitHub
garydgregory closed pull request #625: Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.24.0 URL: https://github.com/apache/commons-parent/pull/625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.24.0 [commons-parent]

2025-05-23 Thread via GitHub
garydgregory commented on PR #625: URL: https://github.com/apache/commons-parent/pull/625#issuecomment-2904209931 Closing: done in a profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump com.puppycrawl.tools:checkstyle from 9.3 to 10.24.0 [commons-parent]

2025-05-23 Thread via GitHub
garydgregory commented on PR #625: URL: https://github.com/apache/commons-parent/pull/625#issuecomment-2904208754 Closing: already done through a profile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Add camelCase utility method for converting strings to camelCase format [commons-lang]

2025-05-23 Thread via GitHub
garydgregory commented on PR #1389: URL: https://github.com/apache/commons-lang/pull/1389#issuecomment-2904007062 @dilip-4 Yes: Just look at the repository and its PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Add camelCase utility method for converting strings to camelCase format [commons-lang]

2025-05-23 Thread via GitHub
dilip-4 closed pull request #1389: Add camelCase utility method for converting strings to camelCase format URL: https://github.com/apache/commons-lang/pull/1389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add camelCase utility method for converting strings to camelCase format [commons-lang]

2025-05-23 Thread via GitHub
dilip-4 commented on PR #1389: URL: https://github.com/apache/commons-lang/pull/1389#issuecomment-2904014378 ok will check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add camelCase utility method for converting strings to camelCase format [commons-lang]

2025-05-23 Thread via GitHub
dilip-4 commented on PR #1389: URL: https://github.com/apache/commons-lang/pull/1389#issuecomment-2903991549 Thank you for the feedback! I wasn't aware that `CaseUtils` already included toCamelCase. I’ll take a look there. While reviewing the existing methods, I’d like to check: Ar

Re: [PR] Add camelCase utility method for converting strings to camelCase format [commons-lang]

2025-05-23 Thread via GitHub
garydgregory commented on PR #1389: URL: https://github.com/apache/commons-lang/pull/1389#issuecomment-2903952351 -1: These types of additions are best suited for Commons Text, which already has this kind of code in 'CaseUtils'. -- This is an automated message from the Apache Git Service.

Re: [PR] Bump github/codeql-action from 3.28.17 to 3.28.18 [commons-numbers]

2025-05-23 Thread via GitHub
garydgregory merged PR #168: URL: https://github.com/apache/commons-numbers/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

  1   2   3   4   5   6   7   8   9   10   >