[IPsec] Secdir last call review of draft-ietf-ipsecme-iptfs-12

2022-05-10 Thread Shawn Emery via Datatracker
Reviewer: Shawn Emery Review result: Has Nits I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG

Re: [IPsec] rfc 8750 question

2022-05-10 Thread Robert Moskowitz
On 5/10/22 01:37, Valery Smyslov wrote: Hi Bob, I just noticed that 8750 defines one algorithm number for aes-gcm: 30 | ENCR_AES_GCM_16_IIV| RFC 8750 But rfc 4106 defined 3: 18 for AES-GCM with an 8 octet ICV; 19 for AES-GCM with a 12 octet ICV; and 2

Re: [IPsec] rfc 8750 question

2022-05-10 Thread Paul Wouters
On May 10, 2022, at 07:59, Robert Moskowitz wrote: > >  > >> 20ENCR_AES_GCM_16 >> >> and what RFC 8750 defined: >> >> 30ENCR_AES_GCM_16_IIV >> >> The only difference is a suffix "_IIV". > > Actually, I thought that was the implicit IV size. And thus this was some > kind of AND con

Re: [IPsec] rfc 8750 question

2022-05-10 Thread Robert Moskowitz
On 5/10/22 08:25, Paul Wouters wrote: On May 10, 2022, at 07:59, Robert Moskowitz wrote:  20    ENCR_AES_GCM_16 and what RFC 8750 defined: 30    ENCR_AES_GCM_16_IIV The only difference is a suffix "_IIV". Actually, I thought that was the implicit IV size.  And thus this was some kin

Re: [IPsec] rfc 8750 question

2022-05-10 Thread Robert Moskowitz
On 5/10/22 08:25, Paul Wouters wrote: On May 10, 2022, at 07:59, Robert Moskowitz wrote:  20    ENCR_AES_GCM_16 and what RFC 8750 defined: 30    ENCR_AES_GCM_16_IIV The only difference is a suffix "_IIV". Actually, I thought that was the implicit IV size.  And thus this was some kin

Re: [IPsec] AD Review of draft-ietf-ipsecme-iptfs-12

2022-05-10 Thread Christian Hopps
Hi Roman, Thanks for the review! I've made some changes in the document to cover most of your suggestions and have a few comments/questions on the rest below. Roman Danyliw writes: Hi! I performed an AD review of draft-ietf-ipsecme-iptfs-12. Thank you for this work and the patience of th