Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-ikev2-auth-announce-06

2024-04-02 Thread Rifaat Shekh-Yusef
Hi Valery, Thanks for engaging with me on this. Your answers/suggestions below address all my comments and concerns. Regards, Rifaat On Mon, Apr 1, 2024 at 11:45 AM Valery Smyslov wrote: > Hi Rifaat, > > > > I snipped parts where we are in agreement. > > > > Hi Valery, > > > > See my replies

Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-ikev2-auth-announce-06

2024-04-01 Thread Valery Smyslov
Hi Rifaat, I snipped parts where we are in agreement. Hi Valery, See my replies below. Regards, Rifaat […] > * "Since the responder sends the SUPPORTED_AUTH_METHODS notification in > the IKE_SA_INIT exchange, it must take care that the size of the response > message wou

Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-ikev2-auth-announce-06

2024-04-01 Thread Rifaat Shekh-Yusef
Hi Valery, See my replies below. Regards, Rifaat On Mon, Apr 1, 2024 at 9:37 AM Valery Smyslov wrote: > Hi Rifaat, > > thank you for your review. Please, see inline. > > > Reviewer: Rifaat Shekh-Yusef > > Review result: Has Issues > > > > # Section 3.1 > > > > * The description of the exchan

Re: [IPsec] Secdir last call review of draft-ietf-ipsecme-ikev2-auth-announce-06

2024-04-01 Thread Valery Smyslov
Hi Rifaat, thank you for your review. Please, see inline. > Reviewer: Rifaat Shekh-Yusef > Review result: Has Issues > > # Section 3.1 > > * The description of the exchange seems odd, as it starts with the responder, > instead of the initiator. I suggest that the description of the exchange >