Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

2016-12-02 Thread Rafael J. Wysocki
On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi wrote: > Rafael, Mark, Suravee, > > On Mon, Nov 21, 2016 at 10:01:39AM +, Lorenzo Pieralisi wrote: >> On DT based systems, the of_dma_configure() API implements DMA >> configuration for a given device. On ACPI systems an API equivalent to >> of

Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

2016-12-04 Thread Rafael J. Wysocki
On Sat, Dec 3, 2016 at 11:39 AM, Lorenzo Pieralisi wrote: > On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: >> On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi >> wrote: >> > Rafael, Mark, Suravee, >> > >> > On Mon, Nov 21, 2016 at

Re: [PATCH] ACPI/IORT: Make dma masks set-up IORT specific

2016-12-05 Thread Rafael J. Wysocki
h configurations. > > Signed-off-by: Lorenzo Pieralisi > Cc: Will Deacon > Cc: Hanjun Guo > Cc: Bjorn Helgaas > Cc: Robin Murphy > Cc: Tomasz Nowicki > Cc: Joerg Roedel > Cc: "Rafael J. Wysocki" > Cc: Sricharan R Acked -by: Rafael J. Wysocki >

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Rafael J. Wysocki
On Sun, Dec 4, 2016 at 1:10 PM, Lukas Wunner wrote: > Silence this warning emitted by sphinx: > include/linux/device.h:938: warning: No description found for parameter > 'links' > > While at it, fix typos in comments of device links code. > > Cc: Rafael J. Wysocki

[PATCH] ACPI / DMAR: Avoid passing NULL to acpi_put_table()

2017-01-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Linus reported that commit 174cc7187e6f "ACPICA: Tables: Back port acpi_get_table_with_size() and early_acpi_os_unmap_memory() from Linux kernel" added a new warning on his desktop system: ACPI Warning: Table 9fe6c0a0, Validation count is zero before

Re: [PATCH V7 06/11] of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices

2017-01-29 Thread Rafael J. Wysocki
>| > really_probe >| > dma_configure > > Similarly on the device/driver_unregister path __device_release_driver is > called which inturn calls dma_deconfigure. > > This patch changes the dma ops configuration to probe time for > both OF and ACPI based

Re: [v5 1/4] ACPICA: IORT: Add Cavium ThunderX2 SMMUv3 model definition.

2017-05-10 Thread Rafael J. Wysocki
On Wednesday, May 10, 2017 05:01:55 PM Geetha sowjanya wrote: > From: Linu Cherian > > Add SMMUv3 model definition for ThunderX2. > > Signed-off-by: Linu Cherian > Signed-off-by: Geetha Sowjanya This is an ACPICA change, but you have not included the ACPICA maintainers into your original CC l

Re: [v5 1/4] ACPICA: IORT: Add Cavium ThunderX2 SMMUv3 model definition.

2017-05-11 Thread Rafael J. Wysocki
On Thursday, May 11, 2017 09:45:25 AM Will Deacon wrote: > On Thu, May 11, 2017 at 02:26:02AM +0200, Rafael J. Wysocki wrote: > > On Wednesday, May 10, 2017 05:01:55 PM Geetha sowjanya wrote: > > > From: Linu Cherian > > > > > > Add SMMUv3 model definition fo

Re: [PATCH v6 3/6] ACPI/IORT: Ignore all errors except EPROBE_DEFER

2017-05-27 Thread Rafael J. Wysocki
On Saturday, May 27, 2017 07:17:42 PM Sricharan R wrote: > While deferring the probe of IOMMU masters, xlate and > add_device callbacks called from iort_iommu_configure > can pass back error values like -ENODEV, which means > the IOMMU cannot be connected with that master for real > reasons. Before

Re: [PATCH v7 0/3] Cavium ThunderX2 SMMUv3 errata workarounds

2017-06-08 Thread Rafael J. Wysocki
On Thu, Jun 8, 2017 at 6:32 PM, Lorenzo Pieralisi wrote: > On Tue, May 30, 2017 at 05:33:38PM +0530, Geetha sowjanya wrote: >> Cavium ThunderX2 SMMUv3 implementation has two Silicon Erratas. >> 1. Errata ID #74 >>SMMU register alias Page 1 is not implemented >> 2. Errata ID #126 >>SMMU doe

Re: [Patch Part3 V1 17/22] pci, ACPI, iommu: enhance pci_root to support DMAR device hotplug

2014-04-22 Thread Rafael J. Wysocki
se); I suppose that works if dmar_device_hotplug() returned false before? > end: > kfree(root); > return result; > @@ -625,6 +635,8 @@ static void acpi_pci_root_remove(struct acpi_device > *device) > > pci_remove_root_bus(root->bus); > > + dm

Re: [PATCH 1/4] PCI / ACPI: Identify external PCI devices

2018-11-20 Thread Rafael J. Wysocki
, 2018 1:01 PM > > > To: Lorenzo Pieralisi > > > Cc: Lukas Wunner; iommu@lists.linux-foundation.org; Joerg Roedel; David > > > Woodhouse; Lu Baolu; Ashok Raj; Bjorn Helgaas; Rafael J. Wysocki; Jacob > > > jun Pan; > > > Andreas Noever; Michael Jamet; Yeh

Re: [PATCH v2 1/4] PCI / ACPI: Identify untrusted PCI devices

2018-11-27 Thread Rafael J. Wysocki
On Tue, Nov 27, 2018 at 9:54 AM Mika Westerberg wrote: > > On Mon, Nov 26, 2018 at 06:17:11PM -0600, Bjorn Helgaas wrote: > > Hi Mika, > > Hi, > > > On Mon, Nov 26, 2018 at 02:15:23PM +0300, Mika Westerberg wrote: > > > Recent systems with Thunderbolt ports may support IOMMU natively. > > > > This

Re: [PATCH v2 1/4] PCI / ACPI: Identify untrusted PCI devices

2018-11-27 Thread Rafael J. Wysocki
On Mon, Nov 26, 2018 at 12:15 PM Mika Westerberg wrote: > > Recent systems with Thunderbolt ports may support IOMMU natively. This > means that the platform utilizes IOMMU to prevent DMA attacks over > externally exposed PCIe root ports (typically Thunderbolt ports) > > The system BIOS marks these

Re: [PATCH v2 1/4] PCI / ACPI: Identify untrusted PCI devices

2018-11-28 Thread Rafael J. Wysocki
On Wed, Nov 28, 2018 at 11:54 AM Mika Westerberg wrote: > > On Tue, Nov 27, 2018 at 06:14:43PM +0100, Rafael J. Wysocki wrote: > > > diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c > > > index 8c7c4583b52d..4bdad32f62c8 100644 > > > --- a/drivers/ac

Re: [PATCH v3 1/4] PCI / ACPI: Identify untrusted PCI devices

2018-11-29 Thread Rafael J. Wysocki
ware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports > > Signed-off-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > drivers/acpi/property.c | 11 +++ > drivers/pci/pci-acpi.c | 19 +++ > drivers/pci/probe.c

Re: [PATCH 2/2] ACPI / scan: Refactor _CCA enforcement

2018-12-11 Thread Rafael J. Wysocki
lling dummy DMA ops instead of just skipping setup entirely. This > will then free up the dev->dma_ops == NULL case for some valuable > fastpath optimisations. > > CC: Rafael J. Wysocki > CC: Len Brown > CC: Greg Kroah-Hartman > CC: Bjorn Helgaas > Signed-off-by: Ro

Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release

2019-02-08 Thread Rafael J. Wysocki
out to be a red herring. > > On arm64, arch_teardown_dma_ops() resets dev->dma_ops to NULL. > Hence if a driver has used a managed DMA allocation API, the allocated > DMA memory will be freed using the direct DMA ops, while it may have > been allocated using a custom DMA ops

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-11 Thread Rafael J. Wysocki
nd devices as "parent" devices > to those other devices that needs them. Then runtime PM core would > take care of things for us, right!? > > Now, I am not so sure using the "parent" approach is actually viable, > since it will likely have other complications, but I ha

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-17 Thread Rafael J. Wysocki
; >> On Sat, Dec 13, 2014 at 5:47 AM, Laurent Pinchart wrote: > > >>> On Friday 12 December 2014 13:15:51 Tomasz Figa wrote: > > >>>> On Fri, Dec 12, 2014 at 5:48 AM, Rafael J. Wysocki wrote: > > >>>>> On Thursday, December 11, 2014

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-18 Thread Rafael J. Wysocki
e is only a > > subset, so I think we need a more generic solution. > > I agree that a more generic solution is needed at least to support ACPI _DEP, > but that might not be optimal in the IOMMU use case as explained above. Well, sinc

Re: [PATCH v3 0/6] ACPI / utils: add new helper for HID/UID match

2019-10-11 Thread Rafael J. Wysocki
On Tuesday, October 1, 2019 4:27:19 PM CEST Andy Shevchenko wrote: > There are few users outside of ACPI realm that re-introduce a custom > solution to match ACPI device against HID/UID. Add a generic helper for > them. > > The series is supposed to go via linux-pm tree. > > In v3: > - correct lo

Re: [PATCH 1/3] PM / Runtime: Add notifiers for device runtime PM events

2016-06-08 Thread Rafael J. Wysocki
On Wed, Jun 8, 2016 at 12:25 PM, Marek Szyprowski wrote: > From: Krzysztof Kozlowski > > Allow drivers registering for certain runtime PM events of other > devices. Some drivers in power domain are more or less coupled. When one > driver is suspending (thus leading to power domain being also turn

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-06-17 Thread Rafael J. Wysocki
On Fri, Jun 17, 2016 at 12:36 PM, Lukas Wunner wrote: > Hi Marek, > > On Fri, Jun 17, 2016 at 08:26:52AM +0200, Marek Szyprowski wrote: >> From: "Rafael J. Wysocki" >> >> Currently, there is a problem with handling cases where functional >> dependencies

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-07-19 Thread Rafael J. Wysocki
On Friday, June 17, 2016 04:07:38 PM Lukas Wunner wrote: > On Fri, Jun 17, 2016 at 02:54:56PM +0200, Rafael J. Wysocki wrote: > > On Fri, Jun 17, 2016 at 12:36 PM, Lukas Wunner wrote: > > > On Fri, Jun 17, 2016 at 08:26:52AM +0200, Marek Szyprowski wrote: > > >

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-07-20 Thread Rafael J. Wysocki
On Wednesday, July 20, 2016 08:24:50 AM Lukas Wunner wrote: > On Wed, Jul 20, 2016 at 02:33:18AM +0200, Rafael J. Wysocki wrote: > > On Friday, June 17, 2016 04:07:38 PM Lukas Wunner wrote: > > > On Fri, Jun 17, 2016 at 02:54:56PM +0200, Rafael J. Wysocki wrote: > > > &

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-07-20 Thread Rafael J. Wysocki
On Wednesday, July 20, 2016 05:23:40 PM Lukas Wunner wrote: > On Wed, Jul 20, 2016 at 02:52:42PM +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 20, 2016 08:24:50 AM Lukas Wunner wrote: > > > On Wed, Jul 20, 2016 at 02:33:18AM +0200, Rafael J. Wysocki wrote: > > >

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-07-20 Thread Rafael J. Wysocki
On Thursday, July 21, 2016 01:25:53 AM Lukas Wunner wrote: > On Thu, Jul 21, 2016 at 12:51:31AM +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 20, 2016 05:23:40 PM Lukas Wunner wrote: > > > On Wed, Jul 20, 2016 at 02:52:42PM +0200, Rafael J. Wysocki wrote: > > &

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-07-27 Thread Rafael J. Wysocki
On Monday, July 25, 2016 12:48:32 AM Lukas Wunner wrote: > On Thu, Jul 21, 2016 at 02:25:15AM +0200, Rafael J. Wysocki wrote: > > On Thursday, July 21, 2016 01:25:53 AM Lukas Wunner wrote: > > > On Thu, Jul 21, 2016 at 12:51:31AM +0200, Rafael J. Wysocki wrote: > > > &g

Re: [PATCH v2 06/10] driver core: Avoid endless recursion if device has more than one link

2016-09-06 Thread Rafael J. Wysocki
On Friday, June 17, 2016 08:26:56 AM Marek Szyprowski wrote: > This patch fixes endless recursion, which happends when device has > more than one link. > > Signed-off-by: Marek Szyprowski > --- > drivers/base/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/driv

Re: [PATCH v2 07/10] driver core: Add support for links to already probed drivers

2016-09-06 Thread Rafael J. Wysocki
On Friday, June 17, 2016 08:26:57 AM Marek Szyprowski wrote: > Set proper link state if link is created between already probed supplier > device and to be probed consumer device. > > Signed-off-by: Marek Szyprowski > --- > drivers/base/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deleti

Re: [PATCH v2 08/10] PM core: Fix restoring devices with links during system PM transition

2016-09-06 Thread Rafael J. Wysocki
On Friday, June 17, 2016 08:26:58 AM Marek Szyprowski wrote: > When devices are being runtime resumed during the system PM transition to > suspend state, the link suppliers might be already resumed and > have runtime pm disabled. This is normal case. This patch adds special > support for such case.

Re: [PATCH v2 02/10] driver core: Functional dependencies tracking support

2016-09-06 Thread Rafael J. Wysocki
On Thursday, July 28, 2016 05:28:31 PM Lukas Wunner wrote: > On Thu, Jul 28, 2016 at 02:30:31AM +0200, Rafael J. Wysocki wrote: > > On Monday, July 25, 2016 12:48:32 AM Lukas Wunner wrote: > > > On Thu, Jul 21, 2016 at 02:25:15AM +0200, Rafael J. Wysocki wrote: > > > &

Re: [PATCH v3 0/2] Exynos IOMMU: proper runtime PM support (use device dependencies)

2016-09-23 Thread Rafael J. Wysocki
On Tuesday, September 20, 2016 10:51:13 AM Marek Szyprowski wrote: > Hi All, > > On 2016-09-19 23:45, Tobias Jakobi wrote: > > I did some tests with the new version today. Sadly the reboot/shutdown > > issues are still present. > > Thanks for the report. I've managed to reproduce this issue and i

Re: [PATCH v3 0/2] Exynos IOMMU: proper runtime PM support (use device dependencies)

2016-09-23 Thread Rafael J. Wysocki
On Friday, September 23, 2016 03:50:02 PM Lukas Wunner wrote: > On Fri, Sep 23, 2016 at 02:49:20PM +0200, Rafael J. Wysocki wrote: > > On Tuesday, September 20, 2016 10:51:13 AM Marek Szyprowski wrote: > > > On 2016-09-19 23:45, Tobias Jakobi wrote: > > > > I did s

Re: [PATCH v3 0/2] Exynos IOMMU: proper runtime PM support (use device dependencies)

2016-09-26 Thread Rafael J. Wysocki
On Monday, September 26, 2016 10:15:24 AM Marek Szyprowski wrote: > Hi Rafael, > > > On 2016-09-24 03:25, Rafael J. Wysocki wrote: > > On Friday, September 23, 2016 03:50:02 PM Lukas Wunner wrote: > >> On Fri, Sep 23, 2016 at 02:49:20PM +0200, Rafael J. Wysocki wrote:

Re: [PATCH v5 01/14] drivers: iommu: add FWNODE_IOMMU fwnode type

2016-09-29 Thread Rafael J. Wysocki
> > This patch also implements a glue kernel layer that allows to > > allocate/free FWNODE_IOMMU fwnode_handle structures and associate > > them with IOMMU devices. > > > > Signed-off-by: Lorenzo Pieralisi > > Reviewed-by: Hanjun Guo > > Cc: Joerg Roedel &g

Re: [PATCH v5 01/14] drivers: iommu: add FWNODE_IOMMU fwnode type

2016-09-30 Thread Rafael J. Wysocki
On Fri, Sep 30, 2016 at 11:07 AM, Lorenzo Pieralisi wrote: > On Thu, Sep 29, 2016 at 10:59:40PM +0200, Rafael J. Wysocki wrote: >> On Thursday, September 29, 2016 03:15:20 PM Lorenzo Pieralisi wrote: >> > Hi Rafael, >> > >> > On Fri, Sep 09, 2016 at 03:23

Re: [PATCH v5 01/14] drivers: iommu: add FWNODE_IOMMU fwnode type

2016-10-13 Thread Rafael J. Wysocki
Hi, On Thu, Oct 13, 2016 at 6:32 PM, Lorenzo Pieralisi wrote: > Hi Rafael, > > On Fri, Sep 30, 2016 at 05:48:01PM +0200, Rafael J. Wysocki wrote: >> On Fri, Sep 30, 2016 at 11:07 AM, Lorenzo Pieralisi >> wrote: >> > On Thu, Sep 29, 2016 at 10:59:40PM +0200, Raf

Re: [PATCH v6 00/16] ACPI IORT ARM SMMU support

2016-10-27 Thread Rafael J. Wysocki
On Wed, Oct 26, 2016 at 1:04 PM, Lorenzo Pieralisi wrote: > Rafael, Joerg (and anyone else CC'ed), > > On Tue, Oct 18, 2016 at 05:03:58PM +0100, Lorenzo Pieralisi wrote: >> This patch series is v6 of a previous posting: >> >> https://lkml.org/lkml/2016/9/9/418 >> >> v5 -> v6 >> - Rebased aga

Re: [PATCH v7 00/16] ACPI IORT ARM SMMU support

2016-11-09 Thread Rafael J. Wysocki
Hi Lorenzo, On Wed, Nov 9, 2016 at 3:19 PM, Lorenzo Pieralisi wrote: > This patch series is v7 of a previous posting: > > https://lkml.org/lkml/2016/10/18/506 I don't see anything objectionable in this series. Please let me know which patches in particular to look at in detail. Thanks, Rafael

Re: [PATCH v7 01/16] drivers: acpi: add FWNODE_ACPI_STATIC fwnode type

2016-11-09 Thread Rafael J. Wysocki
odes and associate them with the > respective devices. > > Signed-off-by: Lorenzo Pieralisi > Reviewed-by: Hanjun Guo > Tested-by: Hanjun Guo > Tested-by: Tomasz Nowicki > Cc: "Rafael J. Wysocki" Acked-by: Rafael J. Wysocki Thanks! __

Re: [PATCH v6 7/7] iommu/exynos: Use device dependency links to control runtime pm

2016-11-09 Thread Rafael J. Wysocki
On Thu, Nov 10, 2016 at 12:31 AM, Luis R. Rodriguez wrote: > On Tue, Nov 08, 2016 at 02:29:24PM +0100, Marek Szyprowski wrote: >> This patch uses recently introduced device dependency links to track the >> runtime pm state of the master's device. The goal is to let SYSMMU >> controller device's ru

Re: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm

2016-11-09 Thread Rafael J. Wysocki
On Tue, Nov 8, 2016 at 4:30 PM, Lukas Wunner wrote: > On Tue, Nov 08, 2016 at 08:27:12AM +0100, Marek Szyprowski wrote: >> On 2016-11-07 22:47, Luis R. Rodriguez wrote: >> > Has there been any review of the existing similar solutions out there >> > such as the DRM / audio component framework? Woul

Re: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm

2016-11-09 Thread Rafael J. Wysocki
On Thu, Nov 10, 2016 at 12:55 AM, Luis R. Rodriguez wrote: > On Tue, Nov 08, 2016 at 04:30:44PM +0100, Lukas Wunner wrote: >> On Tue, Nov 08, 2016 at 08:27:12AM +0100, Marek Szyprowski wrote: >> > On 2016-11-07 22:47, Luis R. Rodriguez wrote: >> > > Has there been any review of the existing simila

Re: [PATCH v5 7/7] iommu/exynos: Use device dependency links to control runtime pm

2016-11-09 Thread Rafael J. Wysocki
On Thu, Nov 10, 2016 at 1:12 AM, Luis R. Rodriguez wrote: > On Thu, Nov 10, 2016 at 01:05:42AM +0100, Rafael J. Wysocki wrote: >> On Thu, Nov 10, 2016 at 12:55 AM, Luis R. Rodriguez >> wrote: >> > On Tue, Nov 08, 2016 at 04:30:44PM +0100, Lukas Wunner wrote: >> &g

Re: [PATCH v4 2/2] iommu/exynos: Add proper runtime pm support

2016-11-09 Thread Rafael J. Wysocki
On Wed, Nov 9, 2016 at 4:07 PM, Marek Szyprowski wrote: > Hi Luis, > > > On 2016-11-08 23:14, Luis R. Rodriguez wrote: >> >> On Mon, Oct 10, 2016 at 03:32:06PM +0200, Marek Szyprowski wrote: >>> >>> Hi Luis >>> >>> >>> On 2016-10-06 19:37, Luis R. Rodriguez wrote: On Thu, Sep 29, 2016 at

Re: [PATCH v7 00/16] ACPI IORT ARM SMMU support

2016-11-15 Thread Rafael J. Wysocki
On Tue, Nov 15, 2016 at 11:12 AM, Lorenzo Pieralisi wrote: > Hi Rafael, > > On Thu, Nov 10, 2016 at 12:36:12AM +0100, Rafael J. Wysocki wrote: >> Hi Lorenzo, >> >> On Wed, Nov 9, 2016 at 3:19 PM, Lorenzo Pieralisi >> wrote: >> > This patch series is

Re: [PATCH v7 07/16] drivers: acpi: implement acpi_dma_configure

2016-11-15 Thread Rafael J. Wysocki
rnel behaviour on them. > > Signed-off-by: Lorenzo Pieralisi > Acked-by: Bjorn Helgaas [pci] > Tested-by: Hanjun Guo > Tested-by: Tomasz Nowicki > Cc: Bjorn Helgaas > Cc: Robin Murphy > Cc: Tomasz Nowicki > Cc: Joerg Roedel > Cc: "Rafael J. Wysocki&quo

Re: [PATCH v7 16/16] drivers: acpi: iort: introduce iort_iommu_configure

2016-11-15 Thread Rafael J. Wysocki
ystems > and hook it up in the ACPI kernel layer that implements DMA > configuration for a device. > > Signed-off-by: Lorenzo Pieralisi > Tested-by: Hanjun Guo > Tested-by: Tomasz Nowicki > Cc: Hanjun Guo > Cc: Tomasz Nowicki > Cc: "Rafael J. W

Re: [PATCH v5 0/6] iommu/arm-smmu: Add runtime pm/sleep support

2018-01-09 Thread Rafael J. Wysocki
On Tuesday, January 9, 2018 11:01:43 AM CET Vivek Gautam wrote: > This series provides the support for turning on the arm-smmu's > clocks/power domains using runtime pm. This is done using the > recently introduced device links patches, which lets the smmu's > runtime to follow the master's runtime

Re: [PATCH v5 1/6] base: power: runtime: Export pm_runtime_get/put_suppliers

2018-01-11 Thread Rafael J. Wysocki
ead [1] about > ARM-SMMU runtime pm, we don't want to introduce runtime pm calls > in atomic path in arm_smmu_unmap. > > [1] https://patchwork.kernel.org/patch/9827825/ > > Signed-off-by: Vivek Gautam Acked-by: Rafael J. Wysocki Please feel free to route this along with the r

Re: [PATCH v9 1/5] driver core: Find an existing link between two devices

2018-03-13 Thread Rafael J. Wysocki
. > So, add a new APIs, device_link_find(), to find an existing > device link between two devices - suppliers and consumers. > > Signed-off-by: Vivek Gautam > Cc: Rafael J. Wysocki > Cc: Greg Kroah-Hartman > --- > > * New patch added to th

Re: [PATCH v9 1/5] driver core: Find an existing link between two devices

2018-03-14 Thread Rafael J. Wysocki
On Tuesday, March 13, 2018 12:23:34 PM CET Tomasz Figa wrote: > On Tue, Mar 13, 2018 at 7:34 PM, Vivek Gautam > wrote: > > Hi Tomasz, > > > > On Tue, Mar 13, 2018 at 3:45 PM, Tomasz Figa wrote: > >> Hi Vivek, > >> > >> Thanks for the patch. > >> > >> On Tue, Mar 13, 2018 at 5:55 PM, Vivek Gautam

Re: [PATCH v9 1/5] driver core: Find an existing link between two devices

2018-03-14 Thread Rafael J. Wysocki
On Wednesday, March 14, 2018 12:50:54 PM CET Tomasz Figa wrote: > On Wed, Mar 14, 2018 at 8:12 PM, Rafael J. Wysocki wrote: > > On Tuesday, March 13, 2018 12:23:34 PM CET Tomasz Figa wrote: > >> On Tue, Mar 13, 2018 at 7:34 PM, Vivek Gautam > >> wrote: > >> &g

Re: [PATCH v2] driver: core: Allow subsystems to continue deferring probe

2019-06-14 Thread Rafael J. Wysocki
On Thu, Jun 13, 2019 at 7:00 PM Thierry Reding wrote: > > From: Thierry Reding > > Some subsystems, such as pinctrl, allow continuing to defer probe > indefinitely. This is useful for devices that depend on resources > provided by devices that are only probed after the init stage. > > One example

Re: [PATCH v2] driver: core: Allow subsystems to continue deferring probe

2019-06-14 Thread Rafael J. Wysocki
On Fri, Jun 14, 2019 at 11:39 AM Thierry Reding wrote: > > On Fri, Jun 14, 2019 at 11:10:58AM +0200, Greg Kroah-Hartman wrote: > > On Thu, Jun 13, 2019 at 07:00:11PM +0200, Thierry Reding wrote: > > > From: Thierry Reding > > > [cut] > > To avoid further back and forth, what exactly is it that

Re: [PATCH v2 5/7] driver core: Add device location to "struct device" and expose it in sysfs

2020-06-30 Thread Rafael J. Wysocki
On Tue, Jun 30, 2020 at 2:52 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 30, 2020 at 01:49:48PM +0300, Heikki Krogerus wrote: > > On Mon, Jun 29, 2020 at 09:49:41PM -0700, Rajat Jain wrote: > > > Add a new (optional) field to denote the physical location of a device > > > in the system, and expos

Re: [PATCH v2 5/7] driver core: Add device location to "struct device" and expose it in sysfs

2020-06-30 Thread Rafael J. Wysocki
On Tue, Jun 30, 2020 at 5:38 PM Greg Kroah-Hartman wrote: > > On Tue, Jun 30, 2020 at 03:00:34PM +0200, Rafael J. Wysocki wrote: > > On Tue, Jun 30, 2020 at 2:52 PM Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Jun 30, 2020 at 01:49:48PM +0300, Heikki Kr

Re: [PATCH v2 05/12] ACPI/IORT: Add an input ID to acpi_dma_configure()

2020-07-28 Thread Rafael J. Wysocki
ditional ID parameter to acpi_dma_configure() > > > > representing the child devices input ID. This ID is bus specific > > > > and it is retrieved in bus specific code. > > > > > > > > By adding an ID parameter to acpi_dma_configure(), the IORT > >

Re: [PATCH v4 1/2] PCI: Rename "pci_dev->untrusted" to "pci_dev->poses_dma_risk"

2022-03-22 Thread Rafael J. Wysocki
On Tue, Mar 22, 2022 at 10:02 AM Christoph Hellwig wrote: > > On Sat, Mar 19, 2022 at 11:29:05PM -0700, Rajat Jain wrote: > > Rename the field to make it more clear, that the device can execute DMA > > attacks on the system, and thus the system may need protection from > > such attacks from this d

Re: [PATCH v5 1/2] PCI: ACPI: Support Microsoft's "DmaProperty"

2022-04-05 Thread Rafael J. Wysocki
g. internal network devices). > > Signed-off-by: Rajat Jain > Reviewed-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > v5: * Reorder the patches in the series > v4: * Add the GUID. > * Update the comment and commitlog. > v3: * Use Microsoft's docume

Re: [PATCH v5 2/2] PCI: Rename pci_dev->untrusted to pci_dev->untrusted_dma

2022-04-05 Thread Rafael J. Wysocki
igned-off-by: Rajat Jain > Reviewed-by: Mika Westerberg Acked-by: Rafael J. Wysocki > --- > v5: Use "untrusted_dma" as property name, based on feedback. > Reorder the patches in the series. > v4: Initial version, created based on comments on other patch > >

Re: [PATCH v2 2/2] of: base: Avoid console probe delay when fw_devlink.strict=1

2022-06-23 Thread Rafael J. Wysocki
On Thu, Jun 23, 2022 at 6:39 PM Andy Shevchenko wrote: > > On Thu, Jun 23, 2022 at 12:04:21PM +0200, sascha hauer wrote: > > On Thu, Jun 23, 2022 at 01:03:43AM -0700, Saravana Kannan wrote: > > ... > > > I wonder if it wouldn't be a better approach to just probe all devices > > and record the devi

Re: [PATCH v2 3/6] ACPI: Add driver for the VIOT table

2021-05-21 Thread Rafael J. Wysocki
On Fri, Apr 23, 2021 at 1:57 PM Jean-Philippe Brucker wrote: > > The ACPI Virtual I/O Translation Table describes topology of > para-virtual platforms, similarly to vendor tables DMAR, IVRS and IORT. > For now it describes the relation between virtio-iommu and the endpoints > it manages. > > Three

Re: [PATCH v2 2/6] ACPI: Move IOMMU setup code out of IORT

2021-05-21 Thread Rafael J. Wysocki
On Fri, Apr 23, 2021 at 1:57 PM Jean-Philippe Brucker wrote: > > Some of the IOMMU setup code in IORT is fairly generic and can be reused > by VIOT. Extract it from IORT. Except that iort_iommu_configure_id() is not really generic AFAICS. ___ iommu mail

Re: [PATCH v4 3/6] ACPI: Add driver for the VIOT table

2021-06-17 Thread Rafael J. Wysocki
On Thu, Jun 10, 2021 at 10:03 AM Jean-Philippe Brucker wrote: > > The ACPI Virtual I/O Translation Table describes topology of > para-virtual platforms, similarly to vendor tables DMAR, IVRS and IORT. > For now it describes the relation between virtio-iommu and the endpoints > it manages. > > Thre

Re: [PATCH v5 3/5] ACPI: Add driver for the VIOT table

2021-06-18 Thread Rafael J. Wysocki
Eric Auger > Signed-off-by: Jean-Philippe Brucker >From the general ACPI perspective Acked-by: Rafael J. Wysocki and I'm assuming that it will be routed through a different tree. > --- > drivers/acpi/Kconfig | 3 + > drivers/iommu/Kconfig | 1 + > drivers/

[PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()

2022-02-01 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Replace acpi_bus_get_device() that is going to be dropped with acpi_fetch_acpi_dev(). No intentional functional impact. Signed-off-by: Rafael J. Wysocki --- drivers/iommu/intel/dmar.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: linux-pm/drivers

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-11 Thread Rafael J. Wysocki
On Sunday, July 8, 2018 7:34:10 PM CEST Vivek Gautam wrote: > From: Sricharan R > > The smmu needs to be functional only when the respective > master's using it are active. The device_link feature > helps to track such functional dependencies, so that the > iommu gets powered when the master devi

Re: [PATCH v12 2/4] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-07-11 Thread Rafael J. Wysocki
On Sunday, July 8, 2018 7:34:11 PM CEST Vivek Gautam wrote: > From: Sricharan R > > The smmu device probe/remove and add/remove master device callbacks > gets called when the smmu is not linked to its master, that is without > the context of the master device. So calling runtime apis in those pla

Re: [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu

2018-07-11 Thread Rafael J. Wysocki
s > called once when the master is added to the smmu. > > Signed-off-by: Sricharan R > Signed-off-by: Vivek Gautam > Reviewed-by: Tomasz Figa > Cc: Rafael J. Wysocki > Cc: Lukas Wunner > --- > > - Change since v11 >* Replaced DL_FLAG_AUTOREMOVE flag with DL_F

Re: [PATCH v12 2/4] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device

2018-07-11 Thread Rafael J. Wysocki
On Wed, Jul 11, 2018 at 12:05 PM, Tomasz Figa wrote: > Hi Rafael, > > Thanks for review. > > On Wed, Jul 11, 2018 at 6:53 PM Rafael J. Wysocki wrote: >> >> On Sunday, July 8, 2018 7:34:11 PM CEST Vivek Gautam wrote: >> > From: Sricharan R >> > >

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-11 Thread Rafael J. Wysocki
On Wed, Jul 11, 2018 at 12:55 PM, Vivek Gautam wrote: > Hi Rafael, > > > On Wed, Jul 11, 2018 at 3:20 PM, Rafael J. Wysocki wrote: >> On Sunday, July 8, 2018 7:34:10 PM CEST Vivek Gautam wrote: >>> From: Sricharan R >>> >>> The smmu needs to be fun

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-11 Thread Rafael J. Wysocki
On Wed, Jul 11, 2018 at 3:40 PM, Marek Szyprowski wrote: > Hi Tomasz, > > On 2018-07-11 14:51, Tomasz Figa wrote: >> On Wed, Jul 11, 2018 at 8:11 PM Rafael J. Wysocki wrote: >>> On Wed, Jul 11, 2018 at 12:55 PM, Vivek Gautam >>> wrote: >>>> On We

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-16 Thread Rafael J. Wysocki
On Thu, Jul 12, 2018 at 12:57 PM, Vivek Gautam wrote: > Hi, > > > On Wed, Jul 11, 2018 at 6:21 PM, Tomasz Figa wrote: >> On Wed, Jul 11, 2018 at 8:11 PM Rafael J. Wysocki wrote: >>> >>> On Wed, Jul 11, 2018 at 12:55 PM, Vivek Gautam >>> wrote: >

Re: [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu

2018-07-16 Thread Rafael J. Wysocki
On Thu, Jul 12, 2018 at 2:41 PM, Vivek Gautam wrote: > Hi Rafael, > > > On Wed, Jul 11, 2018 at 4:06 PM, Vivek Gautam > wrote: >> Hi Rafael, >> >> >> >> On 7/11/2018 3:23 PM, Rafael J. Wysocki wrote: >>> >>> On Sunday, July 8, 2018

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-16 Thread Rafael J. Wysocki
Hi, On Mon, Jul 16, 2018 at 12:11 PM, Vivek Gautam wrote: > HI Rafael, > > > > On 7/16/2018 2:21 PM, Rafael J. Wysocki wrote: >> >> On Thu, Jul 12, 2018 at 12:57 PM, Vivek Gautam >> wrote: [cut] >>>> Although, given the PM >>>> subsys

Re: [PATCH v12 3/4] iommu/arm-smmu: Add the device_link between masters and smmu

2018-07-17 Thread Rafael J. Wysocki
On Mon, Jul 16, 2018 at 1:46 PM, Vivek Gautam wrote: > > > On 7/16/2018 2:25 PM, Rafael J. Wysocki wrote: >> >> On Thu, Jul 12, 2018 at 2:41 PM, Vivek Gautam >> wrote: >>> >>> Hi Rafael, >>> >>> >>> On We

Re: [PATCH v12 1/4] iommu/arm-smmu: Add pm_runtime/sleep ops

2018-07-23 Thread Rafael J. Wysocki
On Mon, Jul 23, 2018 at 7:59 AM, Marek Szyprowski wrote: > Hi Rafael, > > On 2018-07-11 22:36, Rafael J. Wysocki wrote: >> On Wed, Jul 11, 2018 at 3:40 PM, Marek Szyprowski >> wrote: [cut] >>> Frankly, if there are no other reasons I suggest to wir

Re: [PATCH v2 4/7] DMA-API: Add dma_(un)map_resource() documentation

2015-07-09 Thread Rafael J. Wysocki
On 7/8/2015 5:11 PM, Bjorn Helgaas wrote: [+cc Rafael] On Tue, Jul 07, 2015 at 01:14:27PM -0400, Mark Hounschell wrote: On 07/07/2015 11:15 AM, Bjorn Helgaas wrote: On Wed, May 20, 2015 at 08:11:17AM -0400, Mark Hounschell wrote: Most currently available hardware doesn't allow reads but will

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
ode needs to be robust for such a case. > > Fix that by passing a local variable to debugfs_create_bool() and > assigning its value to global_lock later. > > Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki Greg, please take this one if the [2/2] looks good to you. &

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 10:18:13 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 09:41:37 AM Viresh Kumar wrote: > > global_lock is defined as an unsigned long and accessing only its lower > > 32 bits from sysfs is incorrect, as we need to consider other 32 b

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > On 25-09-15, 20:49, Johannes Berg wrote: > > Ok, then, but that means Rafael is completely wrong ... > > debugfs_create_bool() takes a *pointer* and it needs to be long-lived, > > it can't be on the stack. You also don't get a call whe

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 10:26:22 PM Rafael J. Wysocki wrote: > On Friday, September 25, 2015 11:52:56 AM Viresh Kumar wrote: > > On 25-09-15, 20:49, Johannes Berg wrote: > > > Ok, then, but that means Rafael is completely wrong ... > > > debugfs_create_bool() tak

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > On 25 September 2015 at 13:33, Rafael J. Wysocki wrote: > > You're going to change that into bool in the next patch, right? > > Yeah. > > > So what if bool is a byte and the field is not word-aligned &

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-25 Thread Rafael J. Wysocki
On Fri, Sep 25, 2015 at 11:44 PM, Viresh Kumar wrote: > On 25-09-15, 22:58, Rafael J. Wysocki wrote: >> Say you have three adjacent fields in a structure, x, y, z, each one byte >> long. >> Initially, all of them are equal to 0. >> >> CPU A writes 1 to x and CPU

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
On Saturday, September 26, 2015 12:52:08 PM James Bottomley wrote: > On Fri, 2015-09-25 at 22:58 +0200, Rafael J. Wysocki wrote: > > On Friday, September 25, 2015 01:25:49 PM Viresh Kumar wrote: > > > On 25 September 2015 at 13:33, Rafael J. Wysocki > > > wrote: >

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > On 25 September 2015 at 15:19, Rafael J. Wysocki wrote: > > > So if you allow something like debugfs to update your structure, how > > > do

Re: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-27 Thread Rafael J. Wysocki
needs to be robust for such a case. > > Fix that by changing type of 'global_lock' to u32. > > Signed-off-by: Viresh Kumar Acked-by: Rafael J. Wysocki Greg, please take this one along with the [2/2] if that one looks good to you. > --- > BCC'd a lot of people (

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Rafael J. Wysocki
On Monday, September 28, 2015 10:24:58 AM Arnd Bergmann wrote: > On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > >

Re: [PATCH v2] ACPI: VIOT: Fix ACS setup

2022-07-05 Thread Rafael J. Wysocki
On Thu, Jun 30, 2022 at 11:59 AM Jean-Philippe Brucker wrote: > > On Thu, Jun 30, 2022 at 11:40:59AM +0200, Eric Auger wrote: > > Currently acpi_viot_init() gets called after the pci > > device has been scanned and pci_enable_acs() has been called. > > So pci_request_acs() fails to be taken into a