possible dmar_init_reserved_ranges() error

2016-12-19 Thread Bjorn Helgaas
Hi guys, I have some questions about dmar_init_reserved_ranges(). On systems where CPU physical address space is not identity-mapped to PCI bus address space, e.g., where the PCI host bridge windows have _TRA offsets, I'm not sure we're doing the right thing. Assume we have a PCI host bridge wit

Re: possible dmar_init_reserved_ranges() error

2016-12-22 Thread Bjorn Helgaas
On Thu, Dec 22, 2016 at 05:27:14PM +0100, Joerg Roedel wrote: > Hi Bjorn, > > On Mon, Dec 19, 2016 at 03:20:44PM -0600, Bjorn Helgaas wrote: > > I have some questions about dmar_init_reserved_ranges(). On systems > > where CPU physical address space is not identity-mapped t

Re: possible dmar_init_reserved_ranges() error

2016-12-22 Thread Bjorn Helgaas
Hi Ashok, On Thu, Dec 22, 2016 at 03:45:08PM -0800, Raj, Ashok wrote: > Hi Bjorn > > None in the platform group say they know about this. So i'm fairly sure > we don't do that on Intel hardware (x86). I'm pretty sure there was once an x86 prototype for which PCI bus addresses were not identical

Re: possible dmar_init_reserved_ranges() error

2016-12-27 Thread Bjorn Helgaas
On Mon, Dec 19, 2016 at 03:20:44PM -0600, Bjorn Helgaas wrote: > Hi guys, > > I have some questions about dmar_init_reserved_ranges(). On systems > where CPU physical address space is not identity-mapped to PCI bus > address space, e.g., where the PCI host bridge windows have _TRA

Re: [PATCH V7 07/11] iommu: of: Handle IOMMU lookup failure with deferred probing or error

2017-01-28 Thread Bjorn Helgaas
On Mon, Jan 23, 2017 at 09:48:09PM +0530, Sricharan R wrote: > From: Laurent Pinchart > > Failures to look up an IOMMU when parsing the DT iommus property need to > be handled separately from the .of_xlate() failures to support deferred > probing. > > The lack of a registered IOMMU can be caused

Re: [PATCH V7 09/11] arm64: dma-mapping: Remove the notifier trick to handle early setting of dma_ops

2017-01-28 Thread Bjorn Helgaas
On Mon, Jan 23, 2017 at 09:48:11PM +0530, Sricharan R wrote: > With arch_setup_dma_ops now being called late during device's probe after > the device's iommu is probed, the notifier trick required to handle the > early setup of dma_ops before the iommu group gets created is not > required. So remov

Re: [PATCH V7 10/11] iommu/arm-smmu: Clean up early-probing workarounds

2017-01-28 Thread Bjorn Helgaas
On Mon, Jan 23, 2017 at 09:48:12PM +0530, Sricharan R wrote: > From: Robin Murphy > > Now that the appropriate ordering is enforced via profe-deferral of s/profe-deferral/probe-deferral/ > masters in core code, rip it all out and bask in the simplicity. > > Acked-by: Will Deacon > Signed-off-

Re: [PATCH V7 06/11] of/acpi: Configure dma operations at probe time for platform/amba/pci bus devices

2017-01-28 Thread Bjorn Helgaas
CPI based platform/amba/pci bus devices. > > Signed-off-by: Sricharan R Acked-by: Bjorn Helgaas (drivers/pci part) > --- > [V6 .. V7] > * Updated the subject and commit log as per comments > > [V5 .. V6] > * Squashed in patch 10 for configuring the dm

Re: [PATCH V7 00/11] IOMMU probe deferral support

2017-01-28 Thread Bjorn Helgaas
On Mon, Jan 23, 2017 at 09:48:02PM +0530, Sricharan R wrote: > This series calls the dma ops configuration for the devices > at a generic place so that it works for all busses. > The dma_configure_ops for a device is now called during > the device_attach callback just before the probe of the > bus/

Re: Partial BAR Address Allocation

2017-02-22 Thread Bjorn Helgaas
[+cc Joerg, iommu list] On Wed, Feb 22, 2017 at 03:44:53PM -0500, Sinan Kaya wrote: > On 2/22/2017 1:44 PM, Bjorn Helgaas wrote: > > There is no way for a driver to say "I only need this memory BAR and > > not the other ones." The reason is because the PCI_COMMAND_ME

Re: [RFC PATCH 03/30] PCI: Move ATS declarations outside of CONFIG_PCI

2017-03-03 Thread Bjorn Helgaas
rm_smmu_enable_ats() ("[RFC PATCH 04/30] iommu/arm-smmu-v3: Add support for PCI ATS"), right? If you remove the #ifdef, we'll call pci_enable_ats(), and it will fail if !pdev->ats_cap. Acked-by: Bjorn Helgaas > --- > include/linux/pci.h | 26 +--

Re: [RFC PATCH 18/30] PCI: Make "PRG Response PASID Required" handling common

2017-03-03 Thread Bjorn Helgaas
from amd_iommu into the PCI subsystem, > renaming it to something more consistent with the spec, and introducing > another obscure acronym to make it all fit. Maybe mention the acronym itelf and spell it out here? > Signed-off-by: Jean-Philippe Brucker Acked-by: Bjorn Helgaas

Re: [RFC PATCH 19/30] PCI: Cache PRI and PASID bits in pci_dev

2017-03-03 Thread Bjorn Helgaas
e for ATS. > > Signed-off-by: Jean-Philippe Brucker Acked-by: Bjorn Helgaas > --- > drivers/pci/ats.c | 23 +++ > include/linux/pci.h | 2 ++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c > index 331376e9bb8b.

Re: Partial BAR Address Allocation

2017-03-10 Thread Bjorn Helgaas
On Mon, Mar 06, 2017 at 12:04:39PM +0100, Joerg Roedel wrote: > On Wed, Feb 22, 2017 at 05:39:44PM -0600, Bjorn Helgaas wrote: > > [+cc Joerg, iommu list] > > > > On Wed, Feb 22, 2017 at 03:44:53PM -0500, Sinan Kaya wrote: > > > On 2/22/2017 1:44 PM, Bjorn Helgaas

Re: [PATCH v4 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-10 Thread Bjorn Helgaas
Hi Jayachandran, On Mon, Apr 03, 2017 at 01:15:04PM +, Jayachandran C wrote: > The Cavium ThunderX2 arm64 SoCs (called Broadcom Vulcan earlier), the PCI > topology is slightly unusual. For a multi-node system, it looks like: > > [node level PCI bridges - one per node] > [SoC PCI devices w

Re: [PATCH v4 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-11 Thread Bjorn Helgaas
[+cc Joerg] On Tue, Apr 11, 2017 at 07:10:48AM +, Jayachandran C wrote: > On Mon, Apr 10, 2017 at 08:28:47PM -0500, Bjorn Helgaas wrote: > > Hi Jayachandran, > > > > On Mon, Apr 03, 2017 at 01:15:04PM +, Jayachandran C wrote: > > > The Cavium ThunderX2 arm6

Re: [PATCH v4 0/2] Handle Cavium ThunderX2 PCI topology quirk

2017-04-11 Thread Bjorn Helgaas
[+cc David] I forgot to mention that I'm also hoping for an ack from David, since he's listed as the maintainer of the ThunderX drivers. On Mon, Apr 03, 2017 at 01:15:02PM +, Jayachandran C wrote: > Hi Bjorn, Alex, > > Sending this again (with a trivial fix to author name), please review. >

Re: [PATCH v4 0/2] Handle Cavium ThunderX2 PCI topology quirk

2017-04-11 Thread Bjorn Helgaas
On Apr 11, 2017 8:48 AM, "Bjorn Helgaas" wrote: [+cc David] I forgot to mention that I'm also hoping for an ack from David, since he's listed as the maintainer of the ThunderX drivers. Never mind this, Jon pointed out that ThunderX2 is different than ThunderX. Sorry for t

Re: [PATCH v4 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-12 Thread Bjorn Helgaas
On Tue, Apr 11, 2017 at 03:27:02PM +, Jayachandran C wrote: > On Tue, Apr 11, 2017 at 08:41:25AM -0500, Bjorn Helgaas wrote: > > [+cc Joerg] > > > > On Tue, Apr 11, 2017 at 07:10:48AM +, Jayachandran C wrote: > > > On Mon, Apr 10, 2017 at 08:28:47PM -0500, B

Re: [PATCH v4 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-12 Thread Bjorn Helgaas
On Wed, Apr 12, 2017 at 06:10:34PM +, Jayachandran C wrote: > On Wed, Apr 12, 2017 at 11:21:18AM -0500, Bjorn Helgaas wrote: > > On Tue, Apr 11, 2017 at 03:27:02PM +, Jayachandran C wrote: > > > On Tue, Apr 11, 2017 at 08:41:25AM -0500, Bjorn Helgaas wrote:

Re: [PATCH v4 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-12 Thread Bjorn Helgaas
On Wed, Apr 12, 2017 at 08:41:20PM +, Jayachandran C wrote: > On Wed, Apr 12, 2017 at 02:11:38PM -0500, Bjorn Helgaas wrote: > > On Wed, Apr 12, 2017 at 06:10:34PM +, Jayachandran C wrote: > > > On Wed, Apr 12, 2017 at 11:21:18AM -0500, Bjorn Helgaas wrote: > > >

Re: [PATCH v5 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-13 Thread Bjorn Helgaas
I tentatively applied both patches to pci/host-thunder for v4.12. However, I am concerned about the topology here: On Thu, Apr 13, 2017 at 08:30:45PM +, Jayachandran C wrote: > On Cavium ThunderX2 arm64 SoCs (called Broadcom Vulcan earlier), the > PCI topology is slightly unusual. For a mult

Re: [PATCH v5 2/2] PCI: quirks: Fix ThunderX2 dma alias handling

2017-04-21 Thread Bjorn Helgaas
On Fri, Apr 21, 2017 at 05:05:41PM +, Jayachandran C wrote: > On Fri, Apr 21, 2017 at 10:48:15AM -0500, Bjorn Helgaas wrote: > > On Mon, Apr 17, 2017 at 12:47 PM, Jayachandran C > > wrote: > > > On Fri, Apr 14, 2017 at 09:00:06PM -0500, Bjorn Helgaas wrote: > &g

Re: [PATCH 1/3] iommu: of: Fix check for returning EPROBE_DEFER

2017-05-17 Thread Bjorn Helgaas
On Wed, May 17, 2017 at 05:00:07PM +0530, Sricharan R wrote: > Now with iommu probe deferral, we return -EPROBE_DEFER > for master's that are connected to an iommu which is not s/master's/masters/ s/iommu/IOMMU/ in your English text (changelogs and comments). That seems to be the convention, bas

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-17 Thread Bjorn Helgaas
On Tue, May 16, 2017 at 10:52:05AM +0530, Oza Pawandeep wrote: > current device framework and OF framework integration assumes s/current/The current/ > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure

Re: [PATCH v6 2/3] iommu/pci: reserve IOVA for PCI masters

2017-05-17 Thread Bjorn Helgaas
On Tue, May 16, 2017 at 10:52:06AM +0530, Oza Pawandeep wrote: > this patch reserves the IOVA for PCI masters. > ARM64 based SOCs may have scattered memory banks. > such as iproc based SOC has > > <0x 0x8000 0x0 0x8000>, /* 2G @ 2G */ > <0x0008 0x8000 0x3 0x8000>, /* 14

Re: [PATCH 1/2] PCI: Save properties required to handle FLR for replay purposes.

2017-05-23 Thread Bjorn Helgaas
On Wed, May 10, 2017 at 11:39:02AM -0700, Ashok Raj wrote: > From: CQ Tang > > Requires: https://patchwork.kernel.org/patch/9593891 I'm not sure what the status of the patch above is. I acked it, but it's part of a 30-patch IOMMU series, so I expect it to be merged via an IOMMU tree. In any ca

Re: [PATCH 1/2] PCI: Save properties required to handle FLR for replay purposes.

2017-05-24 Thread Bjorn Helgaas
On Tue, May 23, 2017 at 03:33:22PM -0500, Bjorn Helgaas wrote: > On Wed, May 10, 2017 at 11:39:02AM -0700, Ashok Raj wrote: > > From: CQ Tang > > > > Requires: https://patchwork.kernel.org/patch/9593891 > > I'm not sure what the status of the patch above is. I a

Re: [PATCH 2/2] PCI: Save properties required to handle FLR for replay purposes.

2017-05-30 Thread Bjorn Helgaas
ored. This patch saves PASID features > and PRI reqs cached. > > To: Bjorn Helgaas > To: Joerg Roedel > To: linux-...@vger.kernel.org > To: linux-ker...@vger.kernel.org > Cc: Jean-Phillipe Brucker > Cc: David Woodhouse > Cc: iommu@lists.linux-foundation.org >

Re: [PATCH 2/2] PCI: Save properties required to handle FLR for replay purposes.

2017-05-30 Thread Bjorn Helgaas
On Tue, May 30, 2017 at 09:25:49AM -0700, Ashok Raj wrote: > From: CQ Tang > > Requires: https://patchwork.kernel.org/patch/9593891 > > > After a FLR, pci-states need to be restored. This patch saves PASID features > and PRI reqs cached. > > To: Bjorn Helgaas >

Re: [PATCH 0/2] Save and restore pci properties to support FLR

2017-05-30 Thread Bjorn Helgaas
On Tue, May 30, 2017 at 09:25:47AM -0700, Ashok Raj wrote: > Resending Jean's patch so it can be included earlier than his large > SVM commits. Original patch https://patchwork.kernel.org/patch/9593891 > was ack'ed by Bjorn. Let's commit these separately since we need > functionality earlier. > >

Re: PCI warning on boot 3.8.0-rc1

2013-01-30 Thread Bjorn Helgaas
On Wed, Jan 16, 2013 at 3:38 PM, Stephen Hemminger wrote: > I see this on boot in dmesg > > [0.574494] DMAR: No ATSR found > [0.574549] IOMMU 0 0xfed9: using Queued invalidation > [0.574550] IOMMU 1 0xfed91000: using Queued invalidation > [0.574554] IOMMU: Setting RMRR: > [

Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-02-20 Thread Bjorn Helgaas
On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan wrote: > pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however, > it doesn't have interfaces to return PCI bus and PCI device id. Drivers > (AMD IOMMU, and AER) implement module specific definitions for PCI_BUS() > and AMD_IOMMU driver

Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-02-25 Thread Bjorn Helgaas
On Mon, Feb 25, 2013 at 9:37 AM, Shuah Khan wrote: > On Wed, 2013-02-20 at 18:19 -0700, Bjorn Helgaas wrote: >> On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan wrote: >> > pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however, >> > it doesn't have

Re: [PATCH 1/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-02-25 Thread Bjorn Helgaas
On Mon, Feb 11, 2013 at 4:00 PM, Shuah Khan wrote: > pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however, > it doesn't have interfaces to return PCI bus and PCI device id. Drivers > (AMD IOMMU, and AER) implement module specific definitions for PCI_BUS() > and AMD_IOMMU driver

Re: [PATCH v2 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-03-26 Thread Bjorn Helgaas
On Wed, Feb 27, 2013 at 5:06 PM, Shuah Khan wrote: > pci defines PCI_DEVFN(), PCI_SLOT(), and PCI_FUNC() interfaces, however, > it doesn't have interfaces to return PCI bus and PCI device id. Drivers > (AMD IOMMU, and AER) have module specific definitions for PCI_BUS() and > AMD_IOMMU driver also

Re: [PATCH v2 0/4] pci: Add PCI_BUS() and PCI_DEVID() interfaces to return bus number and device id

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 3:59 PM, Joerg Roedel wrote: > Hi Bjorn, > > On Tue, Mar 26, 2013 at 03:41:07PM -0600, Bjorn Helgaas wrote: >> Since some of these touch drivers/iommu, it'd be good if you acked >> them again, Joerg. I know you acked them before, but there have b

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-03 Thread Bjorn Helgaas
As such, it would be good to > give them a reminder that their systems are vulnurable to this problem. > > Signed-off-by: Neil Horman > CC: Prarit Bhargava > CC: Don Zickus > CC: Don Dutile > CC: Bjorn Helgaas > CC: Asit Mallick > CC: linux-...@vger.kernel.org > >

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 8:50 AM, Neil Horman wrote: > On Thu, Apr 04, 2013 at 03:27:29PM +0100, David Woodhouse wrote: >> On Wed, 2013-04-03 at 17:53 -0600, Bjorn Helgaas wrote: >> > ); >> > > + >> > > + if ((revision == 0x13) && irq_re

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 9:39 AM, Neil Horman wrote: > On Thu, Apr 04, 2013 at 08:57:06AM -0600, Bjorn Helgaas wrote: >> On Thu, Apr 4, 2013 at 8:50 AM, Neil Horman wrote: >> > On Thu, Apr 04, 2013 at 03:27:29PM +0100, David Woodhouse wrote: >> >> On Wed, 2013-04-03

Re: [PATCH v4] Quirk for buggy dma source tags with Intel IOMMU.

2013-04-04 Thread Bjorn Helgaas
On Thu, Mar 7, 2013 at 7:35 PM, Andrew Cooks wrote: > This patch creates a quirk to allow the Intel IOMMU to be enabled for devices > that use incorrect tags during DMA. It is similar to the quirk for Ricoh > devices, but allows mapping multiple functions and mapping of 'ghost' > functions that do

Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets

2013-04-04 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 11:51 AM, Neil Horman wrote: > Oh, you want the bug report that I'm fixing this against? Sure, I can do > that. > I thought you wanted me to include a url in the WARN_TAINT, with which user > could report occurances of this bug. Yeah, the bug that this is reported in >

Re: PCI warning on boot 3.8.0-rc1

2013-04-10 Thread Bjorn Helgaas
On Wed, Feb 06, 2013 at 08:58:41AM -0700, Alex Williamson wrote: > On Wed, 2013-02-06 at 07:49 -0800, Stephen Hemminger wrote: > > On Mon, 04 Feb 2013 15:41:24 -0700 > > Alex Williamson wrote: > > > > > On Mon, 2013-02-04 at 13:28 -0700, Alex Williamson wrote: > > > > On Mon, 2013-02-04 at 10:36

Re: PCI warning on boot 3.8.0-rc1

2013-04-11 Thread Bjorn Helgaas
On Wed, Apr 10, 2013 at 6:01 PM, Alex Williamson wrote: > On Wed, 2013-04-10 at 16:36 -0600, Bjorn Helgaas wrote: >> On Wed, Feb 06, 2013 at 08:58:41AM -0700, Alex Williamson wrote: >> > On Wed, 2013-02-06 at 07:49 -0800, Stephen Hemminger wrote: >> > > On M

Re: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 8:58 AM, Joerg Roedel wrote: > On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: >> swap_pci_ref function is used by the IOMMU API code for swapping pci device >> pointers, while determining the iommu group for the device. >> Currently this function was being imp

Re: PCI warning on boot 3.8.0-rc1

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 1:12 PM, Alex Williamson wrote: > On Thu, 2013-04-11 at 11:23 -0600, Bjorn Helgaas wrote: >> On Wed, Apr 10, 2013 at 6:01 PM, Alex Williamson >> wrote: >> > On Wed, 2013-04-10 at 16:36 -0600, Bjorn Helgaas wrote: >> >> On Wed, Fe

Re: [PATCH 1/3] pci: Add PCI walk function and PCIe bridge test

2013-05-23 Thread Bjorn Helgaas
On Fri, May 10, 2013 at 3:18 PM, Alex Williamson wrote: > These will replace pci_find_upstream_pcie_bridge, which is difficult > to use and rather specific to intel-iommu usage. A quirked > pci_is_pcie_bridge function is provided to work around non-compliant > PCIe-to-PCI bridges such as those fo

Re: [PATCH v3, part2 17/20] PCI, iommu: use hotplug-safe iterators to walk PCI buses

2013-06-17 Thread Bjorn Helgaas
On Sun, May 26, 2013 at 11:53:14PM +0800, Jiang Liu wrote: > Enhance iommu drviers to use hotplug-safe iterators to walk > PCI buses. > > Signed-off-by: Jiang Liu > Cc: Joerg Roedel > Cc: Ingo Molnar > Cc: Donald Dutile > Cc: Hannes Reinecke > Cc: "Li, Zhen-Hua" > Cc: iommu@lists.linux-found

Re: [PATCH v2 1/2] iommu: Quirked PCIe bridge test and search function

2013-06-25 Thread Bjorn Helgaas
On Thu, Jun 20, 2013 at 10:15 AM, Joerg Roedel wrote: > On Thu, Jun 20, 2013 at 09:44:51AM -0600, Alex Williamson wrote: >> On Thu, 2013-06-20 at 15:59 +0200, Joerg Roedel wrote: >> > On Tue, May 28, 2013 at 12:40:20PM -0600, Alex Williamson wrote: >> > > + if (!pci_is_root_bus(pdev->bus)) { >> >

Re: [PATCH v2 1/2] iommu: Quirked PCIe bridge test and search function

2013-06-26 Thread Bjorn Helgaas
On Wed, Jun 26, 2013 at 12:45 PM, Alex Williamson wrote: > On Tue, 2013-06-25 at 22:20 -0600, Bjorn Helgaas wrote: >> On Thu, Jun 20, 2013 at 10:15 AM, Joerg Roedel wrote: >> > On Thu, Jun 20, 2013 at 09:44:51AM -0600, Alex Williamson wrote: >> >> On Thu, 2013-06-2

Re: [PATCH v2 0/2] iommu/intel: Quirk non-compliant PCIe-to-PCI bridges

2013-07-08 Thread Bjorn Helgaas
is that since the IOMMU driver wants to perform some action for each possible requester ID the IOMMU might see, PCI could provide an iterator ("pci_for_each_requester_id()") to do that. Bjorn commit afad51492c6672b96c2b0735600d5695e30f7180 Author: Bjorn Helgaas Date: Wed Jul 3 16:04:

Re: [PATCH v2 0/2] iommu/intel: Quirk non-compliant PCIe-to-PCI bridges

2013-07-08 Thread Bjorn Helgaas
On Mon, Jul 08, 2013 at 02:49:16PM -0600, Alex Williamson wrote: > On Mon, 2013-07-08 at 13:34 -0600, Bjorn Helgaas wrote: > > On Mon, Jul 08, 2013 at 11:07:20AM -0600, Alex Williamson wrote: > > > Joerg, > > > > > > Where do we stand on this series?

Re: [PATCH v2 0/2] iommu/intel: Quirk non-compliant PCIe-to-PCI bridges

2013-07-09 Thread Bjorn Helgaas
On Tue, Jul 9, 2013 at 12:27 PM, Alex Williamson wrote: > On Mon, 2013-07-08 at 15:51 -0600, Bjorn Helgaas wrote: >> On Mon, Jul 08, 2013 at 02:49:16PM -0600, Alex Williamson wrote: >> > On Mon, 2013-07-08 at 13:34 -0600, Bjorn Helgaas wrote: >> > > On Mon, Jul 08,

Re: WARNING: at drivers/iommu/dmar.c:484 warn_invalid_dmar with Intel Motherboard

2013-07-09 Thread Bjorn Helgaas
[+cc Joerg, David, iommu list] On Tue, Jul 9, 2013 at 2:24 PM, Guenter Roeck wrote: > I started seeing this problem after updating the BIOS trying fix another > issue, > though I may have missed it earlier. > > I understand this is a BIOS bug. Would be great if someone can pass this on > to Inte

Re: Linux Plumbers ACPI/PM, PCI Microconference

2013-07-23 Thread Bjorn Helgaas
On Tue, Jul 16, 2013 at 8:21 PM, Myron Stowe wrote: > Linux Plumbers has approved an ACPI/PM, PCI microconference. The > overview page is here: > > http://wiki.linuxplumbersconf.org/2013:pci_subsystem > > We would like to start receiving volunteers for presenting topics of > interest. There is a

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-23 Thread Bjorn Helgaas
t; quirks at each step. "requestee" doesn't make sense to me. The "-ee" suffix added to a verb normally makes a noun that refers to the object of the action. So "requestee" sounds like it means something like "target" or "responder," but that

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-24 Thread Bjorn Helgaas
On Tue, Jul 23, 2013 at 5:21 PM, Alex Williamson wrote: > On Tue, 2013-07-23 at 16:35 -0600, Bjorn Helgaas wrote: >> On Thu, Jul 11, 2013 at 03:03:27PM -0600, Alex Williamson wrote: >> > This provides interfaces for drivers to discover the visible PCIe >> > requester

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-24 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 12:12:28PM -0600, Alex Williamson wrote: > On Wed, 2013-07-24 at 10:47 -0600, Bjorn Helgaas wrote: > > On Tue, Jul 23, 2013 at 5:21 PM, Alex Williamson > > wrote: > > > On Tue, 2013-07-23 at 16:35 -0600, Bjorn Helgaas wrote: > > >> On T

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh wrote: > Sorry for letting this discussion slide, I was busy on other works:-( > Anyway, the summary of previous discussion is: > - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on > boot. This expects PCI enumeration is done be

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-25 Thread Bjorn Helgaas
On Wed, Jul 24, 2013 at 04:42:03PM -0400, Don Dutile wrote: > On 07/23/2013 06:35 PM, Bjorn Helgaas wrote: > >On Thu, Jul 11, 2013 at 03:03:27PM -0600, Alex Williamson wrote: > >>This provides interfaces for drivers to discover the visible PCIe > >>requester ID for a de

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-26 Thread Bjorn Helgaas
On Thu, Jul 25, 2013 at 02:25:04PM -0400, Don Dutile wrote: > On 07/25/2013 01:19 PM, Bjorn Helgaas wrote: > >On Wed, Jul 24, 2013 at 04:42:03PM -0400, Don Dutile wrote: > >>On 07/23/2013 06:35 PM, Bjorn Helgaas wrote: > >>>On Thu, Jul 11, 2013 at 03:03:27P

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-26 Thread Bjorn Helgaas
On Thu, Jul 25, 2013 at 11:56:56AM -0600, Alex Williamson wrote: > On Wed, 2013-07-24 at 17:24 -0600, Bjorn Helgaas wrote: > > On Wed, Jul 24, 2013 at 12:12:28PM -0600, Alex Williamson wrote: > > > On Wed, 2013-07-24 at 10:47 -0600, Bjorn Helgaas wrote: > > > > O

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-29 Thread Bjorn Helgaas
On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh wrote: > (2013/07/26 2:00), Bjorn Helgaas wrote: >> On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh >> wrote: >>> Sorry for letting this discussion slide, I was busy on other works:-( >>> Anyway, the summary of previ

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-07-29 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 10:06 AM, Alex Williamson wrote: > On Fri, 2013-07-26 at 15:54 -0600, Bjorn Helgaas wrote: >> On Thu, Jul 25, 2013 at 11:56:56AM -0600, Alex Williamson wrote: >> The "most closely associated device" idea seems confusing to >> describe and th

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-30 Thread Bjorn Helgaas
On Tue, Jul 30, 2013 at 12:09 AM, Takao Indoh wrote: > (2013/07/29 23:17), Bjorn Helgaas wrote: >> On Sun, Jul 28, 2013 at 6:37 PM, Takao Indoh >> wrote: >>> (2013/07/26 2:00), Bjorn Helgaas wrote: >>>> My point about IOMMU and PCI initialization order

Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA

2013-07-31 Thread Bjorn Helgaas
[+cc Rafael, linux-acpi] On Tue, Jul 30, 2013 at 6:35 PM, Takao Indoh wrote: > On x86, currently IOMMU initialization run *after* PCI enumeration, but > what you are talking about is that it should be changed so that x86 > IOMMU initialization is done *before* PCI enumeration like sparc, right?

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2013-08-01 Thread Bjorn Helgaas
On Mon, Jul 29, 2013 at 4:32 PM, Alex Williamson wrote: > On Mon, 2013-07-29 at 15:02 -0600, Bjorn Helgaas wrote: >> On Mon, Jul 29, 2013 at 10:06 AM, Alex Williamson >> wrote: >> > On Fri, 2013-07-26 at 15:54 -0600, Bjorn Helgaas wrote: >> >> On Thu, Ju

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-09-24 Thread Bjorn Helgaas
On Thu, Sep 19, 2013 at 12:59:17PM +0530, Bharat Bhushan wrote: > This patch adds interface to get following information > - Number of MSI regions (which is number of MSI banks for powerpc). > - Get the region address range: Physical page which have the > address/addresses used for generat

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
On Thu, Oct 3, 2013 at 11:19 PM, Bhushan Bharat-R65777 wrote: >> I don't know enough about VFIO to understand why these new interfaces are >> needed. Is this the first VFIO IOMMU driver? I see vfio_iommu_spapr_tce.c >> and >> vfio_iommu_type1.c but I don't know if they're comparable to the Fre

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
>> - u32 msiir_offset; /* Offset of MSIIR, relative to start of CCSR */ >> + dma_addr_t msiir; /* MSIIR Address in CCSR */ > > Are you sure dma_addr_t is right here, versus phys_addr_t? It implies > that it's the output of the DMA API, but I don't think the DMA API is > used in the MSI dri

Re: [PATCH 1/3] iommu/fsl: Factor out PCI specific code.

2013-10-14 Thread Bjorn Helgaas
On Sun, Oct 13, 2013 at 02:02:32AM +0530, Varun Sethi wrote: > Factor out PCI specific code in the PAMU driver. > > Signed-off-by: Varun Sethi > --- > drivers/iommu/fsl_pamu_domain.c | 81 > +++ > 1 file changed, 40 insertions(+), 41 deletions(-) > > diff

Re: [PATCH 1/1] IOMMU: Save pci device id instead of pci_dev* pointer for DMAR devices

2013-11-07 Thread Bjorn Helgaas
On Tue, Nov 05, 2013 at 04:24:58PM +0800, Yijing Wang wrote: > Currently, DMAR driver save target pci devices pointers for drhd/rmrr/atsr > in (pci_dev *) array. This is not safe, because pci devices maybe > hot added or removed during system running. They will have new pci_dev * > pointer. So if t

Re: [PATCH 1/1] IOMMU: Save pci device id instead of pci_dev* pointer for DMAR devices

2013-11-08 Thread Bjorn Helgaas
On Thu, Nov 7, 2013 at 8:40 PM, Yijing Wang wrote: > HI Bjorn, >Thanks for your review and comments very much! > >>> +list_for_each_entry(dmar_dev, head, list) >>> +if (dmar_dev->segment == pci_domain_nr(dev->bus) >>> +&& dmar_dev->bus == dev

Re: [PATCH 1/9 v2] pci:msi: add weak function for returning msi region info

2013-11-25 Thread Bjorn Helgaas
On Tue, Nov 19, 2013 at 10:47:05AM +0530, Bharat Bhushan wrote: > In Aperture type of IOMMU (like FSL PAMU), VFIO-iommu system need to know > the MSI region to map its window in h/w. This patch just defines the > required weak functions only and will be used by followup patches. > > Signed-off-by:

Re: warn_slowpath_common in drivers/pci/search.c:44 on linux-3.4.0

2013-12-09 Thread Bjorn Helgaas
[+cc Alex] On Sun, Dec 8, 2013 at 7:26 AM, Antonio Quartulli wrote: > On 29/05/12 10:56, Antonio Quartulli wrote: >> On Tue, May 29, 2012 at 10:35:53 +0200, Joerg Roedel wrote: >>> Hi Antonio, >>> >>> On Sat, May 26, 2012 at 09:09:52AM -0600, Bjorn Helgaas w

[PATCH v2 0/4] Remove dead code

2014-02-18 Thread Bjorn Helgaas
227132710.71906...@nehalam.linuxnetplumber.net [2] https://lkml.kernel.org/r/20140130192011.25426.45702.st...@bhelgaas-glaptop.roam.corp.google.com --- Bjorn Helgaas (4): misc: mic: Add include of mei: Add include of iommu/amd: Add include of PCI: Remove unused SR-I

[PATCH v2 1/4] misc: mic: Add include of

2014-02-18 Thread Bjorn Helgaas
We currently include in , but I'm about to remove that from linux/pci.h, so add explicit includes where needed. Signed-off-by: Bjorn Helgaas --- drivers/misc/mic/card/mic_device.h |1 + drivers/misc/mic/host/mic_device.h |1 + 2 files changed, 2 insertions(+) diff --git a/drivers

[PATCH v2 2/4] mei: Add include of

2014-02-18 Thread Bjorn Helgaas
We currently include in , but I'm about to remove that from linux/pci.h, so add explicit includes where needed. Signed-off-by: Bjorn Helgaas --- drivers/misc/mei/hw-me.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/mei/hw-me.h b/drivers/misc/mei/hw-me.h

[PATCH v2 3/4] iommu/amd: Add include of

2014-02-18 Thread Bjorn Helgaas
We currently include in , but I'm about to remove that from linux/pci.h, so add explicit includes where needed. Signed-off-by: Bjorn Helgaas --- drivers/iommu/amd_iommu_types.h |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/

[PATCH v2 4/4] PCI: Remove unused SR-IOV VF Migration support

2014-02-18 Thread Bjorn Helgaas
. This is based on Stephen Hemminger's patch (see link below), but goes a bit further. Link: http://lkml.kernel.org/r/20131227132710.71906...@nehalam.linuxnetplumber.net Signed-off-by: Bjorn Helgaas CC: Stephen Hemminger --- Documentation/PCI/pci-iov-howto.txt |4 - dr

Re: [PATCH v2 2/4] mei: Add include of

2014-02-19 Thread Bjorn Helgaas
On Wed, Feb 19, 2014 at 1:29 AM, Winkler, Tomas wrote: > > >> >> We currently include in , but I'm about to >> remove that from linux/pci.h, so add explicit includes where needed. >> >> Signed-off-by: Bjorn Helgaas >> --- >> drivers/misc

Re: [PATCH v2 0/4] Remove dead code

2014-02-20 Thread Bjorn Helgaas
On Tue, Feb 18, 2014 at 1:59 PM, Bjorn Helgaas wrote: > This is v2 of my rework of part of Stephen's patch [1]. My v1 posting, > with a little discussion, is here [2]. > > This removes SR-IOV migration support, which seems to be unused. > > Changes since v1: >

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2014-04-03 Thread Bjorn Helgaas
[+cc George] On Fri, Aug 2, 2013 at 10:59 AM, Alex Williamson wrote: > ... > Great! I'm still trying to figure out how to handle the quirk around > Intel PCI-to-PCI bridge on the root complex as just another quirk. I > respin another version once I have that worked out. Thanks, Is anything ha

Re: [RFC PATCH v2 1/2] pci: Create PCIe requester ID interface

2014-04-04 Thread Bjorn Helgaas
On Thu, Apr 3, 2014 at 8:51 PM, Alex Williamson wrote: > On Thu, 2014-04-03 at 15:48 -0600, Bjorn Helgaas wrote: >> [+cc George] >> >> On Fri, Aug 2, 2013 at 10:59 AM, Alex Williamson >> wrote: >> > ... >> > Great! I'm still trying to figure ou

Re: hpsa driver bug crack kernel down!

2014-04-09 Thread Bjorn Helgaas
[+cc Joerg, iommu list] On Wed, Apr 9, 2014 at 6:19 PM, Davidlohr Bueso wrote: > On Wed, 2014-04-09 at 16:50 -0700, James Bottomley wrote: >> On Wed, 2014-04-09 at 16:40 -0700, Davidlohr Bueso wrote: >> > On Wed, 2014-04-09 at 16:10 -0700, James Bottomley wrote: >> > > On Wed, 2014-04-09 at 16:08

Re: hpsa driver bug crack kernel down!

2014-04-10 Thread Bjorn Helgaas
On Thu, Apr 10, 2014 at 2:46 AM, Woodhouse, David wrote: >> > > >> > > > > DMAR:[fault reason 02] Present bit in context entry is clear >> > > >> > > > > dmar: DRHD: handling fault status reg 602 >> > > >> > > > > dmar: DMAR:[DMA Read] Request device [02:00.0] fault addr >> > > >> > > > > 7f61e0

hpsa NULL pointer in hpsa_enter_performant_mode()

2014-04-10 Thread Bjorn Helgaas
[subject changed] On Thu, Apr 10, 2014 at 2:45 PM, wrote: > On Wed, Apr 09, 2014 at 11:32:37PM -0700, Davidlohr Bueso wrote: >> On Wed, 2014-04-09 at 22:03 -0600, Bjorn Helgaas wrote: >> > [+cc Joerg, iommu list] >> > >> > On Wed, Apr 9, 2014 at 6:19 PM, D

Re: [Patch Part3 V1 17/22] pci, ACPI, iommu: enhance pci_root to support DMAR device hotplug

2014-04-24 Thread Bjorn Helgaas
On Tue, Apr 22, 2014 at 03:07:28PM +0800, Jiang Liu wrote: > Finally enhance pci_root driver to support DMAR device hotplug when > hot-plugging PCI host bridges. > > Signed-off-by: Jiang Liu > --- > drivers/acpi/pci_root.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-27 Thread Bjorn Helgaas
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: > The driver_override field allows us to specify the driver for a device > rather than relying on the driver to provide a positive match of the > device. This shortcuts the existing process of looking up the vendor > and device ID, a

Re: [PATCH v4 05/16] PCI: quirk dma_alias_devfn for Marvell devices

2014-05-28 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 05:07:55PM -0600, Alex Williamson wrote: > Several Marvell devices and a JMicron device have a similar DMA > requester ID problem to Ricoh, except they use function 1 as the > PCIe requester ID. Add a quirk for these to populate the DMA > function alias bitmap. What's the

Re: [PATCH v4 06/16] PCI: Quirk pci_for_each_dma_alias() for bridges

2014-05-28 Thread Bjorn Helgaas
On Thu, May 22, 2014 at 05:08:01PM -0600, Alex Williamson wrote: > Several PCIe-to-PCI bridges fail to provide a PCIe capability, causing > us to handle them as conventional PCI devices. In some cases, this > may be correct, in others it's not. Add a dev_flag bit to identify > devices to be handl

Re: [PATCH v4 00/16] PCI/iommu: Fix DMA alias problems

2014-05-28 Thread Bjorn Helgaas
ack > them. I put 1-7 on a pci/iommu branch for v3.16. I'm happy to include the rest, too, given acks from Joerg and David. Or if they prefer to take them all, which might be easier than coordinating two trees, especially since there's PCI stuff at the beginning and end, here's my

Re: [PATCH v3] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-28 Thread Bjorn Helgaas
On Tue, May 20, 2014 at 08:53:21AM -0600, Alex Williamson wrote: > The driver_override field allows us to specify the driver for a device > rather than relying on the driver to provide a positive match of the > device. This shortcuts the existing process of looking up the vendor > and device ID, a

Re: [Patch Part3 V3 00/21] Enable support of Intel DMAR device hotplug

2014-06-25 Thread Bjorn Helgaas
> iommu/vt-d: match segment number when searching for dev_iotlb capable > devices > iommu/vt-d: use correct domain id to flush virtual machine domains > iommu/vt-d: introduce helper functions to improve code readability > iommu/vt-d: introduce helper functions to make code symmetric for

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-02 Thread Bjorn Helgaas
On Tue, Jun 10, 2014 at 03:10:30PM +0200, Alexander Gordeev wrote: > There are PCI devices that require a particular value written > to the Multiple Message Enable (MME) register while aligned on > power of 2 boundary value of actually used MSI vectors 'nvec' > is a lesser of that MME value: > >

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-07 Thread Bjorn Helgaas
On Fri, Jul 4, 2014 at 2:58 AM, Alexander Gordeev wrote: > On Thu, Jul 03, 2014 at 09:20:52AM +, David Laight wrote: >> From: Bjorn Helgaas >> > On Tue, Jun 10, 2014 at 03:10:30PM +0200, Alexander Gordeev wrote: >> > > There are PCI devices that require a part

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-07 Thread Bjorn Helgaas
On Fri, Jul 4, 2014 at 2:57 AM, Alexander Gordeev wrote: > On Wed, Jul 02, 2014 at 02:22:01PM -0600, Bjorn Helgaas wrote: >> On Tue, Jun 10, 2014 at 03:10:30PM +0200, Alexander Gordeev wrote: >> > There are PCI devices that require a particular value written >> > to

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-09 Thread Bjorn Helgaas
On Tue, Jul 8, 2014 at 6:26 AM, Alexander Gordeev wrote: > On Mon, Jul 07, 2014 at 01:40:48PM -0600, Bjorn Helgaas wrote: >> >> Can you quantify the benefit of this? Can't a device already use >> >> MSI-X to request exactly the number of vectors it can use?

Re: [PATCH 1/3] PCI/MSI: Add pci_enable_msi_partial()

2014-07-10 Thread Bjorn Helgaas
On Thu, Jul 10, 2014 at 4:11 AM, Alexander Gordeev wrote: > On Wed, Jul 09, 2014 at 10:06:48AM -0600, Bjorn Helgaas wrote: >> Out of curiosity, do you have a pointer to this? It looks like it > > I.e. ICH8 chapter 12.1.30 or ICH10 chapter 14.1.27 > >> uses one vector per

Re: [Patch Part3 V4 21/21] pci, ACPI, iommu: Enhance pci_root to support DMAR device hotplug

2014-07-16 Thread Bjorn Helgaas
On Fri, Jul 11, 2014 at 12:19 AM, Jiang Liu wrote: > Finally enhance pci_root driver to support DMAR device hotplug when > hot-plugging PCI host bridges. > > Signed-off-by: Jiang Liu Acked-by: Bjorn Helgaas I assume you'll merge this along with the rest of the series via

  1   2   3   4   5   >