[PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_avai

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson wrote: > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > >and PINCTRL_SUNXI, change the 'depends on RESET_

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-27 Thread Arnd Bergmann
On Mon, Sep 27, 2021 at 10:42 PM Bjorn Andersson wrote: > On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > > wrote: > > > > An easier option might be to find a way to build QCOM_SCM without > > RESET_CONTRO

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
On Tue, Sep 28, 2021 at 9:05 AM Kalle Valo wrote: > Arnd Bergmann writes: > > From: Arnd Bergmann > I assume I can continue to build test ATH10K_SNOC with x86 as before? > That's important for me. If yes, then: > > Acked-by: Kalle Valo > > -- > https:/

[PATCH 2/2] [v2] qcom_scm: hide Kconfig symbol

2021-09-28 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_avai

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Arnd Bergmann
On Wed, Sep 29, 2021 at 11:51 AM Will Deacon wrote: > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote: > > > > diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > > index 124c41adeca1..989c83acbfee 100644 > > --- a/drivers/iommu/Kconfig >

Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol

2021-09-29 Thread Arnd Bergmann
On Wed, Sep 29, 2021 at 4:46 PM Bjorn Andersson wrote: > > On Wed 29 Sep 05:04 CDT 2021, Arnd Bergmann wrote: > > > On Wed, Sep 29, 2021 at 11:51 AM Will Deacon wrote: > > > On Mon, Sep 27, 2021 at 05:22:13PM +0200, Arnd Bergmann wrote: > > > > > >

[PATCH v2 1/2] firmware: include drivers/firmware/Kconfig unconditionally

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Compile-testing drivers that require access to a firmware layer fails when that firmware symbol is unavailable. This happened twice this week: - My proposed to change to rework the QCOM_SCM firmware symbol broke on ppc64 and others. - The cs_dsp firmware patch added

[PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-07 Thread Arnd Bergmann
From: Arnd Bergmann Now that SCM can be a loadable module, we have to add another dependency to avoid link failures when ipa or adreno-gpu are built-in: aarch64-linux-ld: drivers/net/ipa/ipa_main.o: in function `ipa_probe': ipa_main.c:(.text+0xfc4): undefined reference to `qcom_scm_is_avai

Re: [PATCH] iommu: fix ARM_SMMU vs QCOM_SCM compilation

2021-10-10 Thread Arnd Bergmann
Kconfig symbol that is getting used to control the compilation of the SMMU implementation specific code for Qualcomm. Fixes: 424953cf3c66 ("qcom_scm: hide Kconfig symbol") Reported-by: Daniel Lezcano Reported-by: Dmitry Baryshkov Signed-off-by: Arnd Bergmann diff --git a/drivers

Re: [PATCH] iommu: fix ARM_SMMU vs QCOM_SCM compilation

2021-10-10 Thread Arnd Bergmann
On Mon, Oct 11, 2021 at 6:11 AM Dmitry Baryshkov wrote: > On Sun, 10 Oct 2021 at 20:42, Arnd Bergmann wrote: > > The patch seems correct, but it becomes overcomplicated. What about: > - restoring QCOM_SCM stubs The stubs are what has led to the previous bugs in this area to often

Re: [PATCH] iommu: fix ARM_SMMU vs QCOM_SCM compilation

2021-10-11 Thread Arnd Bergmann
On Mon, Oct 11, 2021 at 11:10 AM Dmitry Baryshkov wrote: > > On Mon, 11 Oct 2021 at 09:09, Arnd Bergmann wrote: > > > > On Mon, Oct 11, 2021 at 6:11 AM Dmitry Baryshkov > > wrote: > > > On Sun, 10 Oct 2021 at 20:42, Arnd Bergmann wrote: > > > >

[PATCH] iommu/arm: fix ARM_SMMU_QCOM compilation

2021-10-12 Thread Arnd Bergmann
From: Arnd Bergmann My previous bugfix ended up making things worse for the QCOM IOMMU driver when it forgot to add the Kconfig symbol that is getting used to control the compilation of the SMMU implementation specific code for Qualcomm. Fixes: 424953cf3c66 ("qcom_scm: hide Kconfig s

Re: [PATCH] iommu/arm: fix ARM_SMMU_QCOM compilation

2021-10-13 Thread Arnd Bergmann
On Wed, Oct 13, 2021 at 9:58 AM Will Deacon wrote: > On Tue, Oct 12, 2021 at 05:18:00PM +0200, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > My previous bugfix ended up making things worse for the QCOM IOMMU > > driver when it forgot to add the Kconfig sym

Re: [PATCH] iommu/arm: fix ARM_SMMU_QCOM compilation

2021-10-13 Thread Arnd Bergmann
On Wed, Oct 13, 2021 at 6:20 PM Will Deacon wrote: > On Wed, Oct 13, 2021 at 10:33:55AM +0200, Arnd Bergmann wrote: > > On Wed, Oct 13, 2021 at 9:58 AM Will Deacon wrote: > > > On Tue, Oct 12, 2021 at 05:18:00PM +0200, Arnd Bergmann wrote: > > I was hoping you and Jo

Re: [RFC 2/2] drm/msm/gem: Make use of the system cache

2021-11-16 Thread Arnd Bergmann
On Wed, Nov 17, 2021 at 12:16 AM Georgi Djakov wrote: > > Instead of writing to WC cmdstream buffers that go all the way to the main > memory, let's use the system cache to improve the performance. > > Signed-off-by: Georgi Djakov > --- > drivers/gpu/drm/msm/msm_gem.c | 2 +- > 1 file changed, 1

Re: [patch V3 05/35] powerpc/cell/axon_msi: Use PCI device property

2021-12-11 Thread Arnd Bergmann
On Fri, Dec 10, 2021 at 11:18 PM Thomas Gleixner wrote: > > From: Thomas Gleixner > > instead of fiddling with MSI descriptors. > > Signed-off-by: Thomas Gleixner > Cc: Arnd Bergmann > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: linuxppc-...@lists.oz

Re: [patch V3 07/35] device: Move MSI related data into a struct

2021-12-11 Thread Arnd Bergmann
it. The other MSI specific > parts are going to be removed from struct device in later steps. > > Signed-off-by: Thomas Gleixner > Reviewed-by: Greg Kroah-Hartman > Reviewed-by: Jason Gunthorpe Acked-by: Arnd Bergmann ___ iom

Re: [patch V3 34/35] soc: ti: ti_sci_inta_msi: Get rid of ti_sci_inta_msi_get_virq()

2021-12-11 Thread Arnd Bergmann
; Cc: Vinod Koul > Cc: dmaeng...@vger.kernel.org Acked-by: Arnd Bergmann ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [patch V3 12/35] soc: ti: ti_sci_inta_msi: Allocate MSI device data on first use

2021-12-11 Thread Arnd Bergmann
t; Cc: Nishanth Menon > Cc: Tero Kristo > Cc: Santosh Shilimkar > Cc: linux-arm-ker...@lists.infradead.org Acked-by: Arnd Bergmann ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-07-29 Thread Arnd Bergmann
On Tue, Jul 24, 2018 at 12:16 AM, Robin Murphy wrote: > Whilst the common firmware code invoked by dma_configure() initialises > devices' DMA masks according to limitations described by the respective > properties ("dma-ranges" for OF and _DMA/IORT for ACPI), the nature of > the dma_set_mask() API

Re: use the generic dma-noncoherent code for sh V2

2018-07-31 Thread Arnd Bergmann
On Fri, Jul 27, 2018 at 6:20 PM, Rob Landley wrote: > On 07/24/2018 03:21 PM, Christoph Hellwig wrote: >> On Tue, Jul 24, 2018 at 02:01:42PM +0200, Christoph Hellwig wrote: >>> Hi all, >>> >>> can you review these patches to switch sh to use the generic >>> dma-noncoherent code? All the requireme

Re: use the generic dma-noncoherent code for sh V2

2018-07-31 Thread Arnd Bergmann
On Mon, Jul 30, 2018 at 11:06 AM, Christoph Hellwig wrote: > On Fri, Jul 27, 2018 at 11:20:21AM -0500, Rob Landley wrote: >> Speaking of DMA: > > Which really has nothing to do with the dma mapping code, which > also means I can't help you much unfortunately. > > That being said sh is the last pen

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-08-06 Thread Arnd Bergmann
On Tue, Jul 31, 2018 at 1:30 PM Robin Murphy wrote: > On 29/07/18 13:32, Arnd Bergmann wrote: > > On Tue, Jul 24, 2018 at 12:16 AM, Robin Murphy wrote: > > Thanks a lot for working on this, this has bugged me for many years, > > and I've discussed possible solution

Re: [PATCH v2 0/7] Stop losing firmware-set DMA masks

2018-08-06 Thread Arnd Bergmann
On Mon, Aug 6, 2018 at 2:08 PM Christoph Hellwig wrote: > > On Mon, Aug 06, 2018 at 12:01:34PM +0200, Arnd Bergmann wrote: > > There are a few subtle corner cases here, in particular in which cases > > the new dma_set_mask() behavior on arm64 reports success or > > fai

Re: dmaengine for sh7760 (was Re: use the generic dma-noncoherent code for sh V2)

2018-08-17 Thread Arnd Bergmann
On Fri, Aug 17, 2018 at 7:04 PM Rob Landley wrote: > On 07/31/2018 07:56 AM, Arnd Bergmann wrote: > > On Fri, Jul 27, 2018 at 6:20 PM, Rob Landley wrote: > >> On 07/24/2018 03:21 PM, Christoph Hellwig wrote: > >>> On Tue, Jul 24, 2018 at 02:01:42PM +0200, Christop

Re: dmaengine for sh7760 (was Re: use the generic dma-noncoherent code for sh V2)

2018-08-20 Thread Arnd Bergmann
On Sun, Aug 19, 2018 at 7:38 AM Rob Landley wrote: > > On 08/17/2018 03:23 PM, Arnd Bergmann wrote: > > On Fri, Aug 17, 2018 at 7:04 PM Rob Landley wrote: > >> On 07/31/2018 07:56 AM, Arnd Bergmann wrote: > >>> On Fri, Jul 27, 2018 at 6:20 PM, Rob Landley wro

Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-09-14 Thread Arnd Bergmann
On Monday 14 September 2015 09:21:54 Viresh Kumar wrote: > diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c > index b4c216bab22b..bea8e425a8de 100644 > --- a/drivers/acpi/ec_sys.c > +++ b/drivers/acpi/ec_sys.c > @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, > uns

Re: [PATCH V2] debugfs: don't assume sizeof(bool) to be 4 bytes

2015-09-14 Thread Arnd Bergmann
On Tuesday 15 September 2015 07:34:38 Viresh Kumar wrote: > On 14-09-15, 09:03, Greg KH wrote: > > What ever ones you think it is relevant for :) > > "Relevant" is a relevant term :) > > So, the patch which defined the type bool as _Bool was added in v2.6.19 :) > > 6e2182874324 ("[PATCH] Generic

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-26 Thread Arnd Bergmann
On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > On 25 September 2015 at 15:19, Rafael J. Wysocki wrote: > > So if you allow something like debugfs to update your structure, how > > do you make sure there is the proper locking? > > Not really sure at all.. Isn't there some debugfs loc

Re: [PATCH V4 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock'

2015-09-28 Thread Arnd Bergmann
On Sunday 27 September 2015 16:10:48 Rafael J. Wysocki wrote: > On Saturday, September 26, 2015 09:33:56 PM Arnd Bergmann wrote: > > On Saturday 26 September 2015 11:40:00 Viresh Kumar wrote: > > > On 25 September 2015 at 15:19, Rafael J. Wysocki > > > wrote: > &

Re: [RFC 3/3] iommu: dma-iommu: use common implementation also on ARM architecture

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 09:22:44 Marek Szyprowski wrote: > This patch replaces ARM-specific IOMMU-based DMA-mapping implementation > with generic IOMMU DMA-mapping code shared with ARM64 architecture. The > side-effect of this change is a switch from bitmap-based IO address space > management to

Re: [RFC 3/3] iommu: dma-iommu: use common implementation also on ARM architecture

2016-02-25 Thread Arnd Bergmann
On Thursday 25 February 2016 13:26:17 Marek Szyprowski wrote: > >> +} > >> + > >> +extern void *arch_alloc_from_atomic_pool(size_t size, struct page > >> **ret_page, > >> + gfp_t flags); > >> +extern bool arch_in_atomic_pool(void *start, size_t size); > >> +exte

[PATCH] iommu: exynos: pointers are nto physical addresses

2016-02-29 Thread Arnd Bergmann
to uintptr_t instead. Signed-off-by: Arnd Bergmann Fixes: 740a01eee9ad ("iommu/exynos: Add support for v5 SYSMMU") --- I also see that some incorrect __raw_writel() calls have crept in around the same time, which breaks running big-endian kernels when this driver is loaded. Please fi

[PATCH] iommu/mediatek: select IOMMU_IOVA

2016-02-29 Thread Arnd Bergmann
driver is enabled. Are there any cases where we would enable an IOMMU but not use it? Signed-off-by: Arnd Bergmann Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver") --- drivers/iommu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/Kconfig b/dri

Re: [PATCH] iommu/mediatek: select IOMMU_IOVA

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 10:11:58 Arnd Bergmann wrote: > This adds the same select that the other drivers have. On a related > note, I wonder if we should just always select ARM_DMA_USE_IOMMU > whenever any IOMMU driver is enabled. Are there any cases where > we would enable an IOMMU

[PATCH 2/2] iommu/mediatek: mark PM functions as __maybe_unused

2016-02-29 Thread Arnd Bergmann
nction] Marking the functions as __maybe_unused gits rid of the two functions and lets the compiler silently drop the object code, while still doing syntax checking on them for build-time verification. Signed-off-by: Arnd Bergmann Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU dr

[PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU

2016-02-29 Thread Arnd Bergmann
driver is enabled. Are there any cases where we would enable an IOMMU but not use it? Signed-off-by: Arnd Bergmann Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver") --- drivers/iommu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/Kconfig b/dri

Re: [PATCH] iommu: exynos: pointers are nto physical addresses

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 10:33:59 Marek Szyprowski wrote: > > --- > > I also see that some incorrect __raw_writel() calls have crept in > > around the same time, which breaks running big-endian kernels when > > this driver is loaded. > > > > Please fix and that that as well. > > Okay, so in the

Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 10:37:40 Robin Murphy wrote: > Hi Arnd, > > On 29/02/16 09:19, Arnd Bergmann wrote: > > The newly added Mediatek IOMMU driver uses the IOMMU_DMA infrastructure, > > but unlike other such drivers, it does not select 'ARM_DMA_USE_IOMMU

Re: [PATCH] iommu/dma: Fix NEED_SG_DMA_LENGTH dependency

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 11:13:39 Robin Murphy wrote: > IOMMU_DMA does indeed depend on scatterlists having a DMA length, but > the NEED_SG_DMA_LENGTH symbol should be selected, not depended upon. > > Reported-by: Arnd Bergmann > Signed-off-by: Robin Murphy > Acked

Re: [PATCH 1/2] iommu/mediatek: select ARM_DMA_USE_IOMMU

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 11:22:24 Robin Murphy wrote: > >>> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig > >>> index b325954cf8f8..ea0998921702 100644 > >>> --- a/drivers/iommu/Kconfig > >>> +++ b/drivers/iommu/Kconfig > >>> @@ -341,6 +341,7 @@ config MTK_IOMMU > >>> bool "MTK I

Re: [PATCH] iommu/exynos: Use proper readl/writel register interface

2016-02-29 Thread Arnd Bergmann
On Monday 29 February 2016 13:42:57 Marek Szyprowski wrote: > Drivers should use generic readl/writel calls to access HW registers, so > replace all __raw_readl/writel with generic version. > > Suggested-by: Arnd Bergmann > Signed-off-by: Marek Szyprowski > Acked

Re: [PATCH v10 0/5] MT8173 IOMMU SUPPORT

2016-03-02 Thread Arnd Bergmann
On Wednesday 02 March 2016 11:48:43 Matthias Brugger wrote: > > On 26/02/16 12:06, Joerg Roedel wrote: > > Hi Philipp, > > > > On Fri, Feb 26, 2016 at 09:55:55AM +0100, Philipp Zabel wrote: > >> Do you have a stable branch that I could base the mediatek-drm patches > >> on and that I may include i

Re: fully convert arm to use dma-direct v3

2022-07-07 Thread Arnd Bergmann
On Thu, Jul 7, 2022 at 6:58 AM Christoph Hellwig wrote: > On Wed, Jun 29, 2022 at 08:41:32AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jun 29, 2022 at 08:28:37AM +0200, Christoph Hellwig wrote: > > > Any comments or additional testing? It would be really great to get > > > this off the table.

<    1   2   3   4