Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-03-24 Thread Christoph Hellwig
On Tue, Mar 24, 2020 at 02:37:59PM +1100, Alexey Kardashevskiy wrote: > dma_alloc_direct() and dma_map_direct() do the same thing now which is > good, did I miss anything else? dma_alloc_direct looks at coherent_dma_mask, dma_map_direct looks at dma_mask. __

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-03-24 Thread Christoph Hellwig
On Tue, Mar 24, 2020 at 02:05:54PM +1100, Alexey Kardashevskiy wrote: > This is for persistent memory which you can DMA to/from but yet it does > not appear in the system as a normal memory and therefore requires > special handling anyway (O_DIRECT or DAX, I do not know the exact > mechanics). All

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-03-24 Thread Christoph Hellwig
On Tue, Mar 24, 2020 at 12:00:09PM +0530, Aneesh Kumar K.V wrote: > dma_addr_t dma_direct_map_page(struct device *dev, struct page *page, > unsigned long offset, size_t size, enum dma_data_direction dir, > unsigned long attrs) > { > phys_addr_t phys = page_to_phys(

Re: [EXT] Re: [PATCH RFC] iommu/virtio: Use page size bitmap supported by endpoint

2020-03-24 Thread Jean-Philippe Brucker
On Mon, Mar 23, 2020 at 05:25:17PM +, Bharat Bhushan wrote: > Hi Jean, > > > -Original Message- > > From: Jean-Philippe Brucker > > Sent: Monday, March 23, 2020 3:30 PM > > To: Bharat Bhushan > > Cc: j...@8bytes.org; m...@redhat.com; jasow...@redhat.com; > > virtualizat...@lists.linu

Re: arm-smmu-v3 high cpu usage for NVMe

2020-03-24 Thread John Garry
On 23/03/2020 09:16, Marc Zyngier wrote: + Julien, Mark Hi Marc, Time to enable pseudo-NMIs in the PMUv3 driver... Do you know if there is any plan for this? There was. Julien Thierry has a bunch of patches for that [1], but they needs reviving. So those patches still apply cleanly (

Re: [PATCH v3 10/15] iommu/arm-smmu: Use accessor functions for iommu private data

2020-03-24 Thread Joerg Roedel
Hey Robin, On Mon, Mar 23, 2020 at 04:02:33PM +, Robin Murphy wrote: > Yikes, this ends up pretty ugly, and I'd prefer not have this much > complexity hidden in macros that were intended just to be convenient > shorthand. Would you mind pulling in the patch below as a precursor? Sure thing, b

Re: arm-smmu-v3 high cpu usage for NVMe

2020-03-24 Thread Marc Zyngier
On Tue, 24 Mar 2020 09:18:10 + John Garry wrote: > On 23/03/2020 09:16, Marc Zyngier wrote: > > + Julien, Mark > > Hi Marc, > > >>> Time to enable pseudo-NMIs in the PMUv3 driver... > >>> > >> > >> Do you know if there is any plan for this? > > > > There was. Julien Thierry has a bunch of

[RFC PATCH v2 1/4] bus: fsl-mc: add custom .dma_configure implementation

2020-03-24 Thread laurentiu . tudor
From: Laurentiu Tudor The devices on this bus are not discovered by way of device tree but by queries to the firmware. It makes little sense to trick the generic of layer into thinking that these devices are of related so that we can get our dma configuration. Instead of doing that, add our custo

[RFC PATCH v2 2/4] irqchip/fsl-mc: Change the way the IRQ domain is set for MC devices

2020-03-24 Thread laurentiu . tudor
From: Diana Craciun In ACPI the MC bus is represented as a platform device and a named component in the IORT table. The mc-bus devices are discovered dynamically at runtime but they share the same fwnode with the parent platfom device. This patch changes the way the IRQ domain is searched for the

[RFC PATCH v2 0/4] bus: fsl-mc: Add ACPI support for fsl-mc

2020-03-24 Thread laurentiu . tudor
From: Laurentiu Tudor This patch adds ACPI support for the fsl-mc bus driver. First 2 patches are prerequsite that remove dependencies on device tree. Third patch adds the actual ACPI support and the final one drops some fsl-mc specific code in the generic device tree handling code. Changes in v

[RFC PATCH v2 3/4] bus: fsl-mc: Add ACPI support for fsl-mc

2020-03-24 Thread laurentiu . tudor
From: Makarand Pawagi ACPI support is added in the fsl-mc driver. Driver will parse MC DSDT table to extract memory and other resorces. Interrupt (GIC ITS) information will be extracted from MADT table by drivers/irqchip/irq-gic-v3-its-fsl-mc-msi.c. IORT table will be parsed to configure DMA.

[RFC PATCH v2 4/4] iommu/of: get rid of fsl-mc specific code

2020-03-24 Thread laurentiu . tudor
From: Laurentiu Tudor Changing the way we configure dma for fsl-mc devices allows us to get rid of our fsl-mc specific code in the generic of iommu code. Signed-off-by: Laurentiu Tudor --- drivers/iommu/of_iommu.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers

Re: arm-smmu-v3 high cpu usage for NVMe

2020-03-24 Thread John Garry
On 24/03/2020 10:43, Marc Zyngier wrote: On Tue, 24 Mar 2020 09:18:10 + John Garry wrote: On 23/03/2020 09:16, Marc Zyngier wrote: + Julien, Mark Hi Marc, Time to enable pseudo-NMIs in the PMUv3 driver... Do you know if there is any plan for this? There was. Julien Thierry has a bun

Re: arm-smmu-v3 high cpu usage for NVMe

2020-03-24 Thread Robin Murphy
On 2020-03-24 11:55 am, John Garry wrote: On 24/03/2020 10:43, Marc Zyngier wrote: On Tue, 24 Mar 2020 09:18:10 + John Garry  wrote: On 23/03/2020 09:16, Marc Zyngier wrote: + Julien, Mark Hi Marc, Time to enable pseudo-NMIs in the PMUv3 driver... Do you know if there is any plan for

Re: arm-smmu-v3 high cpu usage for NVMe

2020-03-24 Thread John Garry
On 24/03/2020 12:07, Robin Murphy wrote: On 2020-03-24 11:55 am, John Garry wrote: On 24/03/2020 10:43, Marc Zyngier wrote: On Tue, 24 Mar 2020 09:18:10 + John Garry  wrote: On 23/03/2020 09:16, Marc Zyngier wrote: + Julien, Mark Hi Marc, Time to enable pseudo-NMIs in the PMUv3 driver

Re: [PATCH 1/3] iommu/vt-d: Remove redundant IOTLB flush

2020-03-24 Thread Jacob Pan
On Sat, 21 Mar 2020 09:32:45 +0800 Lu Baolu wrote: > On 2020/3/21 0:20, Jacob Pan wrote: > > On Fri, 20 Mar 2020 21:45:26 +0800 > > Lu Baolu wrote: > > > >> On 2020/3/20 12:32, Jacob Pan wrote: > >>> IOTLB flush already included in the PASID tear down process. There > >>> is no need to flus

Re: [PATCH 2/2] iommu/vt-d: Replace intel SVM APIs with generic SVA APIs

2020-03-24 Thread Jacob Pan
On Fri, 20 Mar 2020 10:29:55 +0100 Jean-Philippe Brucker wrote: > Hi Jacob, > > I think this step is really useful and the patch looks good overall, > thanks for doing this. Some commments inline > > On Mon, Feb 24, 2020 at 03:26:37PM -0800, Jacob Pan wrote: > > This patch is an initial step to

Re: [PATCH 1/3] iommu/vt-d: Remove redundant IOTLB flush

2020-03-24 Thread Lu Baolu
On 2020/3/24 23:31, Jacob Pan wrote: On Sat, 21 Mar 2020 09:32:45 +0800 Lu Baolu wrote: On 2020/3/21 0:20, Jacob Pan wrote: On Fri, 20 Mar 2020 21:45:26 +0800 Lu Baolu wrote: On 2020/3/20 12:32, Jacob Pan wrote: IOTLB flush already included in the PASID tear down process. There is no n

Re: [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device

2020-03-24 Thread Alexey Kardashevskiy
On 24/03/2020 18:54, Christoph Hellwig wrote: > On Tue, Mar 24, 2020 at 02:05:54PM +1100, Alexey Kardashevskiy wrote: >> This is for persistent memory which you can DMA to/from but yet it does >> not appear in the system as a normal memory and therefore requires >> special handling anyway (O_DIR