Re: [RFC PATCH v1] iommu/io-pgtable-arm: Check for leaf entry right after finding it

2017-02-13 Thread Oleksandr Tyshchenko
Hi, all. Any comments? On Thu, Feb 9, 2017 at 3:56 PM, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Do a check for already installed leaf entry at the current level before > performing any actions when trying to map. > > This check is already present in arm_lpae_init_pte(), i.e.

Re: [RFC PATCH v1] iommu/io-pgtable-arm: Check for leaf entry right after finding it

2017-02-13 Thread Will Deacon
On Mon, Feb 13, 2017 at 01:07:02PM +0200, Oleksandr Tyshchenko wrote: > Any comments? Looks fine to me, but I don't think it's urgent and I already sent my SMMU pull for 4.11. I'll send this as a fix after the merge window. I suspect we need something similar for io-pgtable-arm-v7s.c, too. Will

Re: [RFC PATCH v1] iommu/io-pgtable-arm: Check for leaf entry right after finding it

2017-02-13 Thread Oleksandr Tyshchenko
On Mon, Feb 13, 2017 at 1:27 PM, Will Deacon wrote: > On Mon, Feb 13, 2017 at 01:07:02PM +0200, Oleksandr Tyshchenko wrote: >> Any comments? > > Looks fine to me, but I don't think it's urgent and I already sent my > SMMU pull for 4.11. I'll send this as a fix after the merge window. OK. Thank you

Re: [RFC PATCH v1] iommu/io-pgtable-arm: Check for leaf entry right after finding it

2017-02-13 Thread Will Deacon
On Mon, Feb 13, 2017 at 01:50:29PM +0200, Oleksandr Tyshchenko wrote: > On Mon, Feb 13, 2017 at 1:27 PM, Will Deacon wrote: > > On Mon, Feb 13, 2017 at 01:07:02PM +0200, Oleksandr Tyshchenko wrote: > >> Any comments? > > > > Looks fine to me, but I don't think it's urgent and I already sent my > >

RFC on No ACS Support and SMMUv3 Support

2017-02-13 Thread Sinan Kaya
Hi, I am getting ready to submit a quirk patch. Before I go ahead and submit it for review, I wanted to get ARM IOMMU developers and PCI/VFIO maintainers together to figure out what the best approach would be. The Qualcomm QDF2400 server does not support the ACS functionality. The server chip imp

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-13 Thread Alex Williamson
On Mon, 13 Feb 2017 17:24:40 -0500 Sinan Kaya wrote: > Hi, > I am getting ready to submit a quirk patch. Before I go ahead and submit > it for review, I wanted to get ARM IOMMU developers and PCI/VFIO maintainers > together to figure out what the best approach would be. > > The Qualcomm QDF2400

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-13 Thread Sinan Kaya
Hi Alex, Thanks for your response. Other comments inline. On 2/13/2017 6:06 PM, Alex Williamson wrote: > On Mon, 13 Feb 2017 17:24:40 -0500 > Sinan Kaya wrote: > >> Hi, >> I am getting ready to submit a quirk patch. Before I go ahead and submit >> it for review, I wanted to get ARM IOMMU develo

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-13 Thread Alex Williamson
On Mon, 13 Feb 2017 19:14:31 -0500 Sinan Kaya wrote: > Hi Alex, > > Thanks for your response. Other comments inline. > > On 2/13/2017 6:06 PM, Alex Williamson wrote: > > On Mon, 13 Feb 2017 17:24:40 -0500 > > Sinan Kaya wrote: > > > >> Hi, > >> I am getting ready to submit a quirk patch. Be

Re: RFC on No ACS Support and SMMUv3 Support

2017-02-13 Thread Sinan Kaya
On 2/13/2017 8:46 PM, Alex Williamson wrote: >> My first goal is to support virtual function passthrough for device's that >> are directly >> connected. This will be possible with the quirk I proposed and it will be >> the most >> secure solution. It can certainly be generalized for other systems