RE: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

2016-12-05 Thread Sricharan
Hi Lorenzo, > >On Sat, Dec 3, 2016 at 11:39 AM, Lorenzo Pieralisi > wrote: >> On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: >>> On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi >>> wrote: >>> > Rafael, Mark, Suravee, >>> > >>> > On Mon, Nov 21, 2016 at 10:01:39AM +, Lore

Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

2016-12-05 Thread Lorenzo Pieralisi
On Mon, Dec 05, 2016 at 03:22:02PM +0530, Sricharan wrote: > Hi Lorenzo, > > > > >On Sat, Dec 3, 2016 at 11:39 AM, Lorenzo Pieralisi > > wrote: > >> On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: > >>> On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi > >>> wrote: > >>> > Rafa

[PATCH v3] iommu/vt-d: Flush old iommu caches for kdump when the device gets context mapped

2016-12-05 Thread Xunlei Pang
We met the DMAR fault both on hpsa P420i and P421 SmartArray controllers under kdump, it can be steadily reproduced on several different machines, the dmesg log is like: HP HPSA Driver (v 3.4.16-0) hpsa :02:00.0: using doorbell to reset controller hpsa :02:00.0: board ready after hard reset

[PATCH] ACPI/IORT: Make dma masks set-up IORT specific

2016-12-05 Thread Lorenzo Pieralisi
The introduction of acpi_dma_configure() allows to configure DMA and related IOMMU for any device that is DMA capable. To achieve that goal it ensures DMA masks are set-up to sane default values before proceeding with IOMMU and DMA ops configuration. On x86/ia64 systems, through acpi_bind_one(), a

Re: [PATCH 0/2] Device links documentation

2016-12-05 Thread Mauro Carvalho Chehab
Hi Lukas, Em Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner escreveu: > Here's my suggestion for initial documentation on the device links > feature that's queued for 4.10 on Greg KH's driver-core-next branch. > Please let me know if you have any additions or corrections. > > To read this in rende

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Mauro Carvalho Chehab
Em Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner escreveu: > Silence this warning emitted by sphinx: > include/linux/device.h:938: warning: No description found for parameter > 'links' > > While at it, fix typos in comments of device links code. > > Cc: Rafael J. Wysocki > Cc: Greg Kroah-Hartma

Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation

2016-12-05 Thread Mauro Carvalho Chehab
Em Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner escreveu: > Document device links as introduced in v4.10 with commits: > 4bdb35506b89 ("driver core: Add a wrapper around >__device_release_driver()") > 9ed9895370ae ("driver core: Functional dependencies tracking >

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Lukas Wunner
On Mon, Dec 05, 2016 at 10:20:53AM -0200, Mauro Carvalho Chehab wrote: > Em Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner escreveu: > > Silence this warning emitted by sphinx: > > include/linux/device.h:938: warning: No description found for parameter > > 'links' > > > > While at it, fix typos in

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Mauro Carvalho Chehab
Em Mon, 5 Dec 2016 13:44:49 +0100 Lukas Wunner escreveu: > On Mon, Dec 05, 2016 at 10:20:53AM -0200, Mauro Carvalho Chehab wrote: > > Em Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner escreveu: > > > Silence this warning emitted by sphinx: > > > include/linux/device.h:938: warning: No description

Re: [PATCH 0/2] Device links documentation

2016-12-05 Thread Jonathan Corbet
[Trimming the CC list a bit; claws-mail chokes on the full thing for some reason] On Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner wrote: > @Jonathan Corbet: Is core-api the right place to put this? An > alternative would be Documentation/driver-api, but unlike core-api > it contains less prose t

Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation

2016-12-05 Thread Jonathan Corbet
On Mon, 5 Dec 2016 10:07:39 -0200 Mauro Carvalho Chehab wrote: > > +Usage > > += > > You should be using, instead: > > Usage > - > > (and the same '-' symbol for all sections of this chapter) > > The way you did, in thesis, ReST should be putting all tags at the > same level as the

Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation

2016-12-05 Thread Mauro Carvalho Chehab
Em Mon, 5 Dec 2016 06:05:07 -0700 Jonathan Corbet escreveu: > On Mon, 5 Dec 2016 10:07:39 -0200 > Mauro Carvalho Chehab wrote: > > > > +Usage > > > += > > > > You should be using, instead: > > > > Usage > > - > > > > (and the same '-' symbol for all sections of this chapter) > > >

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Greg Kroah-Hartman
On Sun, Dec 04, 2016 at 01:10:04PM +0100, Lukas Wunner wrote: > Silence this warning emitted by sphinx: > include/linux/device.h:938: warning: No description found for parameter > 'links' > > While at it, fix typos in comments of device links code. > > Cc: Rafael J. Wysocki > Cc: Greg Kroah-Har

Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation

2016-12-05 Thread Jonathan Corbet
On Sun, 4 Dec 2016 13:10:04 +0100 Lukas Wunner wrote: > Document device links as introduced in v4.10 with commits: > 4bdb35506b89 ("driver core: Add a wrapper around >__device_release_driver()") > 9ed9895370ae ("driver core: Functional dependencies tracking >

[PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
This blacklists the Q35 integrated graphics so IOMMU can be otherwise enabled. Without this, a Q35 system can only enable IOMMU when booting with "intel_iommu=on,igfx_off" but not "intel_iommu=on". 00:02.0 0300: 8086:29b2 (rev 02) (prog-if 00 [VGA controller]) Subsystem: 8086:4f4a

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread David Woodhouse
On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: > This blacklists the Q35 integrated graphics so IOMMU can be otherwise > enabled. Without this, a Q35 system can only enable IOMMU when booting > with "intel_iommu=on,igfx_off" but not "intel_iommu=on". Hm, is this definitely the same bug? Or is

Re: [PATCH] ACPI/IORT: Make dma masks set-up IORT specific

2016-12-05 Thread Rafael J. Wysocki
On Mon, Dec 5, 2016 at 1:26 PM, Lorenzo Pieralisi wrote: > The introduction of acpi_dma_configure() allows to configure DMA > and related IOMMU for any device that is DMA capable. To achieve > that goal it ensures DMA masks are set-up to sane default values > before proceeding with IOMMU and DMA o

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 2:07 PM, David Woodhouse wrote: > On Mon, 2016-12-05 at 13:58 -0800, Kees Cook wrote: >> This blacklists the Q35 integrated graphics so IOMMU can be otherwise >> enabled. Without this, a Q35 system can only enable IOMMU when booting >> with "intel_iommu=on,igfx_off" but not

Re: [PATCH 2/2] driver core: Silence device links sphinx warning

2016-12-05 Thread Rafael J. Wysocki
On Sun, Dec 4, 2016 at 1:10 PM, Lukas Wunner wrote: > Silence this warning emitted by sphinx: > include/linux/device.h:938: warning: No description found for parameter > 'links' > > While at it, fix typos in comments of device links code. > > Cc: Rafael J. Wysocki > Cc: Greg Kroah-Hartman > Cc:

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread David Woodhouse
On Mon, 2016-12-05 at 14:18 -0800, Kees Cook wrote: > Hm, I have no idea. :) What would I look for in the BIOS? For a start, what is the actual failure mode? > I figured since g4 was busted, surely q35 was too, since it's even > older... Oh no, they all have different failures. Intel never actua

Re: [PATCH] iommu/intel: disable DMAR for Q35 integrated gfx

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 2:47 PM, David Woodhouse wrote: > On Mon, 2016-12-05 at 14:18 -0800, Kees Cook wrote: >> Hm, I have no idea. :) What would I look for in the BIOS? > > For a start, what is the actual failure mode? Based on initial testing (not that I've spent tons of time with it, since I n

Re: [PATCH 1/2] Documentation/core-api/device_link: Add initial documentation

2016-12-05 Thread Luis R. Rodriguez
On Sun, Dec 04, 2016 at 01:10:04PM +0100, Lukas Wunner wrote: > Document device links as introduced in v4.10 with commits: > 4bdb35506b89 ("driver core: Add a wrapper around >__device_release_driver()") > 9ed9895370ae ("driver core: Functional dependencies tracking >

Re: [RESEND PATCH V6 5/6] dmaengine: pl330: Make sure microcode is privileged

2016-12-05 Thread Vinod Koul
On Fri, Dec 02, 2016 at 08:25:08PM +0530, Sricharan R wrote: > From: Mitchel Humpherys > > The PL330 performs privileged instruction fetches. This can result in > SMMU permission faults on SMMUs that implement the ARMv8 VMSA, which > specifies that mappings that are writeable at one execution le

Re: [PATCH] iommu/intel-iommu: fix pasid table size encoding

2016-12-05 Thread Jacob Pan
Hi David, Any thoughts on this one? Without this patch Kabylake would fail with IOMMU error when svm is initialized. Thanks, Jacob On Thu, 1 Dec 2016 13:50:26 -0800 Jacob Pan wrote: > Different encodings are used to represent supported PASID bits > and number of PASID table entries. > The cu