Re: [PATCH 2/2] iommu/omap: Add support for configuring dsp iommus on DRA7xx

2015-07-23 Thread Tony Lindgren
* Suman Anna [150722 09:25]: > On 07/22/2015 12:26 AM, Tony Lindgren wrote: > > > > I don't like using syscon for tinkering directly with SoC registers. > > This is not a SoC-level register, but a register within a sub-module of > the DSP processor sub-system. The DSP_SYSTEM sub-module in genera

Lockdep warning in VFIO using v4.2-rc3

2015-07-23 Thread Joerg Roedel
Hi Alex, I stumbled over this lockdep warning yesterday while testing my VT-d changes. It looks like one code path is taking the locks: group->device_lock driver_lock pci_bus_sem while another path is taking pci_bus_sem group->device_lock which could lea

Re: [RFC PATCH 1/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-23 Thread Gerald Schaefer
On Wed, 22 Jul 2015 10:54:35 -0600 Alex Williamson wrote: > On Tue, 2015-07-21 at 19:44 +0200, Gerald Schaefer wrote: > > When a user completes the VFIO_SET_IOMMU ioctl and the vfio-pci > > device is removed thereafter (before any other ioctl like > > VFIO_GROUP_GET_DEVICE_FD), then the detach_de

Re: [RFC PATCH 1/1] vfio-pci/iommu: Detach iommu group on remove path

2015-07-23 Thread Gerald Schaefer
On Wed, 22 Jul 2015 11:10:57 -0600 Alex Williamson wrote: > On Wed, 2015-07-22 at 10:54 -0600, Alex Williamson wrote: > > On Tue, 2015-07-21 at 19:44 +0200, Gerald Schaefer wrote: > > > When a user completes the VFIO_SET_IOMMU ioctl and the vfio-pci > > > device is removed thereafter (before any

Re: [PATCH 2/2] iommu/omap: Add support for configuring dsp iommus on DRA7xx

2015-07-23 Thread Suman Anna
Hi Tony, On 07/23/2015 02:24 AM, Tony Lindgren wrote: > * Suman Anna [150722 09:25]: >> On 07/22/2015 12:26 AM, Tony Lindgren wrote: >>> >>> I don't like using syscon for tinkering directly with SoC registers. >> >> This is not a SoC-level register, but a register within a sub-module of >> the DS

[git pull] IOMMU Fixes for Linux v4.2-rc3

2015-07-23 Thread Joerg Roedel
Hi Linus, The following changes since commit d770e558e21961ad6cfdf0ff7df0eb5d7d4f0754: Linux 4.2-rc1 (2015-07-05 11:01:52 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v4.2-rc3 for you to fetch changes up to 46

[PATCH 0/3] Generic PCI MSI + IOMMU topology bindings

2015-07-23 Thread Mark Rutland
Hi all, Currently we have no generic/standard mechanisms for describing the relationship between PCI root complexes and other components which may be required to make them usable, specifically IOMMUs and MSI controllers. There is an existing binding for IOMMUs, and there is a de-facto standard fo

[PATCH 1/3] Docs: dt: add generic MSI bindings

2015-07-23 Thread Mark Rutland
Currently msi-parent is used in a couple of drivers despite being fairly underspecified. This patch adds a generic binding for MSIs (including the existing msi-parent property) enabling the description of platform devices capable of using MSIs. While MSIs are primarily distinguished by doorbell an

[PATCH 3/3] Docs: dt: add PCI IOMMU map bindings

2015-07-23 Thread Mark Rutland
The existing IOMMU bindings are able to specify the relationship between masters and IOMMUs, but they are insufficient for describing the general case of hotpluggable busses such as PCI where the set of masters is not known until runtime, and the relationship between masters and IOMMUs is a propert

Re: [PATCH] iommu/vt-d: Fix VM domain ID leak

2015-07-23 Thread Joerg Roedel
On Wed, Jul 22, 2015 at 03:01:04PM -0600, Alex Williamson wrote: > In the meantime, we're still leaking domain IDs, do you see any problem > with the proposed patch for 4.2 and stable? Thanks, Applied and pull-request sent. ___ iommu mailing list iommu

[PATCH 2/3] Docs: dt: Add PCI MSI map bindings

2015-07-23 Thread Mark Rutland
Currently msi-parent is used by a few bindings to describe the relationship between a PCI root complex and a single MSI controller, but this property does not have a generic binding document. Additionally, msi-parent is insufficient to describe more complex relationships between MSI controllers an

Re: Lockdep warning in VFIO using v4.2-rc3

2015-07-23 Thread Alex Williamson
On Thu, 2015-07-23 at 11:15 +0200, Joerg Roedel wrote: > Hi Alex, > > I stumbled over this lockdep warning yesterday while testing my VT-d > changes. It looks like one code path is taking the locks: > > group->device_lock > driver_lock > pci_bus_sem > > while another path is ta

Re: Lockdep warning in VFIO using v4.2-rc3

2015-07-23 Thread Joerg Roedel
Hi Alex, On Thu, Jul 23, 2015 at 11:07:37AM -0600, Alex Williamson wrote: > Thanks for the report. I think I found it. I'll do further testing > myself, but would appreciate if you're able to see if this clears the > problem. Thanks, Just tested it and the lockdep warning is gone. Thanks for y

Re: [PATCH 2/2] iommu/omap: Add support for configuring dsp iommus on DRA7xx

2015-07-23 Thread Tony Lindgren
* Suman Anna [150723 09:25]: > Hi Tony, > > On 07/23/2015 02:24 AM, Tony Lindgren wrote: > > * Suman Anna [150722 09:25]: > >> On 07/22/2015 12:26 AM, Tony Lindgren wrote: > >>> > >>> I don't like using syscon for tinkering directly with SoC registers. > >> > >> This is not a SoC-level register,

Re: [PATCH v3 3/6] iommu: add ARM short descriptor page table allocator.

2015-07-23 Thread Yong Wu
Hi Will, Thanks for your review so detail. When you are free, please help me check whether it's ok if it's changed like below. Thanks very much. On Tue, 2015-07-21 at 18:11 +0100, Will Deacon wrote: > Hello, > > This is looking better, but I still have some concerns. > > On Thu, Jul

Re: [PATCH v3 5/6] iommu/mediatek: Add mt8173 IOMMU driver

2015-07-23 Thread Yong Wu
On Tue, 2015-07-21 at 15:59 +0100, Will Deacon wrote: > Hi Yong Wu, > > On Thu, Jul 16, 2015 at 10:04:34AM +0100, Yong Wu wrote: > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > [...] > > > +static void mtk_iommu_tlb_flush_all(void *cookie) > > +{ > > +