> From: Markus Elfring
> Date: Thu, 5 Feb 2015 17:54:16 +0100
>
> The vfree() function performs also input parameter validation.
> Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
> ---
> drivers/iommu
On 2015/7/8 21:13, Robin Murphy wrote:
> On 07/07/15 04:30, Zhen Lei wrote:
>> For pci devices, only the root nodes have "iommus" property. So we
>> should traverse all of its sub nodes in of_xlate.
>
> I don't really follow this description; only the host controller is described
> in DT - the de
On Thu, Jul 09, 2015 at 12:10:11PM +0100, leizhen wrote:
> On 2015/7/8 21:13, Robin Murphy wrote:
> > On 07/07/15 04:30, Zhen Lei wrote:
> >> For pci devices, only the root nodes have "iommus" property. So we
> >> should traverse all of its sub nodes in of_xlate.
> >
> > I don't really follow this
On 09/07/15 02:56, leizhen wrote:
[...]
@@ -1928,9 +1929,35 @@ static int arm_smmu_of_xlate(struct device *dev, struct
of_phandle_args *args)
[...]
+for (i = 0; i < args->args_count; i++) {
I'm dubious of the value of looping here - having n>1 #iommu-cells per phandle
means that eve
On 7/8/2015 5:11 PM, Bjorn Helgaas wrote:
[+cc Rafael]
On Tue, Jul 07, 2015 at 01:14:27PM -0400, Mark Hounschell wrote:
On 07/07/2015 11:15 AM, Bjorn Helgaas wrote:
On Wed, May 20, 2015 at 08:11:17AM -0400, Mark Hounschell wrote:
Most currently available hardware doesn't allow reads but will
On 2015/7/9 20:01, Robin Murphy wrote:
> On 09/07/15 02:56, leizhen wrote:
> [...]
@@ -1928,9 +1929,35 @@ static int arm_smmu_of_xlate(struct device *dev,
struct of_phandle_args *args)
> [...]
+for (i = 0; i < args->args_count; i++) {
>>>
>>> I'm dubious of the value of loop
