Hi Suman,
Thank you for the review.
On Thursday 13 March 2014 19:07:33 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > The prot flags passed to the IOMMU map handler are defined in
> > include/linux/iommu.h as IOMMU_(READ|WRITE|CACHE|EXEC). However, the
> > driver expects
Hi Suman,
On Thursday 13 March 2014 17:16:07 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > The flush_iotlb_page() function prints a debug message when no
> > corresponding page was found in the TLB. That condition is incorrectly
> > checked and always resolves to true, gi
Hi Suman,
On Thursday 13 March 2014 17:27:38 Suman Anna wrote:
> Hi Laurent,
>
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > Flushing the TLB before updating translation entries creates a race
> > condition and can lead to stale TLB entries if a translation request
> > arrives between flu
On 14 March 2014 10:31, Cho KyongHo wrote:
> Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> removing remaining use of it from exynos-iommu driver, thus causing a
> compilation error.
>
> This patch fi
Hi Suman,
(CC'ing Joerg Roedel and Marek Szyprowski for the core IOMMU discussion)
On Thursday 13 March 2014 21:33:37 Suman Anna wrote:
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch set fixes miscellaneous issues with the OMAP IOMMU driver,
> > found when trying
> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
> Sent: Friday, March 14, 2014 7:00 PM
>
> On 14 March 2014 10:31, Cho KyongHo wrote:
> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
> > exynos tree) removed arch/arm/mach-exynos/mach/sysmmu.h header without
> > remo
On 14 March 2014 17:19, Cho KyongHo wrote:
>> From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
>> Sent: Friday, March 14, 2014 7:00 PM
>>
>> On 14 March 2014 10:31, Cho KyongHo wrote:
>> > Commit 25e9d28d92 (ARM: EXYNOS: remove system mmu initialization from
>> > exynos tree) removed arch/arm/
Hi KyongHo,
On 14.03.2014 06:06, Cho KyongHo wrote:
This adds gate clocks of all System MMUs and their master IPs
that are not apeared in clk-exynos5250.c and clk-exynos5420.c
Also fixes GATE_IP_ACP to 0x18800 and changed GATE_DA to GATE
for System MMU clocks in clk-exynos4.c
Signed-off-by: Cho
Hi KyongHo,
On 14.03.2014 06:06, Cho KyongHo wrote:
This patch adds dts entries for the System MMU devices found on
Exynos4 and Exynos5 SoC series and the System MMU binding
documentation.
CC: Rob Herring
CC: Sylwester Nawrocki
Signed-off-by: Cho KyongHo
---
.../bindings/iommu/samsung,exyn
Hi KyongHo,
On 14.03.2014 06:08, Cho KyongHo wrote:
Runtime power management by exynos-iommu driver independently from
master H/W's runtime pm is not useful for power saving since attaching
master H/W in probing time turns on its local power endlessly.
Thus this removes runtime pm API calls.
Run
Hi KyongHo,
On 14.03.2014 06:05, Cho KyongHo wrote:
System MMU driver is changed to control only a single instance of
System MMU at a time. Since a single instance of System MMU has only
a single clock descriptor for its clock gating, there is no need to
obtain two or more clock descriptors.
Hi KyongHo,
On 14.03.2014 06:05, Cho KyongHo wrote:
This patch uses managed device helper functions in the probe().
Signed-off-by: Cho KyongHo
---
drivers/iommu/exynos-iommu.c | 64 +-
1 file changed, 26 insertions(+), 38 deletions(-)
diff --git a/
Hi KyongHo,
On 14.03.2014 06:09, Cho KyongHo wrote:
This commit adds device tree support for System MMU.
Signed-off-by: Cho KyongHo
---
drivers/iommu/Kconfig|5 ++---
drivers/iommu/exynos-iommu.c | 21 +
2 files changed, 19 insertions(+), 7 deletions(-)
d
Hi KyongHo,
On 14.03.2014 06:09, Cho KyongHo wrote:
exynos-iommu driver must care about master H/W's gate clock as well as
System MMU's gate clock. To enhance readability of the source code,
macros to gate/ungate those clocks are defined.
Signed-off-by: Cho KyongHo
---
drivers/iommu/exynos-i
Hi KyongHo,
On 14 March 2014 10:35, Cho KyongHo wrote:
> This patch uses managed device helper functions in the probe().
>
> Signed-off-by: Cho KyongHo
> ---
[snip]
> + data->clk = devm_clk_get(dev, "sysmmu");
> + if (IS_ERR(data->clk)) {
> + dev_info(dev, "No gate clo
Hi KyongHo,
On 14 March 2014 10:39, Cho KyongHo wrote:
> This commit adds device tree support for System MMU.
>
> Signed-off-by: Cho KyongHo
> ---
> drivers/iommu/Kconfig|5 ++---
> drivers/iommu/exynos-iommu.c | 21 +
> 2 files changed, 19 insertions(+), 7 del
Hi KyongHo,
On 14.03.2014 06:10, Cho KyongHo wrote:
This adds support for Suspend to RAM and Runtime Power Management.
Since System MMU is located in the same local power domain of its
master H/W, System MMU must be initialized before it is working if
its power domain was ever turned off. TLB i
Hi KyongHo,
On 14.03.2014 06:10, Cho KyongHo wrote:
Some master device descriptor like fimc-is which is an abstraction
of very complex H/W may have multiple System MMUs. For those devices,
the design of the link between System MMU and its master H/W is needed
to be reconsidered.
A link structur
Hi Santosh,
On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote:
> + Russell, Arnd
>
> On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote:
> > On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
> >> The page table entries must be cleaned from the cache before being
> >> accessed by the IOMMU
Hi KyongHo,
On 14 March 2014 19:13, Tomasz Figa wrote:
> Hi KyongHo,
>
>
> On 14.03.2014 06:09, Cho KyongHo wrote:
>>
>> exynos-iommu driver must care about master H/W's gate clock as well as
>> System MMU's gate clock. To enhance readability of the source code,
>> macros to gate/ungate those cl
On Friday 14 March 2014, Santosh Shilimkar wrote:
> I remember NAKing this approach in past and my stand remains same.
> The cache APIs which you are trying to use here are not suppose
> to be used outside.
>
> I think the right way to fix this is to make use of streaming APIs.
> If needed, IOMMU
On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote:
> Hi Santosh,
>
> On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote:
>> + Russell, Arnd
>>
>> On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote:
>>> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
The page table entries must
+ Russell, Arnd
On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote:
> Hi Laurent,
>
> On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
>> The page table entries must be cleaned from the cache before being
>> accessed by the IOMMU. Instead of implementing cache management manually
>> (and ignori
On Friday 14 March 2014 12:57 PM, Arnd Bergmann wrote:
> On Friday 14 March 2014, Santosh Shilimkar wrote:
>> I remember NAKing this approach in past and my stand remains same.
>> The cache APIs which you are trying to use here are not suppose
>> to be used outside.
>>
>> I think the right way to f
Hi Laurent,
On 03/14/2014 04:46 AM, Laurent Pinchart wrote:
Hi Suman,
Thank you for the review.
On Thursday 13 March 2014 19:07:33 Suman Anna wrote:
On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
The prot flags passed to the IOMMU map handler are defined in
include/linux/iommu.h as IOMMU_(R
Hi Laurent,
>>
On 03/07/2014 06:46 PM, Laurent Pinchart wrote:
Flushing the TLB before updating translation entries creates a race
condition and can lead to stale TLB entries if a translation request
arrives between flushing the TLB and updating the translation entries.
As there's no requiremen
Hi Santosh, Laurent, Russell, Arnd,
On 03/14/2014 12:51 PM, Santosh Shilimkar wrote:
On Friday 14 March 2014 12:38 PM, Laurent Pinchart wrote:
Hi Santosh,
On Friday 14 March 2014 12:15:11 Santosh Shilimkar wrote:
+ Russell, Arnd
On Thursday 13 March 2014 10:47 PM, Anna, Suman wrote:
On 03/0
Please apply this. It's way overdue. It fixes customer kernel crashes
we've seen in the field.
I'd also advocate for seeing this be applied to stable kernels.
thanks,
grant
On Thu, Mar 13, 2014 at 10:02 PM, Cho KyongHo wrote:
> This commit adds cache flush for removed small and large page entr
28 matches
Mail list logo
