Re: [GIT PULL] remove dma_zalloc_coherent

2019-01-12 Thread pr-tracker-bot
The pull request you sent on Sat, 12 Jan 2019 19:13:55 +0100: > git://git.infradead.org/users/hch/dma-mapping.git > tags/remove-dma_zalloc_coherent-5.0 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/66c56cfa64d9dbb9efa8a06c1aece77e8d57ea19 Thank you! -- Dee

Re: [GIT PULL] remove dma_zalloc_coherent

2019-01-12 Thread Linus Torvalds
On Sat, Jan 12, 2019 at 10:31 AM Christoph Hellwig wrote: > > Many users don't need it for security reasons, but given that x86 > and arm have done it forever various drivers started relying on the > behavior. Ok, I guess that's a pretty strong argument. Linus _

Re: [GIT PULL] remove dma_zalloc_coherent

2019-01-12 Thread Linus Torvalds
On Sat, Jan 12, 2019 at 10:14 AM Christoph Hellwig wrote: > > Lets see if this works better as a pull request than the > plain patches: So I'm still debating this myself, which is why I haven't reacted. The reason I'm not entirely sure this makes sense is that not every user actually mmaps thing

Re: [GIT PULL] remove dma_zalloc_coherent

2019-01-12 Thread Christoph Hellwig
On Sat, Jan 12, 2019 at 10:27:58AM -0800, Linus Torvalds wrote: > So I'm still debating this myself, which is why I haven't reacted. > > The reason I'm not entirely sure this makes sense is that not every > user actually mmaps things into user space. While that is the security reason for it, we a

[GIT PULL] remove dma_zalloc_coherent

2019-01-12 Thread Christoph Hellwig
generic-y += shmparam.h for some architectures (2019-01-06 18:16:11 -0800) are available in the Git repository at: git://git.infradead.org/users/hch/dma-mapping.git tags/remove-dma_zalloc_coherent-5.0 for you to fetch changes up to dfd32cad146e3624970eee9329e99d2c6ef751b3: dma-mappi

Re: remove dma_zalloc_coherent

2019-01-11 Thread Christoph Hellwig
Linus, any chance you could take this before -rc2? That should avoid a lot of churn going forward. Any fine tuning of the memset-removal cochinnelle scripts can be queued up with normal updates. On Tue, Jan 08, 2019 at 08:06:58AM -0500, Christoph Hellwig wrote: > Hi Linus and world, > > We've

Re: [PATCH 3/3] dma-mapping: remove dma_zalloc_coherent()

2019-01-08 Thread Julia Lawall
On Tue, 8 Jan 2019, Christoph Hellwig wrote: > From: Luis Chamberlain > > dma_zalloc_coherent() is no longer needed as it has no users because > dma_alloc_coherent() already zeroes out memory for us. > > The Coccinelle grammar rule that used to check for dma_alloc_coherent() > + memset() is mo

Re: remove dma_zalloc_coherent

2019-01-08 Thread Julia Lawall
On Tue, 8 Jan 2019, Julia Lawall wrote: > > > On Tue, 8 Jan 2019, Christoph Hellwig wrote: > > > Hi Linus and world, > > > > We've always had a weird situation around dma_zalloc_coherent. To > > safely support mapping the allocations to userspace major architectures > > like x86 and arm have a

Re: remove dma_zalloc_coherent

2019-01-08 Thread Julia Lawall
On Tue, 8 Jan 2019, Christoph Hellwig wrote: > Hi Linus and world, > > We've always had a weird situation around dma_zalloc_coherent. To > safely support mapping the allocations to userspace major architectures > like x86 and arm have always zeroed allocations from dma_alloc_coherent, > but a

remove dma_zalloc_coherent

2019-01-08 Thread Christoph Hellwig
Hi Linus and world, We've always had a weird situation around dma_zalloc_coherent. To safely support mapping the allocations to userspace major architectures like x86 and arm have always zeroed allocations from dma_alloc_coherent, but a couple other architectures were missing that zeroing either

[PATCH 3/3] dma-mapping: remove dma_zalloc_coherent()

2019-01-08 Thread Christoph Hellwig
From: Luis Chamberlain dma_zalloc_coherent() is no longer needed as it has no users because dma_alloc_coherent() already zeroes out memory for us. The Coccinelle grammar rule that used to check for dma_alloc_coherent() + memset() is modified so that it just tells the user that the memset is not