Re: [PATCH v4 0/7] Use 1st-level for IOVA translation

2019-12-21 Thread Lu Baolu
Hi Yi, On 12/21/19 11:14 AM, Lu Baolu wrote: Hi again, On 2019/12/20 19:50, Liu, Yi L wrote: 3) Per VT-d spec, FLPT has canonical requirement to the input addresses. So I'd suggest to add some enhance regards to it. Please refer to chapter 3.6:-). 3.6 First-Level Translation First-level trans

Re: [PATCH v4 0/7] Use 1st-level for IOVA translation

2019-12-20 Thread Lu Baolu
Hi again, On 2019/12/20 19:50, Liu, Yi L wrote: 3) Per VT-d spec, FLPT has canonical requirement to the input addresses. So I'd suggest to add some enhance regards to it. Please refer to chapter 3.6:-). 3.6 First-Level Translation First-level translation restricts the input-address to a canonic

Re: [PATCH v4 0/7] Use 1st-level for IOVA translation

2019-12-20 Thread Lu Baolu
Hi Yi, Thanks for the comments. On 12/20/19 7:50 PM, Liu, Yi L wrote: Hi Baolu, In a brief, this version is pretty good to me. However, I still want to have the following checks to see if anything missed. Wish it helps. 1) would using IOVA over FLPT default on? My opinion is that before we ha

RE: [PATCH v4 0/7] Use 1st-level for IOVA translation

2019-12-20 Thread Liu, Yi L
Hi Baolu, In a brief, this version is pretty good to me. However, I still want to have the following checks to see if anything missed. Wish it helps. 1) would using IOVA over FLPT default on? My opinion is that before we have got gIOVA nested translation done for passthru devices, we should make