Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-10-06 Thread Will Deacon
Hi Alex, On Wed, Jul 09, 2014 at 03:13:04PM +0100, Alex Williamson wrote: > On Wed, 2014-07-09 at 14:26 +0100, Will Deacon wrote: > > pci_find_dma_isolation_root doesn't exist in any of the trees I have. Alex, > > is this queued anywhere and do I actually need it? > > That function was in the v3

Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-09 Thread Will Deacon
On Wed, Jul 09, 2014 at 03:13:04PM +0100, Alex Williamson wrote: > On Wed, 2014-07-09 at 14:26 +0100, Will Deacon wrote: > > [Adding Alex; question below] > > > > On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: > > > > +static int __arm_smmu_get_pci_sid(struct pci_dev *pdev, u16 alias

RE: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-09 Thread Varun Sethi
ed...@gmail.com; a...@arndb.de; > ohau...@codeaurora.org; j...@8bytes.org; > a.mota...@virtualopensystems.com; Marc Zyngier > Subject: Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master > devices > > [Adding Alex; question below] > > On Thu, Jul 03, 2014 at 03:22:37PM +

Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-09 Thread Alex Williamson
On Wed, 2014-07-09 at 14:26 +0100, Will Deacon wrote: > [Adding Alex; question below] > > On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: > > > +static int __arm_smmu_get_pci_sid(struct pci_dev *pdev, u16 alias, void > > > +*data) { > > > + *((u16 *)data) = alias; > > > + retu

Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-09 Thread Will Deacon
[Adding Alex; question below] On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: > > +static int __arm_smmu_get_pci_sid(struct pci_dev *pdev, u16 alias, void > > +*data) { > > + *((u16 *)data) = alias; > > + return 0; /* Continue walking */ > > +} [...] > > @@ -1598,15 +1642,36

Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-04 Thread Will Deacon
On Fri, Jul 04, 2014 at 08:41:53AM +0100, Varun Sethi wrote: > Hi Will, Hey Varun, > > Once Thierry's generic IOMMU binding is sorted, we should look at adding > > support for the Stream ID description. Have you looked at that at all? > > > Yes, I have looked at the bindings. Would we need to re

RE: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-04 Thread Varun Sethi
.@arndb.de; > ohau...@codeaurora.org; j...@8bytes.org; > a.mota...@virtualopensystems.com; Marc Zyngier > Subject: Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master > devices > > On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: > > Hi Will, > > Hi Varun, > &

Re: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-03 Thread Will Deacon
On Thu, Jul 03, 2014 at 03:22:37PM +0100, Varun Sethi wrote: > Hi Will, Hi Varun, Thanks for taking a look at this! > > +static struct arm_smmu_master_cfg * > > +find_smmu_master_cfg(struct arm_smmu_device *smmu, struct device *dev) > > +{ > > + struct arm_smmu_master *master; > > + > > +

RE: [PATCH 2/5] iommu/arm-smmu: add support for PCI master devices

2014-07-03 Thread Varun Sethi
Hi Will, > -Original Message- > From: Will Deacon [mailto:will.dea...@arm.com] > Sent: Monday, June 30, 2014 4:22 PM > To: linux-arm-ker...@lists.infradead.org; iommu@lists.linux- > foundation.org > Cc: thierry.red...@gmail.com; a...@arndb.de; ohau...@codeaurora.org; > Sethi Varun-B16395;