RE: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-02-01 Thread Sethi Varun-B16395
ernel.org; > iommu@lists.linux-foundation.org; Wood Scott-B07421; David Brown; David > Woodhouse > Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY > attribute > > On Thu, Jan 19, 2012 at 05:27:09PM +0100, Laurent Pinchart wrote: > > > Well, u64 is a cat

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-30 Thread Joerg Roedel
On Mon, Jan 30, 2012 at 06:27:30AM +, Sethi Varun-B16395 wrote: > Can you please explain how would IOMMU remapping be used, based on the > force_aperture flag. If force_aperture is flase the dma-api code needs to check if remapping is required at all. It performs the following checks:

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-30 Thread Joerg Roedel
On Fri, Jan 27, 2012 at 03:22:43PM -0600, Scott Wood wrote: > OK, so there's a geometry that is read-only, and potentially a > driver-specific geometry that is read/write. The default config for > PAMU would likely be a 1 MiB aperture in which the dma api can do > arbitrary 4k mappings -- this fi

RE: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-29 Thread Sethi Varun-B16395
ernel.org; Laurent > Pinchart; Wood Scott-B07421; David Brown; David Woodhouse > Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY > attribute > > On Thu, Jan 26, 2012 at 12:42:10PM -0600, Scott Wood wrote: > > On 01/26/2012 12:31 PM, Joerg Roedel wrote: > > &g

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-27 Thread Joerg Roedel
On Thu, Jan 26, 2012 at 02:02:26PM -0600, Scott Wood wrote: > On 01/26/2012 01:44 PM, Joerg Roedel wrote: > >>> Another reason why it must be in the generic struct is the intended > >>> generic dma-ops layer on-top. This code can decide on this flag wheter a > >>> address needs to be remapped at a

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-26 Thread Joerg Roedel
On Thu, Jan 26, 2012 at 01:00:37PM -0600, Scott Wood wrote: > On 01/26/2012 12:51 PM, Joerg Roedel wrote: > > Because this is a flag that makes sense for all IOMMU. Every IOMMU > > either allows DMA outside its aperture or it doesn't. > > > > Another reason why it must be in the generic struct is

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-26 Thread Joerg Roedel
On Thu, Jan 26, 2012 at 12:42:10PM -0600, Scott Wood wrote: > On 01/26/2012 12:31 PM, Joerg Roedel wrote: > > The force_aperture flag indicated whether DMA is only allowed between > > aperture_start and apertuer_end or if DMA is allowed outside of this > > range too (unmapped in this case). > > >

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-26 Thread Joerg Roedel
On Thu, Jan 26, 2012 at 12:25:32PM -0600, Scott Wood wrote: > On 01/20/2012 10:03 AM, Joerg Roedel wrote: > > Because the values in this generic geometry-struct make sense for more > > than one IOMMU (short-term for Tegra GART and Freescale PAMU). If you > > have additional vendor-specific ones you

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-20 Thread Joerg Roedel
On Thu, Jan 19, 2012 at 05:16:48PM +, Sethi Varun-B16395 wrote: > > struct iommu_domain { > > struct iommu_ops *ops; > > void *priv; > > iommu_fault_handler_t handler; > > + struct iommu_domain_geometry geometry; > > }; > In case of our iommu implementation the iommu_domain_geom

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-20 Thread Joerg Roedel
On Thu, Jan 19, 2012 at 05:27:09PM +0100, Laurent Pinchart wrote: > > Well, u64 is a catch-all datatype which should suit all drivers. Is this > > a problem at ARM? > > No, it's not a problem for ARM, at least to my knowledge. It just struck me > as > weird, as we have specific data types for ot

RE: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-19 Thread Sethi Varun-B16395
> -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of Joerg Roedel > Sent: Thursday, January 19, 2012 8:00 PM > To: iommu@lists.linux-foundation.org > Cc: Ohad Ben-Cohen; Tony Lindgren; Hiroshi DOYU; linux-

Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute

2012-01-19 Thread Hiroshi Doyu
From: Laurent Pinchart Subject: Re: [PATCH 2/5] iommu/amd: Implement DOMAIN_ATTR_GEOMETRY attribute Date: Thu, 19 Jan 2012 17:27:09 +0100 Message-ID: <201201191727.10176.laurent.pinch...@ideasonboard.com> > Hi Joerg, > > On Thursday 19 January 2012 17:07:39 Joerg Roedel wrote: