Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-05-26 Thread Luis R. Rodriguez
On Mon, Apr 25, 2016 at 12:23:51PM +0200, Joerg Roedel wrote: > On Mon, Apr 18, 2016 at 02:03:50PM +0200, Luis R. Rodriguez wrote: > > You said that with my patch you saw AMD IOMMUv2 kick off first, > > that was intentional as I thought that's what you needed. Can > > someone please describe the re

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-05-26 Thread Luis R. Rodriguez
On Tue, Apr 19, 2016 at 10:02:52AM +0800, Wan Zongshun wrote: > > You have to take carefully to arrange the calling sequence for > iommuv1, iommuv2, kfd module, and drm like the following sequence : > v1 ->v2->kfd, drm. > > iommuv1 -- rootfs_initcall(fn) > IOMMUV2 -- device_initcall(fn) > kfd mod

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-25 Thread Joerg Roedel
On Mon, Apr 18, 2016 at 02:03:50PM +0200, Luis R. Rodriguez wrote: > You said that with my patch you saw AMD IOMMUv2 kick off first, > that was intentional as I thought that's what you needed. Can > someone please describe the requirements? > > Also what does drm use that you say has a conflict al

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-18 Thread Wan Zongshun
Original Message On Mon, Apr 18, 2016 at 10:02:24AM +0300, Oded Gabbay wrote: On Mon, Apr 18, 2016 at 9:55 AM, Luis R. Rodriguez wrote: On Apr 18, 2016 7:48 AM, "Oded Gabbay" wrote: On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez wrote: On Mon, Apr 11, 2016 at 03:5

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-18 Thread Luis R. Rodriguez
On Mon, Apr 18, 2016 at 10:02:24AM +0300, Oded Gabbay wrote: > On Mon, Apr 18, 2016 at 9:55 AM, Luis R. Rodriguez wrote: > > > > On Apr 18, 2016 7:48 AM, "Oded Gabbay" wrote: > >> > >> On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez > >> wrote: > >> > On Mon, Apr 11, 2016 at 03:52:43PM +0200,

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-18 Thread Oded Gabbay
On Mon, Apr 18, 2016 at 9:55 AM, Luis R. Rodriguez wrote: > > On Apr 18, 2016 7:48 AM, "Oded Gabbay" wrote: >> >> On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez >> wrote: >> > On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: >> >> Am 11.04.2016 um 15:39 schrieb Oded Gabbay: >

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-17 Thread Luis R. Rodriguez
On Apr 18, 2016 7:48 AM, "Oded Gabbay" wrote: > > On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez wrote: > > On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: > >> Am 11.04.2016 um 15:39 schrieb Oded Gabbay: > >> >On Mon, Apr 11, 2016 at 4:28 PM, Christian König > >> > wrote: >

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-17 Thread Oded Gabbay
On Wed, Apr 13, 2016 at 1:07 AM, Luis R. Rodriguez wrote: > On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: >> Am 11.04.2016 um 15:39 schrieb Oded Gabbay: >> >On Mon, Apr 11, 2016 at 4:28 PM, Christian König >> > wrote: >> >>Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: >> >>>

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-12 Thread Luis R. Rodriguez
On Mon, Apr 11, 2016 at 03:52:43PM +0200, Christian König wrote: > Am 11.04.2016 um 15:39 schrieb Oded Gabbay: > >On Mon, Apr 11, 2016 at 4:28 PM, Christian König > > wrote: > >>Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: > >>>On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez > >>>wrote:

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-11 Thread Christian König
Am 11.04.2016 um 15:39 schrieb Oded Gabbay: On Mon, Apr 11, 2016 at 4:28 PM, Christian König wrote: Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: We need to ensure amd iommu v2 initializes before driver uses such as drivers/gpu/d

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-11 Thread Oded Gabbay
On Mon, Apr 11, 2016 at 4:28 PM, Christian König wrote: > > Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: >> >> On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez >> wrote: >>> >>> We need to ensure amd iommu v2 initializes before >>> driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_modul

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-11 Thread Christian König
Am 09.04.2016 um 02:25 schrieb Luis R. Rodriguez: On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: We need to ensure amd iommu v2 initializes before driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, to do this make its init routine a subsys_initcall() which ensures its load

Re: [RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-04-08 Thread Luis R. Rodriguez
On Tue, Mar 29, 2016 at 10:41 AM, Luis R. Rodriguez wrote: > We need to ensure amd iommu v2 initializes before > driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, > to do this make its init routine a subsys_initcall() which > ensures its load init is called first than modules when > bui

[RFT v2] iommu/amd: use subsys_initcall() on amdv2 iommu

2016-03-29 Thread Luis R. Rodriguez
We need to ensure amd iommu v2 initializes before driver uses such as drivers/gpu/drm/amd/amdkfd/kfd_module.c, to do this make its init routine a subsys_initcall() which ensures its load init is called first than modules when built-in. This reverts the old work around implemented through commit 1b