Re: [RFC PATCH v6 17/20] vfio: add local lock in virqfd instead of depending on VFIO PCI

2014-06-06 Thread Antonios Motakis
On Fri, Jun 6, 2014 at 12:19 AM, Alex Williamson wrote: > On Thu, 2014-06-05 at 19:03 +0200, Antonios Motakis wrote: >> Sharing the same spinlock with the VFIO bus driver is not necessary for >> the virqfd code, so remove that dependency. > > I like the idea of consolidating this code, but I need

Re: [RFC PATCH v6 17/20] vfio: add local lock in virqfd instead of depending on VFIO PCI

2014-06-05 Thread Alex Williamson
On Thu, 2014-06-05 at 19:03 +0200, Antonios Motakis wrote: > Sharing the same spinlock with the VFIO bus driver is not necessary for > the virqfd code, so remove that dependency. I like the idea of consolidating this code, but I need more justification for why the use of the lock here is independe

[RFC PATCH v6 17/20] vfio: add local lock in virqfd instead of depending on VFIO PCI

2014-06-05 Thread Antonios Motakis
Sharing the same spinlock with the VFIO bus driver is not necessary for the virqfd code, so remove that dependency. Signed-off-by: Antonios Motakis --- drivers/vfio/pci/vfio_pci_intrs.c | 10 +- drivers/vfio/virqfd.c | 24 +--- include/linux/vfio.h