Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:35 PM, Arnd Bergmann wrote: > On Thu, Jul 6, 2017 at 4:24 PM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 11:17 PM, Tomasz Figa wrote: >>> On Thu, Jul 6, 2017 at 11:10 PM, Christoph Hellwig wrote: On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote:

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Arnd Bergmann
On Thu, Jul 6, 2017 at 4:24 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 11:17 PM, Tomasz Figa wrote: >> On Thu, Jul 6, 2017 at 11:10 PM, Christoph Hellwig wrote: >>> On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote: I suppose another option is to just make the IOMMU and DMA

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:17 PM, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 11:10 PM, Christoph Hellwig wrote: >> On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote: >>> I suppose another option is to just make the IOMMU and DMA ops a >>> self-contained non-modular driver mirroring the

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:10 PM, Christoph Hellwig wrote: > On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote: >> I suppose another option is to just make the IOMMU and DMA ops a >> self-contained non-modular driver mirroring the VT-d/AMD-Vi IOMMUs - >> AFAICS it shouldn't have to be al

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 12:09:45PM +0100, Robin Murphy wrote: > I suppose another option is to just make the IOMMU and DMA ops a > self-contained non-modular driver mirroring the VT-d/AMD-Vi IOMMUs - > AFAICS it shouldn't have to be all that tightly coupled to the IPU bus > code, the latter more or

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-06 Thread Robin Murphy
On 06/07/17 03:25, Tomasz Figa wrote: > On Thu, Jul 6, 2017 at 1:22 AM, Robin Murphy wrote: >> On 05/07/17 08:12, Tomasz Figa wrote: >>> There is nothing wrong in having a loadable module implementing DMA API, >>> for example to be used for sub-devices registered by the module. However, >>> most o

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-05 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 1:22 AM, Robin Murphy wrote: > On 05/07/17 08:12, Tomasz Figa wrote: >> There is nothing wrong in having a loadable module implementing DMA API, >> for example to be used for sub-devices registered by the module. However, >> most of the functions from dma-iommu do not have t

Re: [RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-05 Thread Robin Murphy
On 05/07/17 08:12, Tomasz Figa wrote: > There is nothing wrong in having a loadable module implementing DMA API, > for example to be used for sub-devices registered by the module. However, > most of the functions from dma-iommu do not have their symbols exported, > making it impossible to use them

[RFC PATCH 4/5] iommu/dma: Export non-static functions to use in modules

2017-07-05 Thread Tomasz Figa
There is nothing wrong in having a loadable module implementing DMA API, for example to be used for sub-devices registered by the module. However, most of the functions from dma-iommu do not have their symbols exported, making it impossible to use them from loadable modules. Export all the non-sta