Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-28 Thread Will Deacon
On Tue, Jan 27, 2015 at 12:38:09PM +, Joerg Roedel wrote: > On Tue, Jan 27, 2015 at 12:27:39PM +, Robin Murphy wrote: > > Laz^WPragmatism - I'm expecting quite a lot of changes to get this > > looking good, so keeping the series as lean as possible to aid > > reviewing/rebasing/etc. seemed

Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-27 Thread Joerg Roedel
On Tue, Jan 27, 2015 at 12:27:39PM +, Robin Murphy wrote: > Laz^WPragmatism - I'm expecting quite a lot of changes to get this > looking good, so keeping the series as lean as possible to aid > reviewing/rebasing/etc. seemed sensible. In the same vein, since the > other architectures already ha

Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-27 Thread Robin Murphy
Hi Joerg, On 27/01/15 00:21, Joerg Roedel wrote: Hi Robin, thanks for the patch, I think it is good start to move forward. See my comments below. On Mon, Jan 12, 2015 at 08:48:55PM +, Robin Murphy wrote: Taking inspiration from the existing arch/arm code, break out some generic functions

Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-26 Thread Joerg Roedel
Hi Robin, thanks for the patch, I think it is good start to move forward. See my comments below. On Mon, Jan 12, 2015 at 08:48:55PM +, Robin Murphy wrote: > Taking inspiration from the existing arch/arm code, break out some > generic functions to interface the DMA-API to the IOMMU-API. This w

Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-23 Thread Robin Murphy
Hi Laura, Thanks for looking On 23/01/15 17:42, Laura Abbott wrote: On 1/12/2015 12:48 PM, Robin Murphy wrote: Taking inspiration from the existing arch/arm code, break out some generic functions to interface the DMA-API to the IOMMU-API. This will do the bulk of the heavy lifting for IOMMU-ba

Re: [RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-23 Thread Laura Abbott
On 1/12/2015 12:48 PM, Robin Murphy wrote: Taking inspiration from the existing arch/arm code, break out some generic functions to interface the DMA-API to the IOMMU-API. This will do the bulk of the heavy lifting for IOMMU-backed dma-mapping. Whilst the target is arm64, rather than introduce ye

[RFC PATCH 3/5] iommu: implement common IOMMU ops for DMA mapping

2015-01-12 Thread Robin Murphy
Taking inspiration from the existing arch/arm code, break out some generic functions to interface the DMA-API to the IOMMU-API. This will do the bulk of the heavy lifting for IOMMU-backed dma-mapping. Whilst the target is arm64, rather than introduce yet another private implementation, place this