Re: [RFC 3/3] iommu/arm-smmu: detach DMA domain if driver is managing iommu

2017-02-02 Thread Rob Clark
On Wed, Feb 1, 2017 at 11:10 PM, Sricharan wrote: > Hi Rob, > >>On Wed, Feb 1, 2017 at 10:23 AM, Rob Clark wrote: >>> Before the driver is probed, arm_smmu_add_device() helpfully attaches >>> an IOMMU_DOMAIN_DMA domain. Which ofc does not support stalling, and >>> when the driver later attaches

Re: [RFC 3/3] iommu/arm-smmu: detach DMA domain if driver is managing iommu

2017-02-02 Thread Rob Clark
On Wed, Feb 1, 2017 at 11:10 PM, Sricharan wrote: > Hi Rob, > >>On Wed, Feb 1, 2017 at 10:23 AM, Rob Clark wrote: >>> Before the driver is probed, arm_smmu_add_device() helpfully attaches >>> an IOMMU_DOMAIN_DMA domain. Which ofc does not support stalling, and >>> when the driver later attaches

RE: [RFC 3/3] iommu/arm-smmu: detach DMA domain if driver is managing iommu

2017-02-01 Thread Sricharan
Hi Rob, >On Wed, Feb 1, 2017 at 10:23 AM, Rob Clark wrote: >> Before the driver is probed, arm_smmu_add_device() helpfully attaches >> an IOMMU_DOMAIN_DMA domain. Which ofc does not support stalling, and >> when the driver later attaches a domain that can_stall to an smmu that >> can stall, the

Re: [RFC 3/3] iommu/arm-smmu: detach DMA domain if driver is managing iommu

2017-02-01 Thread Rob Clark
On Wed, Feb 1, 2017 at 10:23 AM, Rob Clark wrote: > Before the driver is probed, arm_smmu_add_device() helpfully attaches > an IOMMU_DOMAIN_DMA domain. Which ofc does not support stalling, and > when the driver later attaches a domain that can_stall to an smmu that > can stall, the default _DMA d

[RFC 3/3] iommu/arm-smmu: detach DMA domain if driver is managing iommu

2017-02-01 Thread Rob Clark
Before the driver is probed, arm_smmu_add_device() helpfully attaches an IOMMU_DOMAIN_DMA domain. Which ofc does not support stalling, and when the driver later attaches a domain that can_stall to an smmu that can stall, the default _DMA domain prevents stalling from being enabled. (And will cause