Re: [Patch v3 05/12] iommu/amd: change IOMMU_PTE_P to IOMMU_PTE_V

2016-01-28 Thread Baoquan He
On 01/29/16 at 10:55am, Wan Zongshun wrote: > > > Original Message > >On 01/27/16 at 06:18pm, Wan Zongshun wrote: > >> > >> > >> Original Message > >>>In amd-vi spec the name of bit0 in DTE is V. But in code it's defined > >>>as IOMMU_PTE_P. Here change it to IO

Re: [Patch v3 05/12] iommu/amd: change IOMMU_PTE_P to IOMMU_PTE_V

2016-01-28 Thread Wan Zongshun
Original Message On 01/27/16 at 06:18pm, Wan Zongshun wrote: Original Message In amd-vi spec the name of bit0 in DTE is V. But in code it's defined as IOMMU_PTE_P. Here change it to IOMMU_PTE_V to make it be consistent with spec. Hi, Baoquan This shoul

Re: [Patch v3 05/12] iommu/amd: change IOMMU_PTE_P to IOMMU_PTE_V

2016-01-28 Thread Baoquan He
On 01/27/16 at 06:18pm, Wan Zongshun wrote: > > > Original Message > >In amd-vi spec the name of bit0 in DTE is V. But in code it's defined > >as IOMMU_PTE_P. Here change it to IOMMU_PTE_V to make it be consistent > >with spec. > > Hi, Baoquan > > This should be PR bit which m

Re: [Patch v3 05/12] iommu/amd: change IOMMU_PTE_P to IOMMU_PTE_V

2016-01-27 Thread Wan Zongshun
Original Message In amd-vi spec the name of bit0 in DTE is V. But in code it's defined as IOMMU_PTE_P. Here change it to IOMMU_PTE_V to make it be consistent with spec. Hi, Baoquan This should be PR bit which means present, So maybe you got confusion between DTE and PTE ta

[Patch v3 05/12] iommu/amd: change IOMMU_PTE_P to IOMMU_PTE_V

2016-01-26 Thread Baoquan He
In amd-vi spec the name of bit0 in DTE is V. But in code it's defined as IOMMU_PTE_P. Here change it to IOMMU_PTE_V to make it be consistent with spec. Signed-off-by: Baoquan He --- drivers/iommu/amd_iommu.c | 10 +- drivers/iommu/amd_iommu_types.h | 6 +++--- 2 files changed, 8 i