Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-12-13 Thread Daniel P. Smith
On 12/12/24 17:30, Andy Lutomirski wrote: On Thu, Dec 12, 2024 at 11:56 AM Daniel P. Smith wrote: Hey Luto! Let me try to address your concerns below. On 11/18/24 15:02, Andy Lutomirski wrote: On Mon, Nov 18, 2024 at 11:12 AM James Bottomley wrote: On Mon, 2024-11-18 at 10:43 -0800, Andy

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-12-12 Thread Andy Lutomirski
On Thu, Dec 12, 2024 at 11:56 AM Daniel P. Smith wrote: > > Hey Luto! > > Let me try to address your concerns below. > > On 11/18/24 15:02, Andy Lutomirski wrote: > > On Mon, Nov 18, 2024 at 11:12 AM James Bottomley > > wrote: > >> > >> On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: >

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-12-12 Thread Daniel P. Smith
Hey Luto! Let me try to address your concerns below. On 11/18/24 15:02, Andy Lutomirski wrote: On Mon, Nov 18, 2024 at 11:12 AM James Bottomley wrote: On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should exclusively

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-22 Thread ross . philipson
On 11/21/24 2:42 PM, Andy Lutomirski wrote: On Thu, Nov 21, 2024 at 12:54 PM Andy Lutomirski wrote: On Thu, Nov 21, 2024 at 12:11 PM wrote: On 11/18/24 12:02 PM, Andy Lutomirski wrote: If the vendor of an attestation-dependent thing trusts SM3 but *Linux* does not like SM3, then the vend

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-21 Thread Andy Lutomirski
On Thu, Nov 21, 2024 at 12:54 PM Andy Lutomirski wrote: > > On Thu, Nov 21, 2024 at 12:11 PM wrote: > > > > On 11/18/24 12:02 PM, Andy Lutomirski wrote: > > > > If the vendor of an attestation-dependent thing trusts SM3 but *Linux* > > > does not like SM3, then the vendor's software should not be

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-21 Thread Andy Lutomirski
On Thu, Nov 21, 2024 at 12:11 PM wrote: > > On 11/18/24 12:02 PM, Andy Lutomirski wrote: > > If the vendor of an attestation-dependent thing trusts SM3 but *Linux* > > does not like SM3, then the vendor's software should not become wildly > > insecure because Linux does not like SM3. And, as tha

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-21 Thread ross . philipson
On 11/18/24 12:02 PM, Andy Lutomirski wrote: On Mon, Nov 18, 2024 at 11:12 AM James Bottomley wrote: On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should exclusively use TPM2_PCR_Event. I would expect that passing, sa

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Mon, Nov 18, 2024 at 11:12 AM James Bottomley wrote: > > On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: > > Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should > > exclusively use TPM2_PCR_Event. I would expect that passing, say, > > the entire kernel image to TPM2

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread James Bottomley
On Mon, 2024-11-18 at 10:43 -0800, Andy Lutomirski wrote: > Linux should not use TPM2_PCR_Extend *at all*.  Instead, Linux should > exclusively use TPM2_PCR_Event.  I would expect that passing, say, > the entire kernel image to TPM2_PCR_Event would be a big mistake, so > instead Linux should hash t

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Mon, Nov 18, 2024 at 10:43 AM Andy Lutomirski wrote: > > Linux should not use TPM2_PCR_Extend *at all*. Instead, Linux should > exclusively use TPM2_PCR_Event. I would expect that passing, say, the > entire kernel image to TPM2_PCR_Event would be a big mistake, so > instead Linux should hash

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-18 Thread Andy Lutomirski
On Thu, Nov 14, 2024 at 5:17 PM Daniel P. Smith wrote: > > On 11/2/24 12:04, James Bottomley wrote: > > On Sat, 2024-11-02 at 10:53 -0400, Daniel P. Smith wrote: > >> Hi Luto, > >> > >> My apologies, I missed this response and the active on v11 cause me > >> to > >> get an inquiry why I hadn't res

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-14 Thread Daniel P. Smith
On 11/2/24 12:04, James Bottomley wrote: On Sat, 2024-11-02 at 10:53 -0400, Daniel P. Smith wrote: Hi Luto, My apologies, I missed this response and the active on v11 cause me to get an inquiry why I hadn't responded. On 9/21/24 18:40, Andy Lutomirski wrote: [...] I assumed that "deliberatel

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-02 Thread James Bottomley
On Sat, 2024-11-02 at 10:53 -0400, Daniel P. Smith wrote: > Hi Luto, > > My apologies, I missed this response and the active on v11 cause me > to > get an inquiry why I hadn't responded. > > On 9/21/24 18:40, Andy Lutomirski wrote: [...] > > I assumed that "deliberately cap" meant that there was

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-11-02 Thread Daniel P. Smith
Hi Luto, My apologies, I missed this response and the active on v11 cause me to get an inquiry why I hadn't responded. On 9/21/24 18:40, Andy Lutomirski wrote: On Sat, Sep 21, 2024 at 11:37 AM Daniel P. Smith wrote: On 9/13/24 23:57, Andy Lutomirski wrote: On Thu, Sep 12, 2024 at 5:34 PM

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-09-21 Thread Andy Lutomirski
On Sat, Sep 21, 2024 at 11:37 AM Daniel P. Smith wrote: > > On 9/13/24 23:57, Andy Lutomirski wrote: > > On Thu, Sep 12, 2024 at 5:34 PM Daniel P. Smith > > wrote: > >> > > What, exactly, is your patchset doing that requires hashing at all? > > (I assume it's extending a PCR and generating an ev

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-09-21 Thread Daniel P. Smith
On 9/13/24 23:57, Andy Lutomirski wrote: On Thu, Sep 12, 2024 at 5:34 PM Daniel P. Smith wrote: Hey again, On 9/4/24 21:01, Daniel P. Smith wrote: Hi Luto. On 8/28/24 23:17, Andy Lutomirski wrote: On Thu, Aug 15, 2024 at 12:10 PM Thomas Gleixner wrote: On Thu, Aug 15 2024 at 13:38, Dani

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-09-13 Thread Andy Lutomirski
On Thu, Sep 12, 2024 at 5:34 PM Daniel P. Smith wrote: > > Hey again, > > On 9/4/24 21:01, Daniel P. Smith wrote: > > Hi Luto. > > > > On 8/28/24 23:17, Andy Lutomirski wrote: > >> On Thu, Aug 15, 2024 at 12:10 PM Thomas Gleixner > >> wrote: > >>> > >>> On Thu, Aug 15 2024 at 13:38, Daniel P. Smi

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-09-12 Thread Daniel P. Smith
Hey again, On 9/4/24 21:01, Daniel P. Smith wrote: Hi Luto. On 8/28/24 23:17, Andy Lutomirski wrote: On Thu, Aug 15, 2024 at 12:10 PM Thomas Gleixner wrote: On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: On 5/31/24 09:54, Eric W. Biederman wrote: Eric Biggers writes: That paragraph

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-09-04 Thread Daniel P. Smith
Hi Luto. On 8/28/24 23:17, Andy Lutomirski wrote: On Thu, Aug 15, 2024 at 12:10 PM Thomas Gleixner wrote: On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: On 5/31/24 09:54, Eric W. Biederman wrote: Eric Biggers writes: That paragraph is also phrased as a hypothetical, "Even if we'd pr

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-29 Thread Andy Lutomirski
On Wed, Aug 28, 2024 at 8:25 PM Matthew Garrett wrote: > > On Wed, Aug 28, 2024 at 08:17:05PM -0700, Andy Lutomirski wrote: > > > Ross et al, can you confirm that your code actually, at least by > > default and with a monstrous warning to anyone who tries to change the > > default, caps SHA1 PCRs

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-28 Thread Matthew Garrett
On Wed, Aug 28, 2024 at 08:17:05PM -0700, Andy Lutomirski wrote: > Ross et al, can you confirm that your code actually, at least by > default and with a monstrous warning to anyone who tries to change the > default, caps SHA1 PCRs if SHA256 is available? And then can we maybe > all stop hassling

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-28 Thread Andy Lutomirski
On Thu, Aug 15, 2024 at 12:10 PM Thomas Gleixner wrote: > > On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: > > On 5/31/24 09:54, Eric W. Biederman wrote: > >> Eric Biggers writes: > >>> That paragraph is also phrased as a hypothetical, "Even if we'd prefer to > >>> use > >>> SHA-256-only".

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-28 Thread Eric Biggers
On Wed, Aug 28, 2024 at 01:14:45PM -0700, ross.philip...@oracle.com wrote: > On 8/27/24 11:14 AM, 'Eric Biggers' via trenchboot-devel wrote: > > On Thu, May 30, 2024 at 07:16:56PM -0700, Eric Biggers wrote: > > > On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: > > > > From: "Daniel

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-28 Thread ross . philipson
On 8/27/24 11:14 AM, 'Eric Biggers' via trenchboot-devel wrote: On Thu, May 30, 2024 at 07:16:56PM -0700, Eric Biggers wrote: On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashe

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-27 Thread Eric Biggers
On Thu, May 30, 2024 at 07:16:56PM -0700, Eric Biggers wrote: > On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: > > From: "Daniel P. Smith" > > > > For better or worse, Secure Launch needs SHA-1 and SHA-256. The > > choice of hashes used lie with the platform firmware, not with >

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-22 Thread Daniel P. Smith
On 8/15/24 15:10, Thomas Gleixner wrote: On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: On 5/31/24 09:54, Eric W. Biederman wrote: Eric Biggers writes: That paragraph is also phrased as a hypothetical, "Even if we'd prefer to use SHA-256-only". That implies that you do not, in fact, pr

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-20 Thread Jarkko Sakkinen
On Mon Aug 19, 2024 at 9:24 PM EEST, Matthew Garrett wrote: > On Mon, Aug 19, 2024 at 09:05:47PM +0300, Jarkko Sakkinen wrote: > > On Fri Aug 16, 2024 at 9:41 PM EEST, Matthew Garrett wrote: > > > On Fri, Aug 16, 2024 at 02:22:04PM +0300, Jarkko Sakkinen wrote: > > > > > > > For (any) non-legacy fe

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-19 Thread Matthew Garrett
On Mon, Aug 19, 2024 at 09:05:47PM +0300, Jarkko Sakkinen wrote: > On Fri Aug 16, 2024 at 9:41 PM EEST, Matthew Garrett wrote: > > On Fri, Aug 16, 2024 at 02:22:04PM +0300, Jarkko Sakkinen wrote: > > > > > For (any) non-legacy features we can choose, which choices we choose to > > > support, and wh

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-19 Thread Jarkko Sakkinen
On Fri Aug 16, 2024 at 9:41 PM EEST, Matthew Garrett wrote: > On Fri, Aug 16, 2024 at 02:22:04PM +0300, Jarkko Sakkinen wrote: > > > For (any) non-legacy features we can choose, which choices we choose to > > support, and which we do not. This is not an oppositive view just saying > > how it is, an

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-16 Thread Matthew Garrett
On Fri, Aug 16, 2024 at 02:22:04PM +0300, Jarkko Sakkinen wrote: > For (any) non-legacy features we can choose, which choices we choose to > support, and which we do not. This is not an oppositive view just saying > how it is, and platforms set of choices is not a selling argument. NIST still per

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-16 Thread Jarkko Sakkinen
On Fri Aug 16, 2024 at 2:01 PM EEST, Andrew Cooper wrote: > On 15/08/2024 8:10 pm, Thomas Gleixner wrote: > > On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: > >> On 5/31/24 09:54, Eric W. Biederman wrote: > >>> Eric Biggers writes: > That paragraph is also phrased as a hypothetical, "Ev

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-16 Thread Andrew Cooper
On 15/08/2024 8:10 pm, Thomas Gleixner wrote: > On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: >> On 5/31/24 09:54, Eric W. Biederman wrote: >>> Eric Biggers writes: That paragraph is also phrased as a hypothetical, "Even if we'd prefer to use SHA-256-only". That implies tha

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-16 Thread Jarkko Sakkinen
On Thu Aug 15, 2024 at 10:10 PM EEST, Thomas Gleixner wrote: > On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: > > On 5/31/24 09:54, Eric W. Biederman wrote: > >> Eric Biggers writes: > >>> That paragraph is also phrased as a hypothetical, "Even if we'd prefer to > >>> use > >>> SHA-256-only

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-15 Thread Thomas Gleixner
On Thu, Aug 15 2024 at 13:38, Daniel P. Smith wrote: > On 5/31/24 09:54, Eric W. Biederman wrote: >> Eric Biggers writes: >>> That paragraph is also phrased as a hypothetical, "Even if we'd prefer to >>> use >>> SHA-256-only". That implies that you do not, in fact, prefer SHA-256 only. >>> Is

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-08-15 Thread Daniel P. Smith
On 5/31/24 09:54, Eric W. Biederman wrote: Eric Biggers writes: On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashes used lie with the platform firmware, not with software, an

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-06-04 Thread Jarkko Sakkinen
On Wed Jun 5, 2024 at 12:02 AM EEST, wrote: > On 6/4/24 11:52 AM, Jarkko Sakkinen wrote: > > On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: > >> From: "Daniel P. Smith" > >> > >> For better or worse, Secure Launch needs SHA-1 and SHA-256. The > >> choice of hashes used lie with the pl

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-06-04 Thread ross . philipson
On 6/4/24 11:52 AM, Jarkko Sakkinen wrote: On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashes used lie with the platform firmware, not with software, and is often outside of the use

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-06-04 Thread Jarkko Sakkinen
On Fri May 31, 2024 at 4:03 AM EEST, Ross Philipson wrote: > From: "Daniel P. Smith" > > For better or worse, Secure Launch needs SHA-1 and SHA-256. The > choice of hashes used lie with the platform firmware, not with > software, and is often outside of the users control. > > Even if we'd prefer t

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-05-31 Thread ross . philipson
On 5/30/24 7:16 PM, Eric Biggers wrote: On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashes used lie with the platform firmware, not with software, and is often outside of the u

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-05-31 Thread Eric W. Biederman
Eric Biggers writes: > On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: >> From: "Daniel P. Smith" >> >> For better or worse, Secure Launch needs SHA-1 and SHA-256. The >> choice of hashes used lie with the platform firmware, not with >> software, and is often outside of the user

Re: [PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-05-30 Thread Eric Biggers
On Thu, May 30, 2024 at 06:03:18PM -0700, Ross Philipson wrote: > From: "Daniel P. Smith" > > For better or worse, Secure Launch needs SHA-1 and SHA-256. The > choice of hashes used lie with the platform firmware, not with > software, and is often outside of the users control. > > Even if we'd p

[PATCH v9 06/19] x86: Add early SHA-1 support for Secure Launch early measurements

2024-05-30 Thread Ross Philipson
From: "Daniel P. Smith" For better or worse, Secure Launch needs SHA-1 and SHA-256. The choice of hashes used lie with the platform firmware, not with software, and is often outside of the users control. Even if we'd prefer to use SHA-256-only, if firmware elected to start us with the SHA-1 and