Re: [PATCH v5 09/19] iommu/arm-smmu: Consolidate stream map entry state

2016-09-01 Thread Will Deacon
On Thu, Sep 01, 2016 at 07:45:51PM +0100, Robin Murphy wrote: > On 01/09/16 19:32, Will Deacon wrote: > > On Tue, Aug 23, 2016 at 08:05:20PM +0100, Robin Murphy wrote: > >> - while (--i >= 0) > >> - __arm_smmu_free_bitmap(smmu->smr_map, smrs[i].idx); > >> - kfree(smrs); > >> + while (i-

Re: [PATCH v5 09/19] iommu/arm-smmu: Consolidate stream map entry state

2016-09-01 Thread Robin Murphy
On 01/09/16 19:32, Will Deacon wrote: > On Tue, Aug 23, 2016 at 08:05:20PM +0100, Robin Murphy wrote: >> In order to consider SMR masking, we really want to be able to validate >> ID/mask pairs against existing SMR contents to prevent stream match >> conflicts, which at best would cause transaction

Re: [PATCH v5 09/19] iommu/arm-smmu: Consolidate stream map entry state

2016-09-01 Thread Will Deacon
On Tue, Aug 23, 2016 at 08:05:20PM +0100, Robin Murphy wrote: > In order to consider SMR masking, we really want to be able to validate > ID/mask pairs against existing SMR contents to prevent stream match > conflicts, which at best would cause transactions to fault unexpectedly, > and at worst lea

[PATCH v5 09/19] iommu/arm-smmu: Consolidate stream map entry state

2016-08-23 Thread Robin Murphy
In order to consider SMR masking, we really want to be able to validate ID/mask pairs against existing SMR contents to prevent stream match conflicts, which at best would cause transactions to fault unexpectedly, and at worst lead to silent unpredictable behaviour. With our SMMU instance data holdi