Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-31 Thread Drew Fustini
On Wed, Mar 30, 2022 at 02:33:23PM -0300, Jason Gunthorpe wrote: > On Wed, Mar 30, 2022 at 08:19:37PM +0300, Tony Lindgren wrote: > > > > > __iommu_probe_device from probe_iommu_group+0x2c/0x38 > > > > probe_iommu_group from bus_for_each_dev+0x74/0xbc > > > > bus_for_each_dev from bus_iommu_probe+

Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-30 Thread Tony Lindgren
Hi, * Jason Gunthorpe [220330 17:31]: > On Wed, Mar 30, 2022 at 08:19:37PM +0300, Tony Lindgren wrote: > > > > > __iommu_probe_device from probe_iommu_group+0x2c/0x38 > > > > probe_iommu_group from bus_for_each_dev+0x74/0xbc > > > > bus_for_each_dev from bus_iommu_probe+0x34/0x2e8 > > > > bus_io

Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-30 Thread Jason Gunthorpe via iommu
On Wed, Mar 30, 2022 at 08:19:37PM +0300, Tony Lindgren wrote: > > > __iommu_probe_device from probe_iommu_group+0x2c/0x38 > > > probe_iommu_group from bus_for_each_dev+0x74/0xbc > > > bus_for_each_dev from bus_iommu_probe+0x34/0x2e8 > > > bus_iommu_probe from bus_set_iommu+0x80/0xc8 > > > bus_set

Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-30 Thread Tony Lindgren
* Jason Gunthorpe [220330 14:21]: > On Wed, Mar 30, 2022 at 05:00:39PM +0300, Tony Lindgren wrote: > > Hi, > > > > * Lu Baolu [700101 02:00]: > > > The is_attach_deferred iommu_ops callback is a device op. The domain > > > argument is unnecessary and never used. Remove it to make code clean. > >

Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-30 Thread Jason Gunthorpe via iommu
On Wed, Mar 30, 2022 at 05:00:39PM +0300, Tony Lindgren wrote: > Hi, > > * Lu Baolu [700101 02:00]: > > The is_attach_deferred iommu_ops callback is a device op. The domain > > argument is unnecessary and never used. Remove it to make code clean. > > Looks like this causes a regression for at le

Re: [PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-03-30 Thread Tony Lindgren
Hi, * Lu Baolu [700101 02:00]: > The is_attach_deferred iommu_ops callback is a device op. The domain > argument is unnecessary and never used. Remove it to make code clean. Looks like this causes a regression for at least drivers/iommu/omap-iommu.c. To me it seems the issue is there is no is_a

[PATCH v4 8/9] iommu: Remove unused argument in is_attach_deferred

2022-02-15 Thread Lu Baolu
The is_attach_deferred iommu_ops callback is a device op. The domain argument is unnecessary and never used. Remove it to make code clean. Suggested-by: Robin Murphy Signed-off-by: Lu Baolu Reviewed-by: Christoph Hellwig Reviewed-by: Jason Gunthorpe --- include/linux/iommu.h | 2 +-