Re: [PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-08-24 Thread Robin Murphy
On 29/07/16 19:55, Robin Murphy wrote: > On 29/07/16 15:46, Jean-Philippe Brucker wrote: >> Hi Robin, >> >> Very sorry about the delay, I forgot about this minor comment, below >> >> On Fri, Jul 01, 2016 at 05:50:15PM +0100, Robin Murphy wrote: [...] >>> + smmu = arm_smmu_get_by_node(fwsp

Re: [PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-07-29 Thread Robin Murphy
On 29/07/16 15:46, Jean-Philippe Brucker wrote: > Hi Robin, > > Very sorry about the delay, I forgot about this minor comment, below > > On Fri, Jul 01, 2016 at 05:50:15PM +0100, Robin Murphy wrote: >> Now that we can properly describe the mapping between PCI RIDs and >> stream IDs via "iommu-map

Re: [PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-07-29 Thread Jean-Philippe Brucker
Hi Robin, Very sorry about the delay, I forgot about this minor comment, below On Fri, Jul 01, 2016 at 05:50:15PM +0100, Robin Murphy wrote: > Now that we can properly describe the mapping between PCI RIDs and > stream IDs via "iommu-map", and have it fed it to the driver > automatically via of_x

Re: [PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-07-15 Thread Robin Murphy
On 15/07/16 14:55, Lorenzo Pieralisi wrote: > On Fri, Jul 01, 2016 at 05:50:15PM +0100, Robin Murphy wrote: > > [...] > >> +static int arm_smmu_of_xlate(struct device *dev, struct of_phandle_args >> *args) >> +{ >> +int ret; >> + >> +/* We only support PCI, for now */ >> +if (!dev_is

Re: [PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-07-15 Thread Lorenzo Pieralisi
On Fri, Jul 01, 2016 at 05:50:15PM +0100, Robin Murphy wrote: [...] > +static int arm_smmu_of_xlate(struct device *dev, struct of_phandle_args > *args) > +{ > + int ret; > + > + /* We only support PCI, for now */ > + if (!dev_is_pci(dev)) > + return -ENODEV; Given that a

[PATCH v4 6/8] iommu/arm-smmu: Implement of_xlate() for SMMUv3

2016-07-01 Thread Robin Murphy
Now that we can properly describe the mapping between PCI RIDs and stream IDs via "iommu-map", and have it fed it to the driver automatically via of_xlate(), rework the SMMUv3 driver to benefit from that, and get rid of the current misuse of the "iommus" binding. Since having of_xlate wired up mea