Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode

2018-11-04 Thread Lu Baolu
Hi, On 11/5/18 3:15 PM, Christoph Hellwig wrote: --- a/include/linux/dma_remapping.h +++ b/include/linux/dma_remapping.h FYI, this file seems to be entirely VT-D specific, but has an awfully generic name. It should be renamed to something more suitable (or maybe just merged into intel-iommu.h

Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode

2018-11-04 Thread Christoph Hellwig
> --- a/include/linux/dma_remapping.h > +++ b/include/linux/dma_remapping.h FYI, this file seems to be entirely VT-D specific, but has an awfully generic name. It should be renamed to something more suitable (or maybe just merged into intel-iommu.h?) and also grow some comments describing the con

[PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable mode

2018-11-04 Thread Lu Baolu
This patch enables the current SVA (Shared Virtual Address) implementation to work in the scalable mode. Cc: Ashok Raj Cc: Jacob Pan Cc: Kevin Tian Cc: Liu Yi L Signed-off-by: Sanjay Kumar Signed-off-by: Lu Baolu Reviewed-by: Ashok Raj --- drivers/iommu/intel-iommu.c | 38 ---