Re: [PATCH v3 3/5] iommu: Add Allwinner H6 IOMMU driver

2020-05-13 Thread Maxime Ripard
Hi Jörg, On Wed, May 13, 2020 at 11:53:04AM +0200, Joerg Roedel wrote: > On Tue, May 05, 2020 at 12:09:32PM +0200, Maxime Ripard wrote: > > +static u32 *sun50i_dte_get_page_table(struct sun50i_iommu_domain > > *sun50i_domain, > > + dma_addr_t iova, gfp_t gfp) > > +

Re: [PATCH v3 3/5] iommu: Add Allwinner H6 IOMMU driver

2020-05-13 Thread Joerg Roedel
On Tue, May 05, 2020 at 12:09:32PM +0200, Maxime Ripard wrote: > +static u32 *sun50i_dte_get_page_table(struct sun50i_iommu_domain > *sun50i_domain, > + dma_addr_t iova, gfp_t gfp) > +{ > + struct sun50i_iommu *iommu = sun50i_domain->iommu; > + unsigned lo

[PATCH v3 3/5] iommu: Add Allwinner H6 IOMMU driver

2020-05-05 Thread Maxime Ripard
The Allwinner H6 has introduced an IOMMU for a few DMA controllers, mostly video related: the display engine, the video decoders / encoders, the camera capture controller, etc. The design is pretty simple compared to other IOMMUs found in SoCs: there's a single instance, controlling all the master