Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT

2021-06-10 Thread Jean-Philippe Brucker
On Fri, Jun 04, 2021 at 05:22:07PM +0200, Joerg Roedel wrote: > On Thu, Jun 03, 2021 at 09:26:39AM +0200, Jean-Philippe Brucker wrote: > > These are only defined when CONFIG_IOMMU_API is set. IORT uses them inside > > an #ifdef, I can do the same. Maybe moving these two functions to a new > > drive

Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT

2021-06-04 Thread Joerg Roedel
On Thu, Jun 03, 2021 at 09:26:39AM +0200, Jean-Philippe Brucker wrote: > These are only defined when CONFIG_IOMMU_API is set. IORT uses them inside > an #ifdef, I can do the same. Maybe moving these two functions to a new > drivers/acpi/iommu.c would be nicer, though. Not sure what the ACPI mainta

Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT

2021-06-03 Thread Jean-Philippe Brucker
On Thu, Jun 03, 2021 at 04:06:18AM +0800, kernel test robot wrote: > >> drivers/acpi/scan.c:1540:26: error: no member named 'ops' in 'struct > >> iommu_fwspec' >return fwspec ? fwspec->ops : NULL; >~~ ^ > >> drivers/acpi/scan.c:1564:9: error: implicit d

Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT

2021-06-02 Thread kernel test robot
Hi Jean-Philippe, I love your patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on iommu/next arm64/for-next/core linus/master v5.13-rc4 next-20210602] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT

2021-06-02 Thread Jean-Philippe Brucker
Extract the code that sets up the IOMMU infrastructure from IORT, since it can be reused by VIOT. Move it one level up into a new acpi_iommu_configure_id() function, which calls the IORT parsing function which in turn calls the acpi_iommu_fwspec_init() helper. Signed-off-by: Jean-Philippe Brucker